June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | Am 03.06.2016 um 13:47 schrieb Sönke Ludwig:
> Am 03.06.2016 um 11:49 schrieb ag0aep6g:
>> On 06/02/2016 09:09 PM, Sönke Ludwig wrote:
>>> Which are the remaining issues that you know of?
>>
>> Next up: MYREF.
>>
>> Example page with missing links:
>> http://dlang.org/library/std/string.html
>>
>> In std.ddoc, MYREF is defined as:
>>
>> MYREF = <a href="#.$1">$(TT $1)</a>$(NBSP)
>>
>> In std-ddox-override.ddoc it's:
>>
>> MYREF = $1
>>
>> That's no good, of course. But I also don't see a way to define it
>> properly. It would have to be something like this:
>>
>> MYREF = <a href="./$(MODULE)/$1.html">$(TT $1)</a>$(NBSP)
>>
>> where $(MODULE) is the current module name without packages.
>>
>> But:
>>
>> 1) Something like $(MODULE) doesn't seem to exist. (Loosely related:
>> DDOX doesn't emit $(TITLE) properly.)
>>
>> 2) camelCase strikes again. $1 would have to be transformed from fooBar
>> to foo_bar to match DDOX's naming scheme. No can do with macros alone. I
>> think those underscore names may have been a mistakee.
>
> Since only 12 modules are affected, probably the easiest way is to use
> the same approach as std.algorithm and define MYREF in each module
> separately as:
>
> MYREF = $(REF_ALTTEXT $(TT $1), $1, std, xxx)$(NBSP)
>
> And then remove the definition from std.ddoc
Wait a minute... MYREF = $(D $1) in std-ddox-override.ddoc should actually do the job just fine. Those links should have actually worked before until I removed full-text automatic cross-references from DDOX.
|
June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | On 06/03/2016 01:59 PM, Sönke Ludwig wrote:
> Wait a minute... MYREF = $(D $1) in std-ddox-override.ddoc should
> actually do the job just fine. Those links should have actually worked
> before until I removed full-text automatic cross-references from DDOX.
So DDOX is supposed to link any symbol just by its name, without being fully qualified?
I'm not sure if that's good. We've had a couple problems with Ddoc being annoyingly eager in highlighting parameter names and such. This goes even further, doesn't it?
|
June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to ag0aep6g | On Friday, 3 June 2016 at 12:08:33 UTC, ag0aep6g wrote:
> On 06/03/2016 01:59 PM, Sönke Ludwig wrote:
>> Wait a minute... MYREF = $(D $1) in std-ddox-override.ddoc should
>> actually do the job just fine. Those links should have actually worked
>> before until I removed full-text automatic cross-references from DDOX.
>
> So DDOX is supposed to link any symbol just by its name, without being fully qualified?
Only in code blocks (i.e. $(D ...) or `...`).
|
June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | On 6/3/16 7:59 AM, Sönke Ludwig wrote:
> Wait a minute... MYREF = $(D $1) in std-ddox-override.ddoc should
> actually do the job just fine. Those links should have actually worked
> before until I removed full-text automatic cross-references from DDOX.
This seems good, please try it out and post a PR if it works. -- Andrei
|
June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On 06/03/2016 02:15 PM, Vladimir Panteleev wrote:
> Only in code blocks (i.e. $(D ...) or `...`).
Makes sense :)
|
June 03, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu | Am 03.06.2016 um 14:16 schrieb Andrei Alexandrescu: > On 6/3/16 7:59 AM, Sönke Ludwig wrote: >> Wait a minute... MYREF = $(D $1) in std-ddox-override.ddoc should >> actually do the job just fine. Those links should have actually worked >> before until I removed full-text automatic cross-references from DDOX. > > This seems good, please try it out and post a PR if it works. -- Andrei I'm already on it: https://github.com/dlang/dlang.org/pull/1324 |
June 08, 2016 Re: Broken links continue to exist on major pages on dlang.org | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu | On Thursday, 2 June 2016 at 20:09:57 UTC, Andrei Alexandrescu wrote: > On 06/02/2016 03:27 PM, Adam D. Ruppe wrote: >> Fixing links is, in theory, one of the easiest tasks people can do, but >> in practice the plethora of bizarre macros makes it far harder than it >> should be. > > We'd be greatly helped by some automation here (i.e. pinpoint the wrong links). -- Andrei I did a (quite long actually) “wget --spider -o ~/wget.log -e robots=off -w 1 -r -p http://dlang.org/” to get a list of unused links. There are 690 of them, you can find the list there [1]. If you need the full log of the scan ask for it by mail, it's about 350000 lines long so I don't feel like pasting it. [1]: http://paste.devys.org/mydalona/raw |
Copyright © 1999-2021 by the D Language Foundation