On 6/27/2017 7:32 AM, Vladimir Panteleev wrote:
> As has been announced, DMD now has colorized syntax highlighting in error messages:
> 
> http://forum.dlang.org/post/of9oao$230j$1@digitalmars.com
> 
> With 2.075's release near, now would be a good time to decide on a nice color palette that looks fine on most terminals. So, please vote:
> 
> https://github.com/dlang/dmd/pull/6943

In the spirit of this, a lot of (rather tedious) work needs to be done on the error messages themselves to enable color syntax highlighting. Specifically, replacing ' ' with ` `, and adding ` ` around %s formats when code is being emitted to the %s.

It's tedious because of all the messages in test/fail_compilation/* that need updating.

It would also be helpful to pull things like:

  https://github.com/dlang/dmd/pull/6890

On 2017-06-27 19:11, H. S. Teoh via Digitalmars-d wrote:

> The cardinal rule of color selection: NEVER only set the foreground
> color or the background color alone. ALWAYS set both, otherwise you will
> get invisible text (or barely-visible text, like yellow on white) on
> somebody's terminal, and they will be very, very angry.

Since an application cannot set any explicit colors, only symbolic names for colors, and they're limited to 16. It's up to the theme of the terminal emulator to make sure all colors look good on the chosen background color.

-- 
/Jacob Carlborg

On 2017-06-27 23:10, Sönke Ludwig wrote:

> Just ruling out a white background would be
> a bad idea. I think on macOS that's the default, for example.

Yes, default background color on the default terminal emulator.

-- 
/Jacob Carlborg

On Tuesday, 27 June 2017 at 14:32:28 UTC, Vladimir Panteleev wrote:

> - Yes, not everyone likes colors. You can turn all colors off with a command-line switch.
> - Yes, everyone agrees that having all colors be configurable would be good. We still need defaults that are going to look OK on most terminals.
> - Yes, no matter what colors we choose, they're going to look bad on some terminal somewhere. Let's worry about the major platforms' most common terminals for now.

All of these points give added weight to this feature being opt in, not opt out. Why would we want to make output worse? Also, we shouldn't syntax highlight the message, just colour the whole line.

On Tuesday, 27 June 2017 at 23:38:23 UTC, Sönke Ludwig wrote:
> Am 28.06.2017 um 01:24 schrieb Vladimir Panteleev:
>> And Windows?
>
> Good point, I forgot about that and it can definitely not be ignored. A separate 16-color theme just on Windows, however, could still be an option.

Windows can do true colors [1]

[1] http://forum.dlang.org/post/gfreuclhvrzpfgqroiib@forum.dlang.org

On 28-06-17 01:34, Moritz Maxeiner wrote:
> 
> All these can even do true colors on Windows:
> - https://blogs.msdn.microsoft.com/commandline/2016/09/22/24-bit-color-in-the-windows-console/ 
> 

On Windows 10, and in that case you can even use the vt100 escape sequences: https://msdn.microsoft.com/en-us/library/windows/desktop/mt638032(v=vs.85).aspx


-- 
Mike Wey

On 06/27/2017 10:32 AM, Vladimir Panteleev wrote:
> As has been announced, DMD now has colorized syntax highlighting in error messages:
> 
> http://forum.dlang.org/post/of9oao$230j$1@digitalmars.com
> 
> With 2.075's release near, now would be a good time to decide on a nice color palette that looks fine on most terminals. So, please vote:
> 

Hasn't DMD already been coloring error messages for about the past year? Or is it DUB that's been doing that to DMD's output? Or are we talking about something different then what was already there?

On Thursday, 29 June 2017 at 01:45:11 UTC, Nick Sabalausky (Abscissa) wrote:
> Hasn't DMD already been coloring error messages for about the past year? Or is it DUB that's been doing that to DMD's output? Or are we talking about something different then what was already there?

Please, click, the, link. Screenshots and details inside.

https://github.com/dlang/dmd/pull/6943

This times 1000

On Wed, Jun 28, 2017 at 3:11 AM, H. S. Teoh via Digitalmars-d < digitalmars-d@puremagic.com> wrote:

> On Tue, Jun 27, 2017 at 02:32:28PM +0000, Vladimir Panteleev via Digitalmars-d wrote:
> > As has been announced, DMD now has colorized syntax highlighting in error messages:
> >
> > http://forum.dlang.org/post/of9oao$230j$1@digitalmars.com
> >
> > With 2.075's release near, now would be a good time to decide on a nice color palette that looks fine on most terminals. So, please vote:
> >
> > https://github.com/dlang/dmd/pull/6943
> >
> > Obligatory:
> > - Yes, not everyone likes colors. You can turn all colors off with a
> > command-line switch.
> > - Yes, everyone agrees that having all colors be configurable would be
> > good.  We still need defaults that are going to look OK on most
> > terminals.
> > - Yes, no matter what colors we choose, they're going to look bad on
> > some terminal somewhere. Let's worry about the major platforms' most
> > common terminals for now.
>
> The cardinal rule of color selection: NEVER only set the foreground color or the background color alone. ALWAYS set both, otherwise you will get invisible text (or barely-visible text, like yellow on white) on somebody's terminal, and they will be very, very angry.
>
>
> T
>
> --
> Marketing: the art of convincing people to pay for what they didn't need before which you fail to deliver after.
>

On Tuesday, 27 June 2017 at 14:32:28 UTC, Vladimir Panteleev wrote:
> - Yes, not everyone likes colors. You can turn all colors off with a command-line switch.

Which is?