February 28, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to igeek Attachments:
| On Mon, Feb 27, 2012 at 11:45 PM, igeek <evermind@live.ru> wrote:
> Could anybody explain why you want to include curl in Phobos? Maybe Phobos have some native function that allow to do some thing that curl are doing?
>
It's already in Phobos as part of std.net.curl. It's just not very usable on Windows yet.
Curl has a phobos friendly license and implementing it in D is a fairly large undertaking (just look at the size of curl). Nothing is stopping anyone from doing a pure D networking client module, of course. Using curl was just a very quick way of getting this functionality into Phobos.
Regards,
Brad Anderson
|
February 28, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Brad Anderson | On 2/26/2012 6:39 PM, Brad Anderson wrote:
> If phobos can include zlib, I see no reason it couldn't include libcurl.
Yes, we do include zlib, but I don't think that is a precedent we should follow. Including such third party libraries is potentially a large support burden and source of conflict as those libraries get updated. It's already been a problem with zlib. It's beyond the scope of what D should be to take this stuff on.
Instead, we should provide download links so the user can install it themselves as required.
As for the auto tester breaking, a better approach might be to install curl on the test system, or simply not run those tests.
|
February 28, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright Attachments:
| On Tue, Feb 28, 2012 at 2:36 PM, Walter Bright <newshound2@digitalmars.com>wrote: > On 2/26/2012 6:39 PM, Brad Anderson wrote: > >> If phobos can include zlib, I see no reason it couldn't include libcurl. >> > > Yes, we do include zlib, but I don't think that is a precedent we should follow. Including such third party libraries is potentially a large support burden and source of conflict as those libraries get updated. It's already been a problem with zlib. It's beyond the scope of what D should be to take this stuff on. > > Instead, we should provide download links so the user can install it themselves as required. > > As for the auto tester breaking, a better approach might be to install curl on the test system, or simply not run those tests. > Ok, take that approach for the revised pull request. Regards, Brad Anderson |
February 29, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Tuesday, 28 February 2012 at 21:36:28 UTC, Walter Bright wrote:
> On 2/26/2012 6:39 PM, Brad Anderson wrote:
>> If phobos can include zlib, I see no reason it couldn't include libcurl.
>
> Yes, we do include zlib, but I don't think that is a precedent we should follow. Including such third party libraries is potentially a large support burden and source of conflict as those libraries get updated. It's already been a problem with zlib. It's beyond the scope of what D should be to take this stuff on.
>
> Instead, we should provide download links so the user can install it themselves as required.
>
> As for the auto tester breaking, a better approach might be to install curl on the test system, or simply not run those tests.
It seems somewhat strange to me to have a hidden dependency that, despite being included in the standard library, can not be used with a default install.
What about an option in the default installer to download these third party libraries (and on Windows coffimplib them)?
|
February 29, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Kapps | On Wednesday, 29 February 2012 at 00:53:55 UTC, Kapps wrote: > On Tuesday, 28 February 2012 at 21:36:28 UTC, Walter Bright wrote: >> On 2/26/2012 6:39 PM, Brad Anderson wrote: >>> If phobos can include zlib, I see no reason it couldn't include libcurl. >> >> Yes, we do include zlib, but I don't think that is a precedent we should follow. Including such third party libraries is potentially a large support burden and source of conflict as those libraries get updated. It's already been a problem with zlib. It's beyond the scope of what D should be to take this stuff on. >> >> Instead, we should provide download links so the user can install it themselves as required. >> >> As for the auto tester breaking, a better approach might be to install curl on the test system, or simply not run those tests. > > It seems somewhat strange to me to have a hidden dependency that, despite being included in the standard library, can not be used with a default install. > > What about an option in the default installer to download these third party libraries (and on Windows coffimplib them)? https://github.com/D-Programming-Language/installer/pull/7 Regards, Brad Anderson |
February 29, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Tuesday, 28 February 2012 at 21:36:28 UTC, Walter Bright wrote: > On 2/26/2012 6:39 PM, Brad Anderson wrote: >> If phobos can include zlib, I see no reason it couldn't include libcurl. > > Yes, we do include zlib, but I don't think that is a precedent we should follow. Including such third party libraries is potentially a large support burden and source of conflict as those libraries get updated. It's already been a problem with zlib. It's beyond the scope of what D should be to take this stuff on. > > Instead, we should provide download links so the user can install it themselves as required. > > As for the auto tester breaking, a better approach might be to install curl on the test system, or simply not run those tests. https://github.com/D-Programming-Language/phobos/pull/466 https://github.com/D-Programming-Language/d-programming-language.org/pull/92 https://github.com/D-Programming-Language/installer/pull/7 Regards, Brad Anderson |
March 01, 2012 Re: Curl on Windows | ||||
---|---|---|---|---|
| ||||
Posted in reply to Brad Roberts | Am 27.02.2012, 03:15 Uhr, schrieb Brad Roberts <braddr@puremagic.com>:
> […] non-windows can suggest how to install via the standard package managers […]
On Gentoo USE flags handle such cases. They enable additional dependencies on Curl, Python, zlib or whatever may be used with the installed package. Often these flags directly relate to calling "./configure --enable/disable-flag" in the extracted source of the program and pulling a required library into the dependencies list.
Now I know that DMD uses a plain Makefile, but it would be nice if Phobos compiled without curl installed. If not, that's no problem either and curl would just become a static dependency for DMD. That's already the case for LibreOffice, GoogleEarth, cmake and gnupg, to name a few programs I have installed. Git and Gimp have curl as an optional dependency OTOH.
|
Copyright © 1999-2021 by the D Language Foundation