Thread overview | ||||||
---|---|---|---|---|---|---|
|
June 03, 2011 [Issue 6099] New: std.windows.registry exposes too much implementation details | ||||
---|---|---|---|---|
| ||||
http://d.puremagic.com/issues/show_bug.cgi?id=6099 Summary: std.windows.registry exposes too much implementation details Product: D Version: D2 Platform: Other OS/Version: Windows Status: NEW Severity: normal Priority: P2 Component: Phobos AssignedTo: nobody@puremagic.com ReportedBy: kai@redstar.de --- Comment #0 from kai@redstar.de 2011-06-03 07:49:03 PDT --- Created an attachment (id=992) Hide implementation details in std.windows.registry The program import core.sys.windows.windows; import std.windows.registry; void main() { auto error = GetLastError(); } causes an error because GetLastError() is declared and exported from both modules. Personally, I do not expect such conflicts from a library. The root cause is that std.windows.registry exposes too much implementation details. The attached patch changes the following: - The windows API functions are not exported - Windows API functions duplicated from core.sys.windows.windows are removed - Type boolean is replaced by standard bool -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
June 03, 2011 [Issue 6099] std.windows.registry exposes too much implementation details | ||||
---|---|---|---|---|
| ||||
Posted in reply to kai@redstar.de | http://d.puremagic.com/issues/show_bug.cgi?id=6099 Andrei Alexandrescu <andrei@metalanguage.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrei@metalanguage.com --- Comment #1 from Andrei Alexandrescu <andrei@metalanguage.com> 2011-06-03 07:52:05 PDT --- Thanks! Any chance you could submit your patch as a pull request to https://github.com/D-Programming-Language/phobos/pulls? -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
June 03, 2011 [Issue 6099] std.windows.registry exposes too much implementation details | ||||
---|---|---|---|---|
| ||||
Posted in reply to kai@redstar.de | http://d.puremagic.com/issues/show_bug.cgi?id=6099 --- Comment #2 from kai@redstar.de 2011-06-03 11:02:03 PDT --- Here's the pull request: https://github.com/D-Programming-Language/phobos/pull/75 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
December 10, 2012 [Issue 6099] std.windows.registry exposes too much implementation details | ||||
---|---|---|---|---|
| ||||
Posted in reply to kai@redstar.de | http://d.puremagic.com/issues/show_bug.cgi?id=6099 Andrej Mitrovic <andrej.mitrovich@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |andrej.mitrovich@gmail.com Resolution| |FIXED -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
Copyright © 1999-2021 by the D Language Foundation