[Issue 1832] reading/writing an archive causes data loss; std.zip horribly broken (page 2)

https://d.puremagic.com/issues/show_bug.cgi?id=1832 --- Comment #11 from Andrea Fontana <advmail@katamail.com> 2013-12-06 12:54:09 PST --- I think it's not so easy to fix this "cross-archive" member management. Consider for example expand() function. It uses data[] from ZipArchive, but uses offset from ArchiveMember, that was created from another data[]. BTW it's not the same bug as the original one, I guess. My vote goes for a full replacement of std.zip -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=1832 --- Comment #12 from Martin Nowak <code@dawg.eu> 2014-01-12 12:11:55 PST --- (In reply to comment #11) > I think it's not so easy to fix this "cross-archive" member management. The regression was fixed with https://github.com/D-Programming-Language/phobos/pull/1775. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=1832 Martin Nowak <code@dawg.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

January 12, 2014

[Issue 1832] reading/writing an archive causes data loss; std.zip horribly broken

Posted by Martin Krejcirik

Permalink

Martin Krejcirik

Permalink

https://d.puremagic.com/issues/show_bug.cgi?id=1832



--- Comment #13 from Martin Krejcirik <mk@krej.cz> 2014-01-12 21:59:44 CET ---
Was this really fixed ? I still get zero length data (code from comment #0)

mk@bid:~/work/bugs$ unzip -lv ziptest1.zip
Archive:  ziptest1.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
       4  Stored        4   0% 1980-00-00 00:00 9d0d9845  ziptest.bin
--------          -------  ---                            -------
       4                4   0%                            1 file
mk@bid:~/work/bugs$ unzip -lv ziptest2.zip
Archive:  ziptest2.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
       4  Stored        0 100% 1980-00-00 00:00 00000000  ziptest.bin
--------          -------  ---                            -------
       4                0 100%                            1 file

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=1832 Andrej Mitrovic <andrej.mitrovich@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |andrej.mitrovich@gmail.com Resolution|FIXED | --- Comment #14 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2014-02-16 05:56:28 PST --- New pull: https://github.com/D-Programming-Language/phobos/pull/1870 -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=1832 --- Comment #15 from github-bugzilla@puremagic.com 2014-02-16 12:02:03 PST --- Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/1a3f9ab273dd6280cb9b4eda4a0da50d8c89fa88 fix Issue 1832 - rebuilding ZipArchive looses data - Already need to set compressedData slice when reading the directory index not only during expand. https://github.com/D-Programming-Language/phobos/commit/4bdd5f2c6ada5bc0ed37214f0e9d017f50ca8a83 Merge pull request #1870 from MartinNowak/fix1832 fix Issue 1832 - rebuilding ZipArchive looses data -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=1832 Andrej Mitrovic <andrej.mitrovich@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Version|D1 & D2 |D2 Resolution| |FIXED --- Comment #16 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2014-02-16 12:07:26 PST --- Marking as D2 only since Phobos D1 bugs will not be fixed. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

Forums