Thread overview | |||||
---|---|---|---|---|---|
|
July 26, 2014 First round of changes for 64-bit port: base | ||||
---|---|---|---|---|
| ||||
Please take a moment to review my changes for the `base` repository. It compiles in DMD 2.065 Arch Linux 64-bit with either -m32 or -m64. It's my understanding that the Java classes all use `int` for lengths, indexes, etc... so my approach was to simply cast the underlying D `long`s to `int`s so the Java API remains the same. I would like to know if I'm on the right track, so please take a moment to give my changes a peer review. https://github.com/JinShil/base/commits/master Thanks, Mike |
July 26, 2014 Re: First round of changes for 64-bit port: base | ||||
---|---|---|---|---|
| ||||
Posted in reply to Mike | On 2014-07-26 02:59, Mike wrote: > Please take a moment to review my changes for the `base` repository. It > compiles in DMD 2.065 Arch Linux 64-bit with either -m32 or -m64. > > It's my understanding that the Java classes all use `int` for lengths, > indexes, etc... so my approach was to simply cast the underlying D > `long`s to `int`s so the Java API remains the same. > > I would like to know if I'm on the right track, so please take a moment > to give my changes a peer review. > > https://github.com/JinShil/base/commits/master I don't have time right now but I will do a proper review. -- /Jacob Carlborg |
August 11, 2014 Re: First round of changes for 64-bit port: base | ||||
---|---|---|---|---|
| ||||
Posted in reply to Mike | On 2014-07-26 02:59, Mike wrote: > Please take a moment to review my changes for the `base` repository. It > compiles in DMD 2.065 Arch Linux 64-bit with either -m32 or -m64. > > It's my understanding that the Java classes all use `int` for lengths, > indexes, etc... so my approach was to simply cast the underlying D > `long`s to `int`s so the Java API remains the same. > > I would like to know if I'm on the right track, so please take a moment > to give my changes a peer review. > > https://github.com/JinShil/base/commits/master Sorry for taking so long. I made a quick review and added some comments. Except for these, it looks pretty good. Please use "rebase", I don't want any merge commits. -- /Jacob Carlborg |
Copyright © 1999-2021 by the D Language Foundation