Time to button this up and release it. Remaining regressions:

https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

On 31/01/2015 11:05 a.m., Walter Bright wrote:
> Time to button this up and release it. Remaining regressions:
>
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

Can I please have another review of my PR?

https://github.com/D-Programming-Language/dmd/pull/3921

On Friday, 30 January 2015 at 22:06:34 UTC, Walter Bright wrote:
> Time to button this up and release it. Remaining regressions:
>
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

How about this one: https://issues.dlang.org/show_bug.cgi?id=7762

Not sure if its supposed to compile, but it was reported master wouldn't.

-Andy

On 1/30/2015 2:24 PM, AndyC wrote:
> On Friday, 30 January 2015 at 22:06:34 UTC, Walter Bright wrote:
>> Time to button this up and release it. Remaining regressions:
>>
>> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced
>>
>
> How about this one: https://issues.dlang.org/show_bug.cgi?id=7762
>
> Not sure if its supposed to compile, but it was reported master wouldn't.

It's resolves as "worksforme". If someone reports that it is still causing problems, it should be reopened.

On Fri, Jan 30, 2015 at 02:05:52PM -0800, Walter Bright via Digitalmars-d wrote:
> Time to button this up and release it. Remaining regressions:
> 
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

Have we reached a final decision about what exactly groupBy should return? (Or whether it should even be called 'groupBy'?) Last I heard, there wasn't a firm decision. We should not release with an undecided-on API, because that will make it much harder to change later (we will need to go through a full deprecation cycle, and possibly waste the name 'groupBy'). If we can't decide before release, we might have to revert groupBy for the time being.

There's also the [$] issue: are we keeping it or dumping it?

There may be one or two other issues that we need to iron out before release, but they just slipped my mind now.


T

-- 
Shin: (n.) A device for finding furniture in the dark.

On 1/30/15 2:35 PM, H. S. Teoh via Digitalmars-d wrote:
> On Fri, Jan 30, 2015 at 02:05:52PM -0800, Walter Bright via Digitalmars-d wrote:
>> Time to button this up and release it. Remaining regressions:
>>
>> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced
>
> Have we reached a final decision about what exactly groupBy should
> return? (Or whether it should even be called 'groupBy'?) Last I heard,
> there wasn't a firm decision. We should not release with an undecided-on
> API, because that will make it much harder to change later (we will need
> to go through a full deprecation cycle, and possibly waste the name
> 'groupBy'). If we can't decide before release, we might have to revert
> groupBy for the time being.

Sorry, I thought that was in the bag. Keep current semantics, call it chunkBy. Add the key to each group when the predicate is binary. Make sure aggregate() works nice with chunkBy().

Stuff that can wait: grouping and aggregation for SortedRange.

> There's also the [$] issue: are we keeping it or dumping it?

I think we can at least delay it until (a) the partial deduction is clearly defined, and (b) we figure whether a library solution is enough. I need more signal from our brass please.


Andrei

On 1/30/15 3:17 PM, Andrei Alexandrescu wrote:
> Add the key to each group when the predicate is binary.

s/binary/unary/

On Friday, 30 January 2015 at 22:06:34 UTC, Walter Bright wrote:
> Time to button this up and release it. Remaining regressions:
>
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

The recent website overhaul broke a few documentation-related things.

CHM generation is currently broken. Fix:
https://github.com/D-Programming-Language/dlang.org/pull/873

I don't know how the .html files that are included in dmd.zip are generated. Please try and see if it works for you. If not, I can look into it if you open-source your process.

There is also the issue that links to e.g. std_algorithm.html will be broken, because that module no longer exists. Currently, the Makefiles generate std_algorithm_package.html, which will likely cause old links to point to stale versions of the std.algorithm (the module)'s documentation. I think std.algorithm.package documentation should be written to std_algorithm.html, or some sort of redirect be set up.

On Friday, 30 January 2015 at 22:06:34 UTC, Walter Bright wrote:
> Time to button this up and release it. Remaining regressions:
>
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced

Please let's finish the GC work for 2.067, will take about 1-1.5 week.

On 1/30/15 6:39 PM, Martin Nowak wrote:
> On Friday, 30 January 2015 at 22:06:34 UTC, Walter Bright wrote:
>> Time to button this up and release it. Remaining regressions:
>>
>> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=192294&query_format=advanced
>>
>
> Please let's finish the GC work for 2.067, will take about 1-1.5 week.

Can we commit to having stuff done by Feb 15 for a release on Mar 1? -- Andrei