[Issue 15925] [REG 2.071] Import declaration from mixin templates are ignored (page 2)

https://issues.dlang.org/show_bug.cgi?id=15925 --- Comment #7 from Dicebot <public@dicebot.lv> --- What about public imports? Previously you have stated that mixins should be viewed identical to imports when it comes to symbol visibility/access but that would be not true if public ones are not propagated. --

https://issues.dlang.org/show_bug.cgi?id=15925 Martin Nowak <code@dawg.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@dawg.eu --- Comment #8 from Martin Nowak <code@dawg.eu> --- Weird, need to work on this. With 2.071.0 -transition=import works as expected (but -transition=checkimports doesn't report an error). With the latest nightly dmd-2016-05-26 it will accept the code w/o -transition=import b/c we haven't yet merged back the revert. With the latest stable 64f3fdb27 it will fail even with -transition=import. --

https://issues.dlang.org/show_bug.cgi?id=15925 --- Comment #10 from github-bugzilla@puremagic.com --- Commits pushed to stable at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/b86f3b3b357f6d0edc0c8a60552657b922443017 fix Issue 15925 - Import declaration from mixin templates are ignored - make the lookup in imported mixin scopes compatible with -transition=import/checkimports https://github.com/dlang/dmd/commit/ba178e607c33e121142ec15c5064d953fd87a191 Merge pull request #5810 from MartinNowak/fix15925 fix Issue 15925 - Import declaration from mixin templates are ignored --

https://issues.dlang.org/show_bug.cgi?id=15925 github-bugzilla@puremagic.com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --

https://issues.dlang.org/show_bug.cgi?id=15925 --- Comment #11 from github-bugzilla@puremagic.com --- Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/f0f38381ed27fd8a4d2e36d13623698970cff7bd Revert "[REG 2.071] Fix Issue 15925 - Import declaration from mixin templates are ignored" https://github.com/dlang/dmd/commit/64f3fdb27b6d9d465c307b45c26a6c9fe10844b8 Merge pull request #5800 from dlang/revert-5724-fix-15925-stable https://github.com/dlang/dmd/commit/b86f3b3b357f6d0edc0c8a60552657b922443017 fix Issue 15925 - Import declaration from mixin templates are ignored https://github.com/dlang/dmd/commit/ba178e607c33e121142ec15c5064d953fd87a191 Merge pull request #5810 from MartinNowak/fix15925 --

https://issues.dlang.org/show_bug.cgi?id=15925 Mathias Lang <mathias.lang@sociomantic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[REG 2.071] Import |-transition=[check]imports |declaration from mixin |ignores import declaration |templates are ignored |from mixin templates --- Comment #12 from Mathias Lang <mathias.lang@sociomantic.com> --- Renaming for reasons explained here: https://forum.dlang.org/post/nl2bgi$2oim$1@digitalmars.com dlang.org P.R: https://github.com/dlang/dlang.org/pull/1404 --

https://issues.dlang.org/show_bug.cgi?id=15925 --- Comment #13 from github-bugzilla@puremagic.com --- Commits pushed to master at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/6073f90f92b273010e459914c371ed1cb75fda86 Fix issue 15925 name in changelog The issue was repurposed and the name was confusing to readers: https://forum.dlang.org/post/nl2bgi$2oim$1@digitalmars.com https://github.com/dlang/dlang.org/commit/1b6c20f3d482e0d541d4da3375fb25648666515f Merge pull request #1404 from Geod24/15925 Fix issue 15925 name in changelog --

July 05, 2016

[Issue 15925] -transition=[check]imports ignores import declaration from mixin templates

Posted by Steven Schveighoffer

Permalink

Steven Schveighoffer

Permalink

https://issues.dlang.org/show_bug.cgi?id=15925

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schveiguy@yahoo.com

--- Comment #14 from Steven Schveighoffer <schveiguy@yahoo.com> ---
The original bug report here, I think has some merit.

If you need to add imports to a class/struct/function in order to allow for your declaration to make sense, then I don't see a reason why it should be disallowed.

For instance, the original example imports core.thread, and then declares th of type Thread. You can use members of th inside Foo, but not declare another 'Thread'. You also could not use any UFCS functions defined in core.thread (if there are any). This leaves you with a half-working type. As far as I know, there's no workaround.

(In reply to Walter Bright from comment #5)
> This is not a bug, the behavior is on purpose and as designed. This was discussed at length for an analogous case, imports in base classes.

Where is the discussion? I want to add the explanation for this to the blog post I wrote on the import differences in 2.071, but I can't find any.

--

Forums