[Issue 11946] need 'this' to access member when passing field to template parameter (page 2)

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #49 from Vladimir Panteleev <thecybershadow@gmail.com> --- May I ask why you're removing quote characters from issue titles? IMHO they are easier to read when the error message is quoted and thus distinguishable from the rest of the title. --

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #50 from Walter Bright <bugzilla@digitalmars.com> --- (In reply to Vladimir Panteleev from comment #49) > May I ask why you're removing quote characters from issue titles? IMHO they are easier to read when the error message is quoted and thus distinguishable from the rest of the title. I remove them because when I do a git checkout -a -m "message" I do a cut&paste from the bugzilla issue for the message. The " mess it all up. Yes, I could re-edit the git command line, but when the line wraps because it's too long, which it usually does, and then the command line editor for putty fouls everything up. It just makes things marginally easier for me to not have to deal with the ". --

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #51 from Jacob Carlborg <doob@me.com> --- (In reply to Walter Bright from comment #50) > I remove them because when I do a > > git checkout -a -m "message" > > I do a cut&paste from the bugzilla issue for the message. The " mess it all up. Yes, I could re-edit the git command line, but when the line wraps because it's too long, which it usually does, and then the command line editor for putty fouls everything up. > > It just makes things marginally easier for me to not have to deal with the ". If you check the message first you can use ' instead of ". BTW, I never use the -m flag and always write the commit message in my text editor. Then I get spell checking, indication if a line is too long and so on for free. --

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #52 from Vladimir Panteleev <thecybershadow@gmail.com> --- Well, do you really think that saving a few seconds is worth the potential confusion? Let's look at the title now: > need 'this' to access member when passing field to template parameter (Consider that the reader is not familiar with this error message.) Who is the entity needing "this", the compiler or the programmer? Where does the error message end? Is it just "need 'this'"? "need 'this' to access member"? Or is the entire line coming from the compiler? What should I give to "grep" when searching the DMD source code? Besides, how many times are you going to type that command line? What takes longer, editing the issue title, or editing the commit message on the command line (or a text editor, as Jacob suggested)? --

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #54 from github-bugzilla@puremagic.com --- Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/8c73839f6f1b2b3073d2189c8fd73309cf4ada28 fix Issue 11946 - need 'this' to access member when passing field to template parameter https://github.com/D-Programming-Language/dmd/commit/f32b97cfca5da1c00f47ac3941b19ef4d5c73c44 Merge pull request #3884 from WalterBright/fix11946 [reg] fix Issue 11946 - need 'this' to access member when passing field to template parameter --

August 29, 2014

[Issue 11946] need 'this' to access member when passing field to template parameter

Posted by yebblies

Permalink

yebblies

Permalink

https://issues.dlang.org/show_bug.cgi?id=11946

yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yebblies@gmail.com

--- Comment #53 from yebblies <yebblies@gmail.com> ---
(In reply to Walter Bright from comment #50)
> (In reply to Vladimir Panteleev from comment #49)
> > May I ask why you're removing quote characters from issue titles? IMHO they are easier to read when the error message is quoted and thus distinguishable from the rest of the title.
> 
> I remove them because when I do a
> 
>    git checkout -a -m "message"
> 
> I do a cut&paste from the bugzilla issue for the message. The " mess it all up. Yes, I could re-edit the git command line, but when the line wraps because it's too long, which it usually does, and then the command line editor for putty fouls everything up.
> 
> It just makes things marginally easier for me to not have to deal with the ".

This is classic!

--

https://issues.dlang.org/show_bug.cgi?id=11946 --- Comment #55 from github-bugzilla@puremagic.com --- Commit pushed to 2.066 at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/8b7a3cbb783e44fcd55ca019d8a266dafa97ddcb Merge pull request #3884 from WalterBright/fix11946 [reg] fix Issue 11946 - need 'this' to access member when passing field to template parameter --

Forums