Thread overview
[Issue 15504] core.demangle uses exception handling for normal control flow
Jun 26, 2017
Vladimir Panteleev
Dec 17, 2022
Iain Buclaw
Jul 10
RazvanN
June 26, 2017
https://issues.dlang.org/show_bug.cgi?id=15504

Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dlang-bugzilla@thecybershad
                   |                            |ow.net

--- Comment #1 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> ---
(In reply to Walter Bright from comment #0)
> https://github.com/D-Programming-Language/druntime/blob/master/src/core/ demangle.d

Permalink to that day's version: https://github.com/dlang/druntime/blob/43a7e6830980cd242c1fbae145cffdf7be397069/src/core/demangle.d

To find the offending code, search for catch(...) blocks.

Permalink to today's version, which still has the problematic code: https://github.com/dlang/druntime/blob/68ba136a3ce7ff9c66580b2efd659a27aa035dd8/src/core/demangle.d

--
October 09, 2017
https://issues.dlang.org/show_bug.cgi?id=15504

alex.jercaianu@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.jercaianu@gmail.com
           Assignee|nobody@puremagic.com        |alex.jercaianu@gmail.com

--
November 16, 2020
https://issues.dlang.org/show_bug.cgi?id=15504

feklushkin.denis@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |feklushkin.denis@gmail.com

--- Comment #2 from feklushkin.denis@gmail.com ---
Also demangle consumes megabytes of memory for each unsucessful demangle. This causes demangling unittests fails on low-memory system.

Little related discussion here: https://github.com/dlang/druntime/pull/3262

--
December 17, 2022
https://issues.dlang.org/show_bug.cgi?id=15504

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4

--
July 10
https://issues.dlang.org/show_bug.cgi?id=15504

RazvanN <razvan.nitu1305@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |razvan.nitu1305@gmail.com

--- Comment #3 from RazvanN <razvan.nitu1305@gmail.com> ---
Some progress in this regard: https://github.com/ljmf00/demangler/tree/basic-implementation

--
January 30
https://issues.dlang.org/show_bug.cgi?id=15504

--- Comment #4 from feklushkin.denis@gmail.com ---
Straightforward attempt to fix: https://github.com/dlang/dmd/pull/16114

--
January 31
https://issues.dlang.org/show_bug.cgi?id=15504

feklushkin.denis@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from feklushkin.denis@gmail.com ---
Fixed by https://github.com/dlang/dmd/pull/16114

--