May 11, 2017 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 uplink.coder@googlemail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |uplink.coder@googlemail.com --- Comment #9 from uplink.coder@googlemail.com --- The way I see forward is to not use a number. But to disambiguate by a reproducible hash. -- |
June 14, 2017 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 --- Comment #10 from Martin Nowak <code@dawg.eu> --- (In reply to uplink.coder from comment #9) > The way I see forward is to not use a number. > But to disambiguate by a reproducible hash. Yes! What to hash though? Source code, tokens, parsed AST? Guess the latter would remain identical even after reformatting which is a nice property (but not an important one). -- |
June 14, 2017 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 --- Comment #11 from uplink.coder@googlemail.com --- (In reply to Martin Nowak from comment #10) > (In reply to uplink.coder from comment #9) > > The way I see forward is to not use a number. > > But to disambiguate by a reproducible hash. > > Yes! What to hash though? Source code, tokens, parsed AST? Guess the latter would remain identical even after reformatting which is a nice property (but not an important one). We need AST-Node hashing anyhow. but that won't fix the .di files problem, as the hash will be different from the impl.... or does the source have to be available ? If it does then we stand a chance. This will also auto-magically de-duplicate lambdas with the same bodys. -- |
October 20, 2017 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 --- Comment #12 from Martin Nowak <code@dawg.eu> --- (In reply to uplink.coder from comment #11) > We need AST-Node hashing anyhow. > but that won't fix the .di files problem, as the hash will be different from > the impl.... or does the source have to be available ? Yes, source code for lambdas and mixins should be available in situations where we use such numbers, so either of them could be hashed. Literal source code is only available during parsing, so hashes would need to be computed eagerly during the performance sensitive lexing. A hash on the AST could be computed lazily. We already have `expressionHash` in dmd, but that depends on allocation addresses. -- |
October 26, 2017 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 Walter Bright <bugzilla@digitalmars.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |mangling -- |
August 22, 2018 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 Mike Franklin <slavo5150@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://issues.dlang.org/sh | |ow_bug.cgi?id=19058 -- |
December 17, 2022 [Issue 14894] mangling of mixins and lambdas is not unique and depends on compilation flags | ||||
---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=14894 Iain Buclaw <ibuclaw@gdcproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 |P2 -- |
Copyright © 1999-2021 by the D Language Foundation