June 03, 2015
https://issues.dlang.org/show_bug.cgi?id=14578

--- Comment #11 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Steven Schveighoffer from comment #10)
> I finally reproduced with 2.067 and 2.067.1, it's definitely Linux specific. However, this is fixed in the HEAD version (at least using your reduced test case). Can you confirm whether this bug is fixed in HEAD for you, Iain?

Did you test the reduced test with:

x * 512 times
x * 1023 times

Just making sure. :)

--
June 04, 2015
https://issues.dlang.org/show_bug.cgi?id=14578

--- Comment #12 from Steven Schveighoffer <schveiguy@yahoo.com> ---
I created 3 test cases, one based on your recommendation, one based on Ali's in issue 14005, and one based on the post in http://forum.dlang.org/post/yfuxvdxduicfjtdoxbyb@forum.dlang.org. In all three cases, they were passing on my Mac. However, running on my Linux VM, they all failed (Frustratingly, nobody attached any exact files, so I wasn't sure if my hand-made files were correctly set up to trigger the bug when I tested on the Mac).

Then I cloned and built everything from HEAD in git. All of them passed.

Does this mean the problem is fixed? For byLine, I think it is. However, I think readln is still buggy. issue 13856 should remain open until that is fixed, but I think we can close this one.

Note, the use of assumeSafeAppend in readln is/was incorrect, it's ignoring the metadata of the block, and blindly assuming it can consume all the data in the block as returned by the GC. So the issue is not with assumeSafeAppend I think.

--
June 15, 2015
https://issues.dlang.org/show_bug.cgi?id=14578

--- Comment #13 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Steven Schveighoffer from comment #12)
> I created 3 test cases, one based on your recommendation, one based on Ali's in issue 14005, and one based on the post in http://forum.dlang.org/post/yfuxvdxduicfjtdoxbyb@forum.dlang.org. In all three cases, they were passing on my Mac. However, running on my Linux VM, they all failed (Frustratingly, nobody attached any exact files, so I wasn't sure if my hand-made files were correctly set up to trigger the bug when I tested on the Mac).
> 
> Then I cloned and built everything from HEAD in git. All of them passed.
> 
> Does this mean the problem is fixed? For byLine, I think it is. However, I think readln is still buggy. issue 13856 should remain open until that is fixed, but I think we can close this one.
> 
> Note, the use of assumeSafeAppend in readln is/was incorrect, it's ignoring the metadata of the block, and blindly assuming it can consume all the data in the block as returned by the GC. So the issue is not with assumeSafeAppend I think.

OK.  I still haven't had the time to test, but if you build ddemangle using phobos/HEAD and run it on attachment 1522.  If all symbols are correctly demangled with no SEGV then this can be closed.

--
June 15, 2015
https://issues.dlang.org/show_bug.cgi?id=14578

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Yes, it works with no SEGV, tested on Linux 64-bit. Confirmed that standard build of ddemangle crashes.

--
1 2
Next ›   Last »