https://issues.dlang.org/show_bug.cgi?id=16085

--- Comment #10 from Walter Bright <bugzilla@digitalmars.com> ---
(In reply to Martin Nowak from comment #9)
> (In reply to Walter Bright from comment #8)
> > > The member "reallocate" should effectively hide the private import, yet the deprecation message still appears.
> > 
> > The private import is hidden. The alias is not.
> 
> Don't quite get that comment. Imports are private by default, so are the selectively imported symbol aliases.

     import whatever : reallocate; // <- private

This is the equivalent of:

      alias reallocate = whatever.reallocate;

I.e. an actual alias is generated. The alias is not hidden. The import is.


> Already figured out what's wrong with the overload implementation in symbolIsVisible, just need to find time to fix it.

Please don't fix until we agree on what the result should be.

--

https://issues.dlang.org/show_bug.cgi?id=16085

--- Comment #11 from Martin Nowak <code@dawg.eu> ---
(In reply to Walter Bright from comment #10)
> This is the equivalent of:
> 
>       alias reallocate = whatever.reallocate;
> 
> I.e. an actual alias is generated. The alias is not hidden. The import is.

It's a private alias b/c that's the protection of the import (implicitly).

    private import whatever : reallocate;

equivalent to:

    private alias reallocate = whatever.reallocate;

The bug that overloading this with a public alias causes an error should be reproducible for both cases.

--

https://issues.dlang.org/show_bug.cgi?id=16085

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #12 from Martin Nowak <code@dawg.eu> ---
https://github.com/dlang/dmd/pull/5847

--

https://issues.dlang.org/show_bug.cgi?id=16085

--- Comment #13 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/22dc48171eaa3ef43dbec3e6bab6ea7fcb839a37 fix Issue 16085 - wrong visibility warning for overloaded alias symbol

- mark OverDeclaration as overloadable
- mark AliasDeclaration as overloadable (depends on aliasee)
- replace overloadApply with a custom iteration b/c aliases
  must not be resolved for visibility checks (i.e. public aliases to
  private symbols are public)
- deal with the messy overloading of aliasees (see comments)

https://github.com/dlang/dmd/commit/8238ad782347330e0a822208c323a83d1d17ac64 Merge pull request #5847 from MartinNowak/fix16085

fix Issue 16085 - wrong visibility warning for overloaded alias symbol

--

https://issues.dlang.org/show_bug.cgi?id=16085

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--

https://issues.dlang.org/show_bug.cgi?id=16085

--- Comment #14 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/22dc48171eaa3ef43dbec3e6bab6ea7fcb839a37 fix Issue 16085 - wrong visibility warning for overloaded alias symbol

https://github.com/dlang/dmd/commit/8238ad782347330e0a822208c323a83d1d17ac64 Merge pull request #5847 from MartinNowak/fix16085

--

https://issues.dlang.org/show_bug.cgi?id=16085

--- Comment #15 from github-bugzilla@puremagic.com ---
Commits pushed to newCTFE at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/22dc48171eaa3ef43dbec3e6bab6ea7fcb839a37 fix Issue 16085 - wrong visibility warning for overloaded alias symbol

https://github.com/dlang/dmd/commit/8238ad782347330e0a822208c323a83d1d17ac64 Merge pull request #5847 from MartinNowak/fix16085

--