On 09.01.2016 11:35, Jacob Carlborg wrote:
> I'm not sure that I like that some of the headers (learn, packages) are
> clickable on the main page. This also causes some icons to be black
> (gray?) and some to be red. How about a link at the end of the section
> with the title "Read more", or similar?

Agreed. I unlinked Learn and Packages. The links were duplicated in the text already anyway.

On Sunday, 10 January 2016 at 14:04:44 UTC, anonymous wrote:
> Example: http://d-ag0aep6g.rhcloud.com/phobos-prerelease/std_algorithm_searching.html#.commonPrefix

Can I ask not to use dotted frames? It may be my eyes, but I get dizzy reading the tables.
Maybe format tables like the cheat sheet at the top of the page, which I think looks beautiful.

Thanks!

On 1/10/16 9:05 AM, anonymous wrote:
> On 09.01.2016 22:43, Andrei Alexandrescu wrote:
>> On 1/8/16 5:32 PM, anonymous wrote:
> [...]
>>> 5) Justified Text
> [...]
>> Justified font only looks good in conjunction with hyphenation. I'd say
>> make text justified on browsers that support css hyphenation (all but
>> Chrome I recall?) and left align on the others.
>
> I.e., revert the change. Done.
>
> By the way, in Ubuntu I don't see any hyphenation in Firefox. It works
> in Windows, though.

Probably we need to fix that, but it's a preexisting matter so don't worry about it. Do you have a PR in place yet? Thx! -- Andrei

On 10.01.2016 15:27, Bastiaan Veelo wrote:
> Can I ask not to use dotted frames?

I agree that they're ugly, but they've been ugly before the redesign, too. Let's do such stuff in separate pull requests.

On 08.01.2016 23:32, anonymous wrote:
> My implementation of the redesign is pretty much complete.
>
> Check it out: http://d-ag0aep6g.rhcloud.com/

No blocking issues in sight so far. Time to make a pull request:

https://github.com/D-Programming-Language/dlang.org/pull/1187

On 10.01.2016 16:11, Andrei Alexandrescu wrote:
> Do you have a PR in place yet?

Here we go:
https://github.com/D-Programming-Language/dlang.org/pull/1187

On Friday, 8 January 2016 at 22:32:59 UTC, anonymous wrote:
> My implementation of the redesign is pretty much complete.
>
> Check it out: http://d-ag0aep6g.rhcloud.com/
>
> This is an implementation of a design done by one Ivan Smirnov, brought forward by Jacob Carlborg [1].
>
> The dark forum widgets on the home page are in iframes. Their styling will need to be updated at the source, which is forum.dlang.org.
>
> Another external dependency is the This Week in D script. Adam, it would be nice if the `setTwid` function could take the date separately. That would allow me to word the text without having "This Week in D" there twice.
>
> Other than those two little things I consider this done. From my side it could be merged immediately.
>
> But I'm sure there are a thousand things wrong with this. Here are some topics to get you started:
>
> 1) Legalities
>
> I mentioned this before, but noone reacted. Can we use Ivan's work? Do we have his ok? Do we need it? Jacob mentioned that he can't in contact with him anymore. Is that a problem?
>
> 2) Reviewing the code
>
> https://github.com/aG0aep6G/dlang.org/commits/Ivan-Smirnov's-redesign
>
> This is just one giant commit (the others are independent minor fixes). GitHub refuses to show the diff for the style.css file, because it's too big. Is this acceptable, or do I need to split it up somehow? If I need to split it up, any advice on how to do that?
>
> 3) New Pages
>
> Aside from the overall style changes and menu reorganization, I also added overview pages for the articles and for the tools:
>
> http://d-ag0aep6g.rhcloud.com/articles.html
> http://d-ag0aep6g.rhcloud.com/tools.html
>
> They feature new text that should be proofread.
>
> 4) Fonts
>
> Vladimir Panteleev has spoken out against web fonts [2]. His argument is that they can look fine on one system but bad on another. Indeed the recently changed code font on dlang.org looks pretty bad for me while the default 'monospace' looks just fine, which is why I reverted that in the redesign.
>
> The redesign uses a web font for its main font, though: Roboto Slab. It looks good for me, but I'm not able to test it on a large variety of device/OS/browser combinations. Maybe it's fine, or maybe we should stay away from web fonts categorically. I don't really have an opinion on this.
>
> 5) Justified Text
>
> Andrei loves it, everybody else hates it. I killed it as the mockup didn't have it. Is that ok, or is justified text a must?
>
> 6) Red For Clickables Only?
>
> Currently, the site uses red almost exclusively for clickable stuff. But it's also used as a highlight color for non-clickable things. For example in phobos signatures:
>
> http://d-ag0aep6g.rhcloud.com/phobos/object.html#.Object
>
> The left borders of the signature boxes are red, and the documented symbol is highlighted with red.
>
> Red does not signal clickability here. I don't like that and I'd prefer to go with another color for generic highlighting, reserving red for clickable stuff.
>
> 7) The Logo
>
> As requested by Andrei, this does not feature a logo change for now. I'm going to make a pull request for the slicker logo variant [3] when this is through.
>
>
> [1] http://forum.dlang.org/post/n53ps0$2j8f$1@digitalmars.com
> [2] http://forum.dlang.org/post/xezfeilxblfkibldvsgg@forum.dlang.org
> [3] https://gist.github.com/aG0aep6G/0803ec5ae49f6afb0196

Again, thanks for doing this. The new design overall looks much more modern and approachable.

Some feedback I do have:

Fonts
-------
I do not have any problem with Web Fonts. In particular the web fonts created by Google are highly tested and render pretty similarly on many device/browser combinations. This is from practical experience.

On the font used, Roboto Slab: I feel that the serif nature of the font makes it clash with the clean design. A sans serif font would look much better.

Justified Text
----------------
I'm with Andrei on this one. Justified text is preferable to aligned text for large paragraphs which span the reading width of the page. It always makes it easier to read. For mini-paragraphs, sometimes left aligned does look better.

"Your Code Here" widget
-----------------------------
The widget that displays and allows you to run code in the browser has been a staple of the D website for a long time now. It's a great feature. There is one issue here: When the code length is large, it takes half the screen before any actual content begins. The grayed out header colour looks funny.

I suggest displaying the first 7-9 lines of code in the box and either making the box scrollable, or making it so that clicking on the box expands it to show the entire code.

The "Sort lines" example is about the right size. The "Round floating point numbers" is a bit large.

PS: Sorry if there were opportunities to give feedback on this earlier and somehow I missed it. I do hope you consider this even it if comes a bit late.

Thanks,
Saurabh

On Sunday, 10 January 2016 at 17:02:59 UTC, Saurabh Das wrote:
> [...]
> The grayed out header colour looks funny.

I meant it looks funny when it spans half the height of the page when the example code is long. It looks fine otherwise :)

On 1/10/16 10:23 AM, anonymous wrote:
> On 10.01.2016 16:11, Andrei Alexandrescu wrote:
>> Do you have a PR in place yet?
>
> Here we go:
> https://github.com/D-Programming-Language/dlang.org/pull/1187

...aaaaaand we're live. Congratulations and many thanks to the folks who worked on this! -- Andrei

On Friday, 8 January 2016 at 22:32:59 UTC, anonymous wrote:
> My implementation of the redesign is pretty much complete.
>
> Check it out: http://d-ag0aep6g.rhcloud.com/

Congratulations on getting this merged!