On Wednesday, 17 January 2024 at 10:43:22 UTC, Renato wrote:

java -cp "build/util" util.GeneratePhoneNumbers 1000 > phones_1000.txt

java -DFile.Encoding=UTF-8 ...

I've used powershell env var to set output to utf8, D version now works but java doesn't.

java -Xms20M -Xmx100M -cp build/java Main print words-quarter.txt phones_1000.txt
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 65485 out of bounds for length 10
        at Trie.completeSolution(Main.java:216)
        at Trie.forEachSolution(Main.java:192)
        at PhoneNumberEncoder.encode(Main.java:132)
        at Main.lambda$main$1(Main.java:38)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
        at Main.main(Main.java:38)

On Wednesday, 17 January 2024 at 10:50:26 UTC, evilrat wrote:

java -cp "build/util" util.GeneratePhoneNumbers 1000 > phones_1000.txt

java -DFile.Encoding=UTF-8 ...

java -Xms20M -Xmx100M -cp build/java Main print words-quarter.txt phones_1000.txt
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 65485 out of bounds for length 10
        at Trie.completeSolution(Main.java:216)
        at Trie.forEachSolution(Main.java:192)
        at PhoneNumberEncoder.encode(Main.java:132)
        at Main.lambda$main$1(Main.java:38)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
        at Main.main(Main.java:38)

This is this line:

var digit = chars[ index ] - 48;

That means the input file is still not ASCII (or UTF-8) as it should. Java is reading files with the ASCII encoding so it should've worked fine.

On Wednesday, 17 January 2024 at 11:20:14 UTC, Renato wrote:

It seems that it is only works with ASCII encoding though.

On Wednesday, 17 January 2024 at 11:56:19 UTC, evilrat wrote:

Yes, that's according to the rules - only ASCII for everything.

On Wednesday, 17 January 2024 at 16:30:08 UTC, H. S. Teoh wrote:

I've just updated the Rust version to the benchmark monitor could work on Linux (it only worked on Mac before) :D that's probably why your rustc didn't work, though as the project is still using edition2018 I would've thought even a very old compiler would have worked... anyway, if you ever find yourself actually using Rust, you should use rustup (https://rustup.rs/) which makes it trivial to update Rust.

About the "count" option: I had assumed you didn't call format on the count option as it's never needed, there's nothing to print.

On Wednesday, 17 January 2024 at 16:54:00 UTC, H. S. Teoh wrote:

Ok, last time I'm running this for someone else :D

Proc,Run,Memory(bytes),Time(ms)
===> ./rust
./rust,23920640,30
./rust,24018944,147
./rust,24068096,592
./rust,24150016,1187
./rust,7766016,4972
./rust,8011776,46101
===> src/d/dencoder
src/d/dencoder,44154880,42
src/d/dencoder,51347456,87
src/d/dencoder,51380224,273
src/d/dencoder,51462144,441
src/d/dencoder,18644992,4414
src/d/dencoder,18710528,43548

Congratulations on beating Rust :D but remember: you're using a much more efficient algorithm! I must conclude that the Rust translation of the Trie algorithm would be much faster still, unfortunately (you may have noticed that I am on D's side here!).

On Wednesday, 17 January 2024 at 16:54:00 UTC, H. S. Teoh wrote:

BTW here's you main function so it can run on the benchmark:

int main(string[] args)
{
    bool countOnly = args.length > 1 ? (() {
        final switch (args[1])
        {
        case "count":
            return true;
        case "print":
            return false;
        }
    })() : false;

    auto dictfile = args.length > 2 ? args[2] : "tests/words.txt";
    auto input = args.length > 3 ? args[3] : "tests/numbers.txt";

    Trie dict = loadDictionary(File(dictfile).byLine);

    if (countOnly)
    {
        size_t count;
        encodePhoneNumbers(File(input).byLine, dict, (phone, match) { count++; });
        writefln("%d", count);
    }
    else
    {
        encodePhoneNumbers(File(input).byLine, dict, (phone, match) {
            writefln("%s: %s", phone, match);
        });
    }

    return 0;
}