Jump to page: 1 2
Thread overview
Pull 1019
Jan 18, 2013
Namespace
Jan 18, 2013
Jacob Carlborg
Jan 18, 2013
monarch_dodra
Jan 18, 2013
Namespace
Jan 18, 2013
monarch_dodra
Jan 18, 2013
Namespace
Jan 19, 2013
Namespace
Jan 19, 2013
Namespace
Jan 18, 2013
Brad Roberts
Jan 22, 2013
Namespace
Jan 22, 2013
mist
Jan 22, 2013
Namespace
Jan 23, 2013
Namespace
Jan 24, 2013
mist
Jan 24, 2013
Namespace
Jan 24, 2013
Namespace
Jan 24, 2013
monarch_dodra
Jan 24, 2013
Namespace
January 18, 2013
Despite the danger that this annoy you probably:
What about pull 1019 (https://github.com/D-Programming-Language/dmd/pull/1019)? I'm still quite new with Git so I do not know exactly what "1 Fail, 9 Pending" means (and why it stands there so long) and how current the merge determination is.
But I'd like to know if someone has a prediction about when this rather important pull is, or can be merged.
One reason for asking you about this is because my framework, Dgame, already uses this pull successfully. But forcing each potential user to merge this experimental pull by themselves can be a quite annoying.
On the other side stands that the correction from structs being now rvalues has caused a significant gap in programming with them and one might wonder when that will be fixed.
January 18, 2013
On 2013-01-18 14:07, Namespace wrote:
> Despite the danger that this annoy you probably:
> What about pull 1019
> (https://github.com/D-Programming-Language/dmd/pull/1019)? I'm still
> quite new with Git so I do not know exactly what "1 Fail, 9 Pending"
> means (and why it stands there so long)

It means that the test suite failed. You can click "Details" to get more details about what failed.

-- 
/Jacob Carlborg
January 18, 2013
On Friday, 18 January 2013 at 13:13:03 UTC, Jacob Carlborg wrote:
> On 2013-01-18 14:07, Namespace wrote:
>> Despite the danger that this annoy you probably:
>> What about pull 1019
>> (https://github.com/D-Programming-Language/dmd/pull/1019)? I'm still
>> quite new with Git so I do not know exactly what "1 Fail, 9 Pending"
>> means (and why it stands there so long)
>
> It means that the test suite failed. You can click "Details" to get more details about what failed.

Simply that your pull was tested on 1 machine (which failed), and was not yet tested on the rest of the machines.

Since the current failure is due to a merge error, I think your pull gets pushed to the back of the list, and as such, probably doesn't get tested by the rest of the machines.

You can see the linux 32 machine tests your code every couple of hours.

you just need to rebase.
January 18, 2013
Ok, thanks.
But nobody can tell me when and if the "pull" is merged, right?
I think many users here would be pleased if someone could say something to this pull.
January 18, 2013
On Friday, 18 January 2013 at 18:35:47 UTC, Namespace wrote:
> Ok, thanks.
> But nobody can tell me when and if the "pull" is merged, right?
> I think many users here would be pleased if someone could say something to this pull.

Not sure what you mean?

Nobody will tell you when your pull fails the unittests.

When your pull actually gets merged for real into the "head", you aren't notified either (sadly), but the puller usually leaves a "merged" comment, and you get *that* notification.
January 18, 2013
> Not sure what you mean?
>
> Nobody will tell you when your pull fails the unittests.
>
> When your pull actually gets merged for real into the "head", you aren't notified either (sadly), but the puller usually leaves a "merged" comment, and you get *that* notification.

It isn't my pull but I want to know if this pull is merged in the near future because it fix the "auto ref" problem and that is a very big issue.
Also I want to know if someone is working on the pull currently.
January 18, 2013
On Fri, 18 Jan 2013, monarch_dodra wrote:

> On Friday, 18 January 2013 at 18:35:47 UTC, Namespace wrote:
> > Ok, thanks.
> > But nobody can tell me when and if the "pull" is merged, right?
> > I think many users here would be pleased if someone could say something to
> > this pull.
> 
> Not sure what you mean?
> 
> Nobody will tell you when your pull fails the unittests.
> 
> When your pull actually gets merged for real into the "head", you aren't notified either (sadly), but the puller usually leaves a "merged" comment, and you get *that* notification.

Actually, github _does_ send a notification when the pull is merged.  They added that some time ago.
January 19, 2013
On Friday, 18 January 2013 at 20:56:43 UTC, Namespace wrote:
>> Not sure what you mean?
>>
>> Nobody will tell you when your pull fails the unittests.
>>
>> When your pull actually gets merged for real into the "head", you aren't notified either (sadly), but the puller usually leaves a "merged" comment, and you get *that* notification.
>
> It isn't my pull but I want to know if this pull is merged in the near future because it fix the "auto ref" problem and that is a very big issue.
> Also I want to know if someone is working on the pull currently.

As they say here: http://forum.dlang.org/thread/pklewzmhquqewkecyuld@forum.dlang.org#post-pklewzmhquqewkecyuld:40forum.dlang.org
the working on less important things is apparently more important instead to merge something like the "auto ref" pull or the other 116 pulls.
January 19, 2013
Does anyone else think, that merging this pull:
https://github.com/D-Programming-Language/dmd/pull/1428
would be better then waiting for pull 1019?
Pull 1428 is ready to merge and use.
If someday pull 1019 is ready, it can replace pull 1428.
Fact is, that this problem has caused big issues by using structs. That's why a fast solution would be preferable.
January 22, 2013
On Friday, 18 January 2013 at 13:13:03 UTC, Jacob Carlborg wrote:
> On 2013-01-18 14:07, Namespace wrote:
>> Despite the danger that this annoy you probably:
>> What about pull 1019
>> (https://github.com/D-Programming-Language/dmd/pull/1019)? I'm still
>> quite new with Git so I do not know exactly what "1 Fail, 9 Pending"
>> means (and why it stands there so long)
>
> It means that the test suite failed. You can click "Details" to get more details about what failed.

Ok I observe the pull been a while and have to say that the status is always the same: 1 Fails, 9 Pending. I also see that it is updated every few hours, but the status is still the same every time.
Is this normal? Is that automatically update accordingly?
And how is such a nice test environment integrated into a pull request?
« First   ‹ Prev
1 2