Thread overview
[Issue 15384] assignment is sometimes still accepted as a condition
Dec 01, 2015
Infiltrator
Dec 02, 2015
Kenji Hara
December 01, 2015
https://issues.dlang.org/show_bug.cgi?id=15384

Infiltrator <lt.infiltrator@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lt.infiltrator@gmail.com

--- Comment #1 from Infiltrator <lt.infiltrator@gmail.com> ---
I assume that this has to do with the way in which the comma operator works. The compiler then sees it not as two assignments, but the output of the comma operator (which is just a value).  Not sure how difficult it would be to get the compiler to track down into a comma operator, since you can do arbitrary work inside it.

--
December 02, 2015
https://issues.dlang.org/show_bug.cgi?id=15384

Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Kenji Hara <k.hara.pg@gmail.com> ---
https://github.com/D-Programming-Language/dmd/pull/5293

--
January 06, 2016
https://issues.dlang.org/show_bug.cgi?id=15384

--- Comment #3 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/95453495fdb38b9c596a977595ce23966fa55be7 fix Issue 15384 - assignment is sometimes still accepted as a condition

1. Add CommaExp.toBoolean to show error message.
2. Add checkAssignmentAsCondition and call it before semantic analysis to
provide informative diagnostic.

https://github.com/D-Programming-Language/dmd/commit/66ca6fe6cfe45f251664abed7304814c4e07af68 Merge pull request #5293 from 9rnsr/fix15384

Issue 15384 - assignment is sometimes still accepted as a condition

--
January 06, 2016
https://issues.dlang.org/show_bug.cgi?id=15384

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
March 19, 2016
https://issues.dlang.org/show_bug.cgi?id=15384

--- Comment #4 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/95453495fdb38b9c596a977595ce23966fa55be7 fix Issue 15384 - assignment is sometimes still accepted as a condition

https://github.com/D-Programming-Language/dmd/commit/66ca6fe6cfe45f251664abed7304814c4e07af68 Merge pull request #5293 from 9rnsr/fix15384

--
January 03
https://issues.dlang.org/show_bug.cgi?id=15384

--- Comment #5 from github-bugzilla@puremagic.com ---
Commit pushed to dmd-cxx at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/9ea575a943ae532743aa085400835e007c4f26c4 fix Issue 15384 - assignment is sometimes still accepted as a condition

--