Thread overview
[Issue 17169] New default ddoc theme merges all paragraphs except the first
February 13
https://issues.dlang.org/show_bug.cgi?id=17169

Jacob Carlborg <doob@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doob@me.com

--- Comment #1 from Jacob Carlborg <doob@me.com> ---
https://github.com/dlang/dmd/pull/6538

--
February 14
https://issues.dlang.org/show_bug.cgi?id=17169

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com

--- Comment #2 from Walter Bright <bugzilla@digitalmars.com> ---
Where's P1? What does the PR output?

--
February 14
https://issues.dlang.org/show_bug.cgi?id=17169

--- Comment #3 from Nick Sabalausky <bus_dbugzilla@semitwist.com> ---
P1 is in a separate "Summary" div further up from the Description div shown here. This, I understand, is intentional as the first paragraph is considered to be the "summary", and the rest, "discussion" <http://dlang.org/spec/ddoc.html#sections>.

Taking a look at the PR, and the test file changes in it, it appears it would add <br><br> between P2 and P3 (just like the old theme did), although I havent actually run the PR myself. There was some discussion in DMD PR#4745 <https://github.com/dlang/dmd/pull/4745#issuecomment-278841601> that this isn't intended to be the ideal long-term aaproach, however it seemed generally agreed that the "proper" aaproach would be tricky and involved, and that this <br><br> was a better than nothing in the meantime.

--
February 16
https://issues.dlang.org/show_bug.cgi?id=17169

--- Comment #4 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/5fcb2ea18bf9434624b8163d80a14f8782639483 Fix issue 17169 - New default ddoc theme merges all paragraphs except the first

https://github.com/dlang/dmd/commit/56ca1da4a46b87d87437abc740c89dbb0af3a8ba Merge pull request #6538 from jacob-carlborg/issue_17169

Fix issue 17169 - New default ddoc theme merges all paragraphs except…

--
February 16
https://issues.dlang.org/show_bug.cgi?id=17169

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
February 16
https://issues.dlang.org/show_bug.cgi?id=17169

--- Comment #5 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/5fcb2ea18bf9434624b8163d80a14f8782639483 Fix issue 17169 - New default ddoc theme merges all paragraphs except the first

https://github.com/dlang/dmd/commit/56ca1da4a46b87d87437abc740c89dbb0af3a8ba Merge pull request #6538 from jacob-carlborg/issue_17169

--
1 day ago
https://issues.dlang.org/show_bug.cgi?id=17169

--- Comment #6 from github-bugzilla@puremagic.com ---
Commits pushed to newCTFE at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/5fcb2ea18bf9434624b8163d80a14f8782639483 Fix issue 17169 - New default ddoc theme merges all paragraphs except the first

https://github.com/dlang/dmd/commit/56ca1da4a46b87d87437abc740c89dbb0af3a8ba Merge pull request #6538 from jacob-carlborg/issue_17169

--