Now the JFace stuff compiles with the available dwt on win/linux.

dwt-samples/jface/ActionAndStatusbar
is a first showcase.


More example code as showcases and testcases is very welcome.
Snippets can be found here:
http://wiki.eclipse.org/index.php/JFaceSnippets


Due to a compiler bug (#1978), the tango collection need a fix to make JFace not going into a endless loop.

- tango.util.collection.mode.View
  line 39  : public Dispenser!(T) duplicate();
  change to: public View!(T) duplicate();


- tango.util.collection.mode.Set
  line 37 add:
  public Set!(T) duplicate();
  public alias duplicat dup;

Frank Benoit wrote:
> Now the JFace stuff compiles with the available dwt on win/linux.

Cool.  I don't really know what it is, but it seems to be all the rage among SWT coders.

> dwt-samples/jface/ActionAndStatusbar
> is a first showcase.
> 
> 
> More example code as showcases and testcases is very welcome.
> Snippets can be found here:
> http://wiki.eclipse.org/index.php/JFaceSnippets

To try this out we need to update both dwt-samples and dwt-addons?

> Due to a compiler bug (#1978), the tango collection need a fix to make JFace not going into a endless loop.
> 
> - tango.util.collection.mode.View

Should be .model.View, not .mode.View right?

>   line 39  : public Dispenser!(T) duplicate();
>   change to: public View!(T) duplicate();
> 
> 
> - tango.util.collection.mode.Set
>   line 37 add:
>   public Set!(T) duplicate();
>   public alias duplicat dup;

Should be alias duplicate not alias duplicat, right?

Frank Benoit wrote:
> Now the JFace stuff compiles with the available dwt on win/linux.
> 
> dwt-samples/jface/ActionAndStatusbar
> is a first showcase.
> 
> 
> More example code as showcases and testcases is very welcome.
> Snippets can be found here:
> http://wiki.eclipse.org/index.php/JFaceSnippets
> 
> 
> Due to a compiler bug (#1978), the tango collection need a fix to make JFace not going into a endless loop.
> 
> - tango.util.collection.mode.View
>   line 39  : public Dispenser!(T) duplicate();
>   change to: public View!(T) duplicate();
> 
> 
> - tango.util.collection.mode.Set
>   line 37 add:
>   public Set!(T) duplicate();
>   public alias duplicat dup;

I made those changes to svn tango,
hg pulled & updated dwt-win and dwt-addons
did dsss build and dsss install for all three,
but I'm getting errors with dsss build on dwt-addons.

For instance
dwt-addons/dwtx/jface/viewers/AbstractListViewer.d(474)
is using Java style anonymous declaration.

And then the tango changes seem to be leading to lots of compiler erorrs in dwtx.core:
dwtx\core\commands\operations\TriggeredOperations.d(200): Error: cannot implicitly convert expression (this.children.duplicate()) of type tango.util.collection.model.View.View!(IUndoableOperation).View to tango.util.collection.model.Seq.Seq!(IUndoableOperation).Seq
dwtx\core\commands\operations\TriggeredOperations.d(237): Error: cannot implicitly convert expression (childrenToRestore) of type tango.util.collection.model.View.View!(IUndoableOperation).View to tango.util.collection.model.Seq.Seq!(IUndoableOperation).Seq
dwtx\core\commands\operations\TriggeredOperations.d(243): Error: cannot implicitly convert expression (childrenToRestore) of type tango.util.collection.model.View.View!(IUndoableOperation).View to tango.util.collection.model.Seq.Seq!(IUndoableOperation).Seq
dwtx\core\commands\operations\TriggeredOperations.d(247): Error: cannot implicitly convert expression (childrenToRestore) of type tango.util.collection.model.View.View!(IUndoableOperation).View to tango.util.collection.model.Seq.Seq!(IUndoableOperation).Seq


--bb

> > - tango.util.collection.mode.Set
> >   line 37 add:
> >   public Set!(T) duplicate();
> >   public alias duplicat dup;

hm, should be Seq instead of Set.

 - tango.util.collection.mode.Seq
   line 37 add:
   public Seq!(T) duplicate();
   public alias duplicate dup;

Bill Baxter Wrote:

> Frank Benoit wrote:
> > Now the JFace stuff compiles with the available dwt on win/linux.
> 
> Cool.  I don't really know what it is, but it seems to be all the rage among SWT coders.
> 
> > dwt-samples/jface/ActionAndStatusbar
> > is a first showcase.
> > 
> > 
> > More example code as showcases and testcases is very welcome. Snippets can be found here: http://wiki.eclipse.org/index.php/JFaceSnippets
> 
> To try this out we need to update both dwt-samples and dwt-addons?
> 

Yes

> > Due to a compiler bug (#1978), the tango collection need a fix to make JFace not going into a endless loop.
> > 
> > - tango.util.collection.mode.View
> 
> Should be .model.View, not .mode.View right?
> 

Yes

> >   line 39  : public Dispenser!(T) duplicate();
> >   change to: public View!(T) duplicate();
> > 
> > 
> > - tango.util.collection.mode.Set
> >   line 37 add:
> >   public Set!(T) duplicate();
> >   public alias duplicat dup;
> 
> Should be alias duplicate not alias duplicat, right?

Yes
And instead Set it should be Seq.

I will try to do a better description on a wiki page in a few hours.

Bill Baxter schrieb:
> I made those changes to svn tango,
> hg pulled & updated dwt-win and dwt-addons
> did dsss build and dsss install for all three,
> but I'm getting errors with dsss build on dwt-addons.

There were indead some compile errors left, due to my latest code changes. I did only compile the example without rebuilding all files in dwtx, so i did not saw the error. It should work now.

I added some more info here:
http://www.dsource.org/projects/dwt/wiki/JFace

Frank Benoit wrote:
> Bill Baxter schrieb:
>> I made those changes to svn tango,
>> hg pulled & updated dwt-win and dwt-addons
>> did dsss build and dsss install for all three,
>> but I'm getting errors with dsss build on dwt-addons.
> 
> There were indead some compile errors left, due to my latest code changes. I did only compile the example without rebuilding all files in dwtx, so i did not saw the error. It should work now.
> 
> I added some more info here:
> http://www.dsource.org/projects/dwt/wiki/JFace
> 

Where is this supposed to be found?

f:/usr/pkg/d/dsss/bin\..\include\d\dwt\dwthelper\utils.di(944): Error: file "eclipse-icon-red-16.png" cannot be found, check -Jpath

I can't locate it in any of the dwt-* res dirs.  Is it possible you forgot to check it in?

--bb

Bill Baxter schrieb:

> Where is this supposed to be found?
> 
> f:/usr/pkg/d/dsss/bin\..\include\d\dwt\dwthelper\utils.di(944): Error: file "eclipse-icon-red-16.png" cannot be found, check -Jpath
> 
> I can't locate it in any of the dwt-* res dirs.  Is it possible you forgot to check it in?
> 
> --bb

There are two folders containing images for compile time inclusion.

dwt-samples/res
dwt-addons/res

both folders need to be given with -J

Its also mentioned on the wiki page.

Frank Benoit wrote:
> Bill Baxter schrieb:
> 
>> Where is this supposed to be found?
>>
>> f:/usr/pkg/d/dsss/bin\..\include\d\dwt\dwthelper\utils.di(944): Error: file "eclipse-icon-red-16.png" cannot be found, check -Jpath
>>
>> I can't locate it in any of the dwt-* res dirs.  Is it possible you forgot to check it in?
>>
>> --bb
> 
> There are two folders containing images for compile time inclusion.
> 
> dwt-samples/res
> dwt-addons/res
> 
> both folders need to be given with -J
> 
> Its also mentioned on the wiki page.

And neither one contains eclipse-icon-red-16.png.  Is it possible you forgot to check it in?

--bb

Bill Baxter schrieb:

> And neither one contains eclipse-icon-red-16.png.  Is it possible you forgot to check it in?
> 
> --bb

yes ;)