While Jacob is working on improving std.serialization, there is some time to do more reviews. Review manager role does not seem to be very stressing, so I can step up as one for any of the projects currently in queue as soon as their authors express the desire to do so.

Personally, I'd love to move forward with std.d.lexer - Brian, what is your opinion on this?

On 2013-09-09 16:21, Dicebot wrote:

> Personally, I'd love to move forward with std.d.lexer - Brian, what is
> your opinion on this?

I would love to see that as well.

-- 
/Jacob Carlborg

On Mon, Sep 09, 2013 at 04:21:16PM +0200, Dicebot wrote:
> While Jacob is working on improving std.serialization, there is some time to do more reviews. Review manager role does not seem to be very stressing, so I can step up as one for any of the projects currently in queue as soon as their authors express the desire to do so.
> 
> Personally, I'd love to move forward with std.d.lexer - Brian, what is your opinion on this?

+1. I've been itching to get a high-quality D lexer in my hands.


T

-- 
Who told you to swim in Crocodile Lake without life insurance??

On Monday, 9 September 2013 at 14:52:46 UTC, H. S. Teoh wrote:
> On Mon, Sep 09, 2013 at 04:21:16PM +0200, Dicebot wrote:
>> While Jacob is working on improving std.serialization, there is some
>> time to do more reviews. Review manager role does not seem to be
>> very stressing, so I can step up as one for any of the projects
>> currently in queue as soon as their authors express the desire to do
>> so.
>> 
>> Personally, I'd love to move forward with std.d.lexer - Brian, what
>> is your opinion on this?
>
> +1. I've been itching to get a high-quality D lexer in my hands.
>
>
> T

..and I'd love it to be nicely field tested by the time DDMD is done so that latter can possibly be ported to use standard lexer :P

On 09/09/2013 04:21 PM, Dicebot wrote:
> While Jacob is working on improving std.serialization, there is some time to do more reviews. Review manager role does not seem to be very stressing, so I can step up as one for any of the projects currently in queue as soon as their authors express the desire to do so.
put some concrete "destroying" in my logger

On Monday, 9 September 2013 at 14:21:17 UTC, Dicebot wrote:
> While Jacob is working on improving std.serialization, there is some time to do more reviews. Review manager role does not seem to be very stressing, so I can step up as one for any of the projects currently in queue as soon as their authors express the desire to do so.
>
> Personally, I'd love to move forward with std.d.lexer - Brian, what is your opinion on this?

Other than some unit test coverage, I think the lexer is ready.

On Monday, 9 September 2013 at 20:24:43 UTC, Robert Schadek wrote:
> On 09/09/2013 04:21 PM, Dicebot wrote:
>> While Jacob is working on improving std.serialization, there is some
>> time to do more reviews. Review manager role does not seem to be very
>> stressing, so I can step up as one for any of the projects currently
>> in queue as soon as their authors express the desire to do so.
> put some concrete "destroying" in my logger

You should add it to http://wiki.dlang.org/Review_Queue then, there is also a link to an old review thread of `std.log` by Jose Armando Garcia which may be of interest to you as people are likely to ask similar questions :)

On Monday, 9 September 2013 at 20:52:09 UTC, Brian Schott wrote:
> On Monday, 9 September 2013 at 14:21:17 UTC, Dicebot wrote:
>> While Jacob is working on improving std.serialization, there is some time to do more reviews. Review manager role does not seem to be very stressing, so I can step up as one for any of the projects currently in queue as soon as their authors express the desire to do so.
>>
>> Personally, I'd love to move forward with std.d.lexer - Brian, what is your opinion on this?
>
> Other than some unit test coverage, I think the lexer is ready.

Good! I'll start a review thread within a day.

On 09/10/2013 01:43 PM, Dicebot wrote:
> You should add it to http://wiki.dlang.org/Review_Queue then, there is also a link to an old review thread of `std.log` by Jose Armando Garcia which may be of interest to you as people are likely to ask similar questions :)
done and done (the design of my logger is based on what I distilled from
the old discussion)

On Tuesday, 10 September 2013 at 12:09:42 UTC, Robert Schadek wrote:
> On 09/10/2013 01:43 PM, Dicebot wrote:
>> You should add it to http://wiki.dlang.org/Review_Queue then, there is
>> also a link to an old review thread of `std.log` by Jose Armando
>> Garcia which may be of interest to you as people are likely to ask
>> similar questions :)
> done and done (the design of my logger is based on what I distilled from
> the old discussion)

Thanks! You will be next after Brian then (pardon me for wanting std.d.lexer so much :P)