Menu
Search

Forums

Forum Index

Thread overview
DMD maintainers, revert PR #10200
Nov 06, 2020
Basile B.
Nov 06, 2020
Nicholas Wilson
Nov 06, 2020
Basile B.
November 06, 2020
Gravatar of Basile B.Posted by Basile B.Reply
Basile B.
Gravatar of Basile B.


Reply
The PR #10200 [1] has already caused 2 backend regressions ([2], [3]).
May I suggest to revert it ?

[1] https://github.com/dlang/dmd/pull/10200
[2] https://issues.dlang.org/show_bug.cgi?id=21328
[3] https://issues.dlang.org/show_bug.cgi?id=21364
November 06, 2020
Gravatar of Nicholas WilsonPosted by Nicholas Wilson
in reply to Basile B.		Reply
Nicholas Wilson
Gravatar of Nicholas Wilson
Posted in reply to Basile B.


Reply
On Friday, 6 November 2020 at 03:17:09 UTC, Basile B. wrote:
> The PR #10200 [1] has already caused 2 backend regressions ([2], [3]).
> May I suggest to revert it ?
>
> [1] https://github.com/dlang/dmd/pull/10200
> [2] https://issues.dlang.org/show_bug.cgi?id=21328
> [3] https://issues.dlang.org/show_bug.cgi?id=21364

PR for issue 21328 https://github.com/dlang/dmd/pull/11927
November 06, 2020
Gravatar of Basile B.Posted by Basile B.
in reply to Nicholas Wilson		Reply
Basile B.
Gravatar of Basile B.
Posted in reply to Nicholas Wilson


Reply
On Friday, 6 November 2020 at 06:06:46 UTC, Nicholas Wilson wrote:
> On Friday, 6 November 2020 at 03:17:09 UTC, Basile B. wrote:
>> The PR #10200 [1] has already caused 2 backend regressions ([2], [3]).
>> May I suggest to revert it ?
>>
>> [1] https://github.com/dlang/dmd/pull/10200
>> [2] https://issues.dlang.org/show_bug.cgi?id=21328
>> [3] https://issues.dlang.org/show_bug.cgi?id=21364
>
> PR for issue 21328 https://github.com/dlang/dmd/pull/11927

Nice but I'm afraid that the two regs found are just the tip of the iceberg. The original PR was much too big.