Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.

Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0

Please take some time and help make Phobos better ;)

On Monday, 6 January 2014 at 09:11:09 UTC, Dicebot wrote:
> Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.
>
> Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0
>
> Please take some time and help make Phobos better ;)

Yes.

It's not a condition, but wish list:

1) Robert, please add thread-safe example for multi-thread application. I know that you think it's unnecessary (http://forum.dlang.org/post/ykwgtaysaaejyvjsqjfe@forum.dlang.org), but I disagree.

2) It looks like D module system is not good enough. Robert creates additional struct `Signal` and string mixin `signal` to immitate C++ `friend` keyword. Maybe we should add this functionality to the D language.

On Monday, 6 January 2014 at 09:11:09 UTC, Dicebot wrote:
> Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.
>
> Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0
>
> Please take some time and help make Phobos better ;)

No.

I think the use of a string mixin here is bad for usability, readability and documentation. I think we should either search for a different solution to this problem (maybe even think about a language enhancement) or just abandon the idea altogether.

I also think it would be better if the "weak" connect that currently takes a delegate would just take a function pointer; as it is, I think this part of the interface is error prone.

On a semi-related note, the implementation has a number of problems. As they don't affect the interface, they don't count towards my vote, but I'll mention them anyway: the code uses widely inconsistent formatting which really harms readability, and there's at least one seriously questionable allocation strategy in there. Additionally, I think the presented documentation is really poorly written.

Just a little update: More recent and prettier documentation can be found at:

https://vhios.dyndns.org/dlang.org/web/phobos-prerelease/std_signal.html

The pull request for phobos can be found here:

https://github.com/D-Programming-Language/phobos/pull/1833/files

Best regards,

Robert

On 2014-01-06 09:11:07 +0000, Dicebot said:

> Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.
> 
> Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0
> 
> Please take some time and help make Phobos better ;)

Hi, not really a comment regarding the actual implementation but I think that good debug support for signales & slots helps a lot in using it. What do I mean with this:

- a way to dump in a human readable form the run-time connections. Which function / class / etc. is currently attached to which signal?
- automatic logging like a call-stack in a debugger to get an idea when which signal is acted on
- a way to get the order of activation for debugging to identify unwanted side-effects
- etc.

Big signal & slot implementaitons can be hard to debug, this should be as simple as possible.

-- 
Robert M. Münch
Saphirion AG

http://www.saphirion.com
smarter | better | faster

On Friday, 10 January 2014 at 12:24:18 UTC, Robert M. Münch wrote:
> Hi, not really a comment regarding the actual implementation but I think that good debug support for signales & slots helps a lot in using it. What do I mean with this:
>
> - a way to dump in a human readable form the run-time connections. Which function / class / etc. is currently attached to which signal?
> - automatic logging like a call-stack in a debugger to get an idea when which signal is acted on
> - a way to get the order of activation for debugging to identify unwanted side-effects
> - etc.
>
> Big signal & slot implementaitons can be hard to debug, this should be as simple as possible.

Please move discussion to matching thread linked in first post. This one is for voting.

On Monday, 6 January 2014 at 09:11:09 UTC, Dicebot wrote:
> Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.
>
> Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0
>
> Please take some time and help make Phobos better ;)

Yes.
I use it, it's been rock solid so far.

On 2014-01-06 09:11:07 +0000, Dicebot said:

> Some time ago there have been a review for `std.signal` Phobos proposal (http://forum.dlang.org/thread/ujlhznaphepibgtpcoqz@forum.dlang.org#post-ujlhznaphepibgtpcoqz:40forum.dlang.org). It have not received much feedback and I was a it too busy to proceed with final voting at that moment but with no outstanding issues to address nothing prevents that final step.
> 
> Let's put 2 week deadline to refresh memories about the proposal and make some decision. Voting closes at January 20th 23:59 GMT 0
> 
> Please take some time and help make Phobos better ;)

Yes. It's a fundamental pattern that should be in Phobos.

-- 
Robert M. Münch
Saphirion AG

http://www.saphirion.com
smarter | better | faster

To everyone: please consider replying in linked discussion thread if you don't feel like you are going to vote for any reason. So far activity is rather low and I think I will need some feedback to determine if it is because of low demand or for some other reasons.

On 2014-01-13 13:50:09 +0000, Dicebot said:

> To everyone: please consider replying in linked discussion thread if you don't feel like you are going to vote for any reason.

Don't understand what you mean... How about explaining how to vote if it's not here, or there, ... keep things simple please.

> So far activity is rather low and I think I will need some feedback to determine if it is because of low demand or for some other reasons.

Maybe because people don't understand the process.

-- 
Robert M. Münch
Saphirion AG

http://www.saphirion.com
smarter | better | faster