Thread overview | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
|
June 08, 2016 Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Hi, I solved the issue. PR is coming shortly. |
June 08, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Stefan Koch | On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
> Hi, I solved the issue.
> PR is coming shortly.
How was they getting recursive?
|
June 08, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Stefan Koch | On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
> Hi, I solved the issue.
> PR is coming shortly.
Dude come on, that isn't an announce. There is No PR, there is no description of the solution, there is nothing.
Hey guys, I cured cancer and solved world hunger. PR coming soon.
|
June 08, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Jerry | On Wednesday, 8 June 2016 at 18:02:41 UTC, Jerry wrote:
> On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
>> Hi, I solved the issue.
>> PR is coming shortly.
>
> How was they getting recursive?
Think to the fibo templatized example, it generates a very long mangle with basically always the same symbol.
|
June 08, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to deadalnix | On Wednesday, 8 June 2016 at 19:41:49 UTC, deadalnix wrote:
> On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
>> Hi, I solved the issue.
>> PR is coming shortly.
>
> Dude come on, that isn't an announce. There is No PR, there is no description of the solution, there is nothing.
>
> Hey guys, I cured cancer and solved world hunger. PR coming soon.
Lol ! My turn:
I'm a genious but I haven't done anything genial yet...
|
June 09, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Stefan Koch | On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
> Hi, I solved the issue.
> PR is coming shortly.
Solution is as follows:
Keep a list of already visited symbols in the mangler.
And information where we store the mangle.
meaning the position in the mangle string.
If a symbol is encountered for the second time store a backrefernce rather then the symbol name again.
|
June 09, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Stefan Koch | On Thursday, 9 June 2016 at 04:58:45 UTC, Stefan Koch wrote: > On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote: >> Hi, I solved the issue. >> PR is coming shortly. > > Solution is as follows: > > Keep a list of already visited symbols in the mangler. > And information where we store the mangle. > meaning the position in the mangle string. > If a symbol is encountered for the second time store a backrefernce rather then the symbol name again. You mean this? https://github.com/weka-io/ldc/commit/ffd6b55a4b83b3007d9690cbd9a25d07b243a00e It did not result in a large reduction of symbol sizes. http://forum.dlang.org/post/szodxrizfmufqdkpdryc@forum.dlang.org |
June 09, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to Johan Engelen | On 09.06.2016 11:02, Johan Engelen wrote: > On Thursday, 9 June 2016 at 04:58:45 UTC, Stefan Koch wrote: >> On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote: >>> Hi, I solved the issue. >>> PR is coming shortly. >> >> Solution is as follows: >> >> Keep a list of already visited symbols in the mangler. >> And information where we store the mangle. >> meaning the position in the mangle string. >> If a symbol is encountered for the second time store a backrefernce >> rather then the symbol name again. > > You mean this? > https://github.com/weka-io/ldc/commit/ffd6b55a4b83b3007d9690cbd9a25d07b243a00e > This doesn't handle the manglers created locally for templates and parameter tuples. Here's a more complete version: https://github.com/dlang/dmd/pull/5855 |
June 13, 2016 Re: Recursive SymbolNames solved. | ||||
---|---|---|---|---|
| ||||
Posted in reply to FlatBareRunner | On Wednesday, 8 June 2016 at 20:15:57 UTC, FlatBareRunner wrote:
> On Wednesday, 8 June 2016 at 19:41:49 UTC, deadalnix wrote:
>> On Wednesday, 8 June 2016 at 13:28:19 UTC, Stefan Koch wrote:
>>> Hi, I solved the issue.
>>> PR is coming shortly.
>>
>> Dude come on, that isn't an announce. There is No PR, there is no description of the solution, there is nothing.
>>
>> Hey guys, I cured cancer and solved world hunger. PR coming soon.
>
> Lol ! My turn:
>
> I'm a genious but I haven't done anything genial yet...
Writer here. Not yet published but working hard on the first one...
|
Copyright © 1999-2021 by the D Language Foundation