dmd commit, revision 632


user: walter

msg:
Regression(2.046, 1.061): compiler errors using startsWith in CTFE

http://www.dsource.org/projects/dmd/changeset/632

Picking a random but representative example...

Why no changes to the public dmd test suite?  Let me guess, you changed the private one?  The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)

On 8/27/2010 12:25 AM, dsource.org wrote:
> dmd commit, revision 632
> 
> 
> user: walter
> 
> msg:
> Regression(2.046, 1.061): compiler errors using startsWith in CTFE
> 
> http://www.dsource.org/projects/dmd/changeset/632
> 

Brad Roberts wrote:
>
> Why no changes to the public dmd test suite?  Let me guess, you changed the private one?  The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)
>
> 

I'm guilty as charged on all counts.

On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
> Picking a random but representative example...
>
> Why no changes to the public dmd test suite? ?Let me guess, you changed the private one? ?The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)

BTW -- I'm not using the public one either. It's not really usable on Windows.

On 8/27/2010 9:52 PM, Don Clugston wrote:
> On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
>> Picking a random but representative example...
>>
>> Why no changes to the public dmd test suite?  Let me guess, you changed the private one?  The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)
> 
> BTW -- I'm not using the public one either. It's not really usable on Windows.

Would you (or really anyone doing windows development) mind taking a little time and investigate fixing that?  I don't think it'd be particularly hard, but I don't do any development on windows.  There's very few tools involved (a list from a quick scan of the single Makefile and the test script 'do_test.sh':

  gnu make
  mkdir
  rm
  cat
  bash
  grep
  tr
  diff

I'd really like it to be the test platform everyone can and does use.

Thanks,
Brad

> There's very few tools involved (a list
> from a quick scan of the single Makefile and the test script
> 'do_test.sh':
>
>   gnu make
>   mkdir
>   rm
>   cat
>   bash
>   grep
>   tr
>   diff

I guess it could work with MSys.

Gnuwin32 should almost do it, except possibly for bash.

Sent from my iPhone

On Aug 27, 2010, at 10:04 PM, Brad Roberts <braddr at puremagic.com> wrote:

> On 8/27/2010 9:52 PM, Don Clugston wrote:
>> On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
>>> Picking a random but representative example...
>>> 
>>> Why no changes to the public dmd test suite?  Let me guess, you changed the private one?  The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)
>> 
>> BTW -- I'm not using the public one either. It's not really usable on Windows.
> 
> Would you (or really anyone doing windows development) mind taking a little time and investigate fixing that?  I don't think it'd be particularly hard, but I don't do any development on windows.  There's very few tools involved (a list from a quick scan of the single Makefile and the test script 'do_test.sh':
> 
>  gnu make
>  mkdir
>  rm
>  cat
>  bash
>  grep
>  tr
>  diff
> 
> I'd really like it to be the test platform everyone can and does use.
> 
> Thanks,
> Brad
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

Rewriting do_test.sh into a d app instead of bash would help, but it'd still leave a gap for the hand full of tests that use a post-test script to do more validations than just 'it built' or 'it ran'.

Every one of those is easily available in cygwin.

The other key changes I didn't mention below is the obvious stuff like abstracting .o into $(OBJ) or something similar to hide the .o vs .obj difference between platforms, and other similar file name deltas.

On Mon, 30 Aug 2010, Sean Kelly wrote:

> Gnuwin32 should almost do it, except possibly for bash.
> 
> Sent from my iPhone
> 
> On Aug 27, 2010, at 10:04 PM, Brad Roberts <braddr at puremagic.com> wrote:
> 
> > On 8/27/2010 9:52 PM, Don Clugston wrote:
> >> On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
> >>> Picking a random but representative example...
> >>> 
> >>> Why no changes to the public dmd test suite?  Let me guess, you changed the private one?  The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)
> >> 
> >> BTW -- I'm not using the public one either. It's not really usable on Windows.
> > 
> > Would you (or really anyone doing windows development) mind taking a little time and investigate fixing that?  I don't think it'd be particularly hard, but I don't do any development on windows.  There's very few tools involved (a list from a quick scan of the single Makefile and the test script 'do_test.sh':
> > 
> >  gnu make
> >  mkdir
> >  rm
> >  cat
> >  bash
> >  grep
> >  tr
> >  diff
> > 
> > I'd really like it to be the test platform everyone can and does use.
> > 
> > Thanks,
> > Brad
> > _______________________________________________
> > dmd-internals mailing list
> > dmd-internals at puremagic.com
> > http://lists.puremagic.com/mailman/listinfo/dmd-internals
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
> 

--------
It's gnu make that's the real problem.
If I rename gnu make to 'gnumake' (necessary otherwise there's a paths
disaster), here's what I get:

C:\dmd2dev\src\test>gnumake quick
gnumake ARGS="" run_tests
gnumake[1]: Entering directory `/cygdrive/c/dmd2dev/src/test'
Building combinations tool
Max # of fixups = 12
OPTLINK (R) for Win32  Release 8.00.1
Copyright (C) Digital Mars 1989-2004  All rights reserved.
OPTLINK : Warning 9: Unknown Option : COMBINATIONS
user32.def(0) : Error 2: File Not Found user32.def
--- errorlevel 1
gnumake[1]: *** [test_results/combinations] Error 1 gnumake[1]: Leaving directory `/cygdrive/c/dmd2dev/src/test' gnumake: *** [quick] Error 2
-----------
It might just be because OPTLINK can't handle / paths, I think it requires \.


On 28 August 2010 07:04, Brad Roberts <braddr at puremagic.com> wrote:
> On 8/27/2010 9:52 PM, Don Clugston wrote:
>> On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
>>> Picking a random but representative example...
>>>
>>> Why no changes to the public dmd test suite? ?Let me guess, you changed the private one? ?The one that's been superseded so that those of us out here on the other side of your screen have a chance of testing our changes and avoiding introducing regressions. :)
>>
>> BTW -- I'm not using the public one either. It's not really usable on Windows.
>
> Would you (or really anyone doing windows development) mind taking a little time and investigate fixing that? ?I don't think it'd be particularly hard, but I don't do any development on windows. ?There's very few tools involved (a list from a quick scan of the single Makefile and the test script 'do_test.sh':
>
> ?gnu make
> ?mkdir
> ?rm
> ?cat
> ?bash
> ?grep
> ?tr
> ?diff
>
> I'd really like it to be the test platform everyone can and does use.
>
> Thanks,
> Brad
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>

Optlink definitely cannot handle / paths. Must be \.

Don Clugston wrote:
> --------
> It's gnu make that's the real problem.
> If I rename gnu make to 'gnumake' (necessary otherwise there's a paths
> disaster), here's what I get:
>
> C:\dmd2dev\src\test>gnumake quick
> gnumake ARGS="" run_tests
> gnumake[1]: Entering directory `/cygdrive/c/dmd2dev/src/test'
> Building combinations tool
> Max # of fixups = 12
> OPTLINK (R) for Win32  Release 8.00.1
> Copyright (C) Digital Mars 1989-2004  All rights reserved.
> OPTLINK : Warning 9: Unknown Option : COMBINATIONS
> user32.def(0) : Error 2: File Not Found user32.def
> --- errorlevel 1
> gnumake[1]: *** [test_results/combinations] Error 1 gnumake[1]: Leaving directory `/cygdrive/c/dmd2dev/src/test' gnumake: *** [quick] Error 2
> -----------
> It might just be because OPTLINK can't handle / paths, I think it requires \.
>
>
> On 28 August 2010 07:04, Brad Roberts <braddr at puremagic.com> wrote:
> 
>> On 8/27/2010 9:52 PM, Don Clugston wrote:
>> 
>>> On 28 August 2010 02:02, Brad Roberts <braddr at puremagic.com> wrote:
>>> 
>>>> Picking a random but representative example...
>>>>
>>>> Why no changes to the public dmd test suite?  Let me guess, you changed the
>>>> private one?  The one that's been superseded so that those of us out here on the
>>>> other side of your screen have a chance of testing our changes and avoiding
>>>> introducing regressions. :)
>>>> 
>>> BTW -- I'm not using the public one either. It's not really usable on Windows.
>>> 
>> Would you (or really anyone doing windows development) mind taking a little time and investigate fixing that?  I don't think it'd be particularly hard, but I don't do any development on windows.  There's very few tools involved (a list from a quick scan of the single Makefile and the test script 'do_test.sh':
>>
>>  gnu make
>>  mkdir
>>  rm
>>  cat
>>  bash
>>  grep
>>  tr
>>  diff
>>
>> I'd really like it to be the test platform everyone can and does use.
>>
>> Thanks,
>> Brad
>> _______________________________________________
>> dmd-internals mailing list
>> dmd-internals at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>>
>> 
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>
>
>