Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos

  Commit: 601c75f9c319c8c8f9eaaad8174b3c811976349e
      https://github.com/D-Programming-Language/phobos/commit/601c75f9c319c8c8f9eaaad8174b3c811976349e
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Improve parsing error handling


  Commit: 29afc784f31182101d6985c7e58d377e9b2268fa
      https://github.com/D-Programming-Language/phobos/commit/29afc784f31182101d6985c7e58d377e9b2268fa
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Add associative array parsing


  Commit: 36c7e51733e0bbf11f5466259349697ba629de74
      https://github.com/D-Programming-Language/phobos/commit/36c7e51733e0bbf11f5466259349697ba629de74
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Parse array elements as quoted


  Commit: b6735c4f70bc6a28e63ae545e5910b854babc491
      https://github.com/D-Programming-Language/phobos/commit/b6735c4f70bc6a28e63ae545e5910b854babc491
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Add static array parsing.


  Commit: 88b678d36b9005a517ef1348d3b5a6f98e3ca0b4
      https://github.com/D-Programming-Language/phobos/commit/88b678d36b9005a517ef1348d3b5a6f98e3ca0b4
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Indent template constraint.


  Commit: 277d248cb1cb271151e156d89d50921634a58f0a
      https://github.com/D-Programming-Language/phobos/commit/277d248cb1cb271151e156d89d50921634a58f0a
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  parse family should not ignore head white spaces


  Commit: 3ff3c74638a7040678d47083de3ce4b4b5838b16
      https://github.com/D-Programming-Language/phobos/commit/3ff3c74638a7040678d47083de3ce4b4b5838b16
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  parse family should accept character range at least as source.


  Commit: 925375d79b2f9c3991fa9b9a21ee9f43d55ac242
      https://github.com/D-Programming-Language/phobos/commit/925375d79b2f9c3991fa9b9a21ee9f43d55ac242
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Reorder functions


  Commit: 833cbabd8ccb83b5351be8b8a233a73b125abe24
      https://github.com/D-Programming-Language/phobos/commit/833cbabd8ccb83b5351be8b8a233a73b125abe24
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Fix template constraints


  Commit: 1e3b2c09f4d399ee284c9061b0b724aac03b9bd0
      https://github.com/D-Programming-Language/phobos/commit/1e3b2c09f4d399ee284c9061b0b724aac03b9bd0
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Add auxiliary functions for range unformatting


  Commit: 22d8f2412053d53b8a00fde568dbbed5f75e51af
      https://github.com/D-Programming-Language/phobos/commit/22d8f2412053d53b8a00fde568dbbed5f75e51af
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Add boolean value unformatting


  Commit: 4c38fc9ea4c752a66871c9e11491cfbc80d89d9a
      https://github.com/D-Programming-Language/phobos/commit/4c38fc9ea4c752a66871c9e11491cfbc80d89d9a
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Fix character unformatting


  Commit: 61b430a379d7c26722c76a02575cd1a18fdcb1a3
      https://github.com/D-Programming-Language/phobos/commit/61b430a379d7c26722c76a02575cd1a18fdcb1a3
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Fix non-string array unformatting


  Commit: 64a3641f40e1f390d46f5d5cecb94bceafaa1b43
      https://github.com/D-Programming-Language/phobos/commit/64a3641f40e1f390d46f5d5cecb94bceafaa1b43
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Fix string unformatting


  Commit: 0a06ddec7a9c5259c6620b883086c4e2e53ee6e5
      https://github.com/D-Programming-Language/phobos/commit/0a06ddec7a9c5259c6620b883086c4e2e53ee6e5
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Add associative array unformatting


  Commit: de0a63f5bf600ed002b0d3d76ac3505e47ab43cd
      https://github.com/D-Programming-Language/phobos/commit/de0a63f5bf600ed002b0d3d76ac3505e47ab43cd
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d
  M std/format.d

  Log Message:
  -----------
  Add trivial fixes.


  Commit: c120d5f3130d2643297fed6b2290c98f095f4c54
      https://github.com/D-Programming-Language/phobos/commit/c120d5f3130d2643297fed6b2290c98f095f4c54
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Reduce template instantiation count


  Commit: c979fe4437e66607c56a3ca38f82bfa8a1f15ea8
      https://github.com/D-Programming-Language/phobos/commit/c979fe4437e66607c56a3ca38f82bfa8a1f15ea8
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Improve error messages


  Commit: f1d1a3e720b01e8d11a60f1f11b2e3e3e52735de
      https://github.com/D-Programming-Language/phobos/commit/f1d1a3e720b01e8d11a60f1f11b2e3e3e52735de
  Author: k-hara <k.hara.pg at gmail.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d

  Log Message:
  -----------
  Split parseElement function by template constraint


  Commit: 755b21f06312ba857966d54bbcc6da5c81eebaf9
      https://github.com/D-Programming-Language/phobos/commit/755b21f06312ba857966d54bbcc6da5c81eebaf9
  Author: Andrei Alexandrescu <andrei at erdani.com>
  Date:   2011-09-04 (Sun, 04 Sep 2011)

  Changed paths:
    M std/conv.d
  M std/format.d

  Log Message:
  -----------
  Merge pull request #208 from 9rnsr/improve_unformat

Improve value unformatting


Compare: https://github.com/D-Programming-Language/phobos/compare/8535d7b...755b21f

This causes the std.conv unittests to fail on linux with a seg fault.

On 9/4/2011 8:10 PM, noreply at github.com wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/D-Programming-Language/phobos
>
>    Commit: 601c75f9c319c8c8f9eaaad8174b3c811976349e
>        https://github.com/D-Programming-Language/phobos/commit/601c75f9c319c8c8f9eaaad8174b3c811976349e
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Improve parsing error handling
>
>
>    Commit: 29afc784f31182101d6985c7e58d377e9b2268fa
>        https://github.com/D-Programming-Language/phobos/commit/29afc784f31182101d6985c7e58d377e9b2268fa
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Add associative array parsing
>
>
>    Commit: 36c7e51733e0bbf11f5466259349697ba629de74
>        https://github.com/D-Programming-Language/phobos/commit/36c7e51733e0bbf11f5466259349697ba629de74
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Parse array elements as quoted
>
>
>    Commit: b6735c4f70bc6a28e63ae545e5910b854babc491
>        https://github.com/D-Programming-Language/phobos/commit/b6735c4f70bc6a28e63ae545e5910b854babc491
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Add static array parsing.
>
>
>    Commit: 88b678d36b9005a517ef1348d3b5a6f98e3ca0b4
>        https://github.com/D-Programming-Language/phobos/commit/88b678d36b9005a517ef1348d3b5a6f98e3ca0b4
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Indent template constraint.
>
>
>    Commit: 277d248cb1cb271151e156d89d50921634a58f0a
>        https://github.com/D-Programming-Language/phobos/commit/277d248cb1cb271151e156d89d50921634a58f0a
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    parse family should not ignore head white spaces
>
>
>    Commit: 3ff3c74638a7040678d47083de3ce4b4b5838b16
>        https://github.com/D-Programming-Language/phobos/commit/3ff3c74638a7040678d47083de3ce4b4b5838b16
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    parse family should accept character range at least as source.
>
>
>    Commit: 925375d79b2f9c3991fa9b9a21ee9f43d55ac242
>        https://github.com/D-Programming-Language/phobos/commit/925375d79b2f9c3991fa9b9a21ee9f43d55ac242
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Reorder functions
>
>
>    Commit: 833cbabd8ccb83b5351be8b8a233a73b125abe24
>        https://github.com/D-Programming-Language/phobos/commit/833cbabd8ccb83b5351be8b8a233a73b125abe24
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Fix template constraints
>
>
>    Commit: 1e3b2c09f4d399ee284c9061b0b724aac03b9bd0
>        https://github.com/D-Programming-Language/phobos/commit/1e3b2c09f4d399ee284c9061b0b724aac03b9bd0
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Add auxiliary functions for range unformatting
>
>
>    Commit: 22d8f2412053d53b8a00fde568dbbed5f75e51af
>        https://github.com/D-Programming-Language/phobos/commit/22d8f2412053d53b8a00fde568dbbed5f75e51af
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Add boolean value unformatting
>
>
>    Commit: 4c38fc9ea4c752a66871c9e11491cfbc80d89d9a
>        https://github.com/D-Programming-Language/phobos/commit/4c38fc9ea4c752a66871c9e11491cfbc80d89d9a
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Fix character unformatting
>
>
>    Commit: 61b430a379d7c26722c76a02575cd1a18fdcb1a3
>        https://github.com/D-Programming-Language/phobos/commit/61b430a379d7c26722c76a02575cd1a18fdcb1a3
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Fix non-string array unformatting
>
>
>    Commit: 64a3641f40e1f390d46f5d5cecb94bceafaa1b43
>        https://github.com/D-Programming-Language/phobos/commit/64a3641f40e1f390d46f5d5cecb94bceafaa1b43
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Fix string unformatting
>
>
>    Commit: 0a06ddec7a9c5259c6620b883086c4e2e53ee6e5
>        https://github.com/D-Programming-Language/phobos/commit/0a06ddec7a9c5259c6620b883086c4e2e53ee6e5
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/format.d
>
>    Log Message:
>    -----------
>    Add associative array unformatting
>
>
>    Commit: de0a63f5bf600ed002b0d3d76ac3505e47ab43cd
>        https://github.com/D-Programming-Language/phobos/commit/de0a63f5bf600ed002b0d3d76ac3505e47ab43cd
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>    M std/format.d
>
>    Log Message:
>    -----------
>    Add trivial fixes.
>
>
>    Commit: c120d5f3130d2643297fed6b2290c98f095f4c54
>        https://github.com/D-Programming-Language/phobos/commit/c120d5f3130d2643297fed6b2290c98f095f4c54
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Reduce template instantiation count
>
>
>    Commit: c979fe4437e66607c56a3ca38f82bfa8a1f15ea8
>        https://github.com/D-Programming-Language/phobos/commit/c979fe4437e66607c56a3ca38f82bfa8a1f15ea8
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Improve error messages
>
>
>    Commit: f1d1a3e720b01e8d11a60f1f11b2e3e3e52735de
>        https://github.com/D-Programming-Language/phobos/commit/f1d1a3e720b01e8d11a60f1f11b2e3e3e52735de
>    Author: k-hara<k.hara.pg at gmail.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>
>    Log Message:
>    -----------
>    Split parseElement function by template constraint
>
>
>    Commit: 755b21f06312ba857966d54bbcc6da5c81eebaf9
>        https://github.com/D-Programming-Language/phobos/commit/755b21f06312ba857966d54bbcc6da5c81eebaf9
>    Author: Andrei Alexandrescu<andrei at erdani.com>
>    Date:   2011-09-04 (Sun, 04 Sep 2011)
>
>    Changed paths:
>      M std/conv.d
>    M std/format.d
>
>    Log Message:
>    -----------
>    Merge pull request #208 from 9rnsr/improve_unformat
>
> Improve value unformatting
>
>
> Compare: https://github.com/D-Programming-Language/phobos/compare/8535d7b...755b21f
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
>

On 9/4/2011 10:03 PM, Walter Bright wrote:
> This causes the std.conv unittests to fail on linux with a seg fault.
>

Please fix as this is blocking the beta.

On Sunday, September 04, 2011 22:03:52 Walter Bright wrote:
> This causes the std.conv unittests to fail on linux with a seg fault.

Kenji has been informed. He's looking into it. The interesting bit (IMHO) is that it's failing on 32-bit FreeBSD and 32-bit Linux and that's it. Mac OS X is fine, and 64-bit Linux is fine. That's an interesting combination. I definitely have to wonder what's causing it.

- Jonathan M Davis

On Sunday, September 04, 2011 22:12:35 Walter Bright wrote:
> On 9/4/2011 10:03 PM, Walter Bright wrote:
> > This causes the std.conv unittests to fail on linux with a seg fault.
> 
> Please fix as this is blocking the beta.

A fix has been merged in. It looks like std.conv.parse (which takes a string by ref) was accepting string literals and then segfaulting on them.

- Jonathan M Davis

Thanks for fixing it so quickly.

On 9/4/2011 10:31 PM, Jonathan M Davis wrote:
> On Sunday, September 04, 2011 22:12:35 Walter Bright wrote:
>> On 9/4/2011 10:03 PM, Walter Bright wrote:
>>> This causes the std.conv unittests to fail on linux with a seg fault.
>> Please fix as this is blocking the beta.
> A fix has been merged in. It looks like std.conv.parse (which takes a string by ref) was accepting string literals and then segfaulting on them.
>

On 9/4/2011 10:31 PM, Jonathan M Davis wrote:
> On Sunday, September 04, 2011 22:12:35 Walter Bright wrote:
>> On 9/4/2011 10:03 PM, Walter Bright wrote:
>>> This causes the std.conv unittests to fail on linux with a seg fault.
>>
>> Please fix as this is blocking the beta.
> 
> A fix has been merged in. It looks like std.conv.parse (which takes a string by ref) was accepting string literals and then segfaulting on them.
> 
> - Jonathan M Davis

This doesn't feel like a fix so much as a workaround.  It doesn't segfault, which is good, but it leaves the underlying problem ready to recur pretty easily.  Is there a problem with spec, the compiler implementation, phobos, ...?

Walter, this segfault is caused issue 4539.

In the past I had posted dmd patch #49, that is merged at one time,
but reverted because of 'breaking dmd test'.
After that, I posted pull request #164 with fixing dmd test, but it
has been left  two months.

Please merge it to prevent the same mistaken.

Kenji Hara

2011/9/5 Walter Bright <walter at digitalmars.com>:
> Thanks for fixing it so quickly.
>
> On 9/4/2011 10:31 PM, Jonathan M Davis wrote:
>>
>> On Sunday, September 04, 2011 22:12:35 Walter Bright wrote:
>>>
>>> On 9/4/2011 10:03 PM, Walter Bright wrote:
>>>>
>>>> This causes the std.conv unittests to fail on linux with a seg fault.
>>>
>>> Please fix as this is blocking the beta.
>>
>> A fix has been merged in. It looks like std.conv.parse (which takes a
>> string by
>> ref) was accepting string literals and then segfaulting on them.
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>

On Sunday, September 04, 2011 22:49:00 Brad Roberts wrote:
> On 9/4/2011 10:31 PM, Jonathan M Davis wrote:
> > On Sunday, September 04, 2011 22:12:35 Walter Bright wrote:
> >> On 9/4/2011 10:03 PM, Walter Bright wrote:
> >>> This causes the std.conv unittests to fail on linux with a seg fault.
> >> 
> >> Please fix as this is blocking the beta.
> > 
> > A fix has been merged in. It looks like std.conv.parse (which takes a string by ref) was accepting string literals and then segfaulting on them.
> > 
> > - Jonathan M Davis
> 
> This doesn't feel like a fix so much as a workaround.  It doesn't segfault, which is good, but it leaves the underlying problem ready to recur pretty easily.  Is there a problem with spec, the compiler implementation, phobos, ...?

It's a bug in dmd. string literals aren't lvalues and shouldn't be accepted as such. I thought that there was a bug reported specifically on this, but I don't see one at the moment. The closest that I see is

http://d.puremagic.com/issues/show_bug.cgi?id=4539

So, I should probably report it. What makes it nastier is that string literals aren't put in read-only memory on Windows, so they work in this sort of situation whereas on Linux, they blow up, since it _does_ put string literals in read-only memory.

- Jonathan M Davis

2011/9/5 kenji hara <k.hara.pg at gmail.com>:
> Walter, this segfault is caused issue 4539.

This segfault was caused by issue 4539.