Thread overview
[phobos] phobos commit, revision 1542
May 23, 2010
dsource.org
May 23, 2010
Brad Roberts
May 23, 2010
SHOO
May 22, 2010
phobos commit, revision 1542


user: SHOO

msg:
Mark deprecated to unittest

http://www.dsource.org/projects/phobos/changeset/1542

May 22, 2010
On 5/22/2010 7:07 PM, dsource.org wrote:
> phobos commit, revision 1542
> 
> 
> user: SHOO
> 
> msg:
> Mark deprecated to unittest
> 
> http://www.dsource.org/projects/phobos/changeset/1542
> 

General comment.. commit messages should explain 'why' not 'what'.  The 'what' part is obvious from the diff.  Does deprecate even make sense on unit tests? They don't to me.

May 23, 2010
Brad Roberts ????????:
> On 5/22/2010 7:07 PM, dsource.org wrote:
>> phobos commit, revision 1542
>>
>>
>> user: SHOO
>>
>> msg:
>> Mark deprecated to unittest
>>
>> http://www.dsource.org/projects/phobos/changeset/1542
>>
> 
> General comment.. commit messages should explain 'why' not 'what'.  The 'what' part is obvious from the diff.  Does deprecate even make sense on unit tests? They don't to me.

Because those unittest tests deprecated functions, I marked them with
deprecated.
If it does not do it like that, you could not compile unittest.

For example, It become like this:
$ dmd -I.. -c -o- -unittest -debug string.d
string.d(4058): Error: function std.string.find is deprecated