druntime commit, revision 488


user: andrei

msg:
.dup property for associative arrays

http://www.dsource.org/projects/druntime/changeset/488

paths changed:
U   trunk/import/object.di
U   trunk/src/object_.d

I like the change, I hate the commit.  Please try to avoid mixing massive whitespace changes with functional changes.

On 1/8/2011 11:59 AM, dsource.org wrote:
> druntime commit, revision 488
> 
> 
> user: andrei
> 
> msg:
> .dup property for associative arrays
> 
> http://www.dsource.org/projects/druntime/changeset/488
> 
> paths changed:
> U   trunk/import/object.di
> U   trunk/src/object_.d
> 

And now that the tester is breaking on the change, I like it less. :)

I don't understand why it's breaking, but:

Linux32:
../../druntime/import/object.di(417): Error: result[k] isn't mutable

Win32:
C:\cygwin\home\braddr\sandbox\d\d-tester\client\5578\dmd\src\..\..\druntime\import\object.di(417):
Error: result[k] isn't mutable
std\xml.d(795): Error: function std.xml.ElementParser.onText (void
delegate(string) handler) is not callable using argument types (_error_
delegate(string s))
std\xml.d(795): Error: cannot implicitly convert expression (__dgliteral166) of
type _error_ delegate(string s) to void delegate(string)
std\xml.d(796): Error: function std.xml.ElementParser.onCData (void
delegate(string) handler) is not callable using argument types (_error_
delegate(string s))
std\xml.d(796): Error: cannot implicitly convert expression (__dgliteral167) of
type _error_ delegate(string s) to void delegate(string)
std\xml.d(797): Error: function std.xml.ElementParser.onComment (void
delegate(string) handler) is not callable using argument types (_error_
delegate(string s))
std\xml.d(797): Error: cannot implicitly convert expression (__dgliteral168) of
type _error_ delegate(string s) to void delegate(string)
std\xml.d(798): Error: function std.xml.ElementParser.onPI (void
delegate(string) handler) is not callable using argument types (_error_
delegate(string s))
std\xml.d(798): Error: cannot implicitly convert expression (__dgliteral169) of
type _error_ delegate(string s) to void delegate(string)
std\xml.d(800): Error: cannot implicitly convert expression (__dgliteral170) of
type _error_ delegate(ElementParser xml) to void delegate(ElementParser parser)


On 1/8/2011 12:06 PM, Brad Roberts wrote:
> I like the change, I hate the commit.  Please try to avoid mixing massive whitespace changes with functional changes.
> 
> On 1/8/2011 11:59 AM, dsource.org wrote:
>> druntime commit, revision 488
>>
>>
>> user: andrei
>>
>> msg:
>> .dup property for associative arrays
>>
>> http://www.dsource.org/projects/druntime/changeset/488
>>
>> paths changed:
>> U   trunk/import/object.di
>> U   trunk/src/object_.d
>>
> 

Andrei, any luck on fixing the problem?  If not, I suggest reverting until it's understood.

On 1/8/2011 1:27 PM, Brad Roberts wrote:
> And now that the tester is breaking on the change, I like it less. :)
> 
> I don't understand why it's breaking, but:
> 
> Linux32:
> ../../druntime/import/object.di(417): Error: result[k] isn't mutable
> 
> Win32:
> C:\cygwin\home\braddr\sandbox\d\d-tester\client\5578\dmd\src\..\..\druntime\import\object.di(417):
> Error: result[k] isn't mutable
> std\xml.d(795): Error: function std.xml.ElementParser.onText (void
> delegate(string) handler) is not callable using argument types (_error_
> delegate(string s))
> std\xml.d(795): Error: cannot implicitly convert expression (__dgliteral166) of
> type _error_ delegate(string s) to void delegate(string)
> std\xml.d(796): Error: function std.xml.ElementParser.onCData (void
> delegate(string) handler) is not callable using argument types (_error_
> delegate(string s))
> std\xml.d(796): Error: cannot implicitly convert expression (__dgliteral167) of
> type _error_ delegate(string s) to void delegate(string)
> std\xml.d(797): Error: function std.xml.ElementParser.onComment (void
> delegate(string) handler) is not callable using argument types (_error_
> delegate(string s))
> std\xml.d(797): Error: cannot implicitly convert expression (__dgliteral168) of
> type _error_ delegate(string s) to void delegate(string)
> std\xml.d(798): Error: function std.xml.ElementParser.onPI (void
> delegate(string) handler) is not callable using argument types (_error_
> delegate(string s))
> std\xml.d(798): Error: cannot implicitly convert expression (__dgliteral169) of
> type _error_ delegate(string s) to void delegate(string)
> std\xml.d(800): Error: cannot implicitly convert expression (__dgliteral170) of
> type _error_ delegate(ElementParser xml) to void delegate(ElementParser parser)
> 
> 
> On 1/8/2011 12:06 PM, Brad Roberts wrote:
>> I like the change, I hate the commit.  Please try to avoid mixing massive whitespace changes with functional changes.
>>
>> On 1/8/2011 11:59 AM, dsource.org wrote:
>>> druntime commit, revision 488
>>>
>>>
>>> user: andrei
>>>
>>> msg:
>>> .dup property for associative arrays
>>>
>>> http://www.dsource.org/projects/druntime/changeset/488
>>>
>>> paths changed:
>>> U   trunk/import/object.di
>>> U   trunk/src/object_.d
>>>
>>
> 
> _______________________________________________
> D-runtime mailing list
> D-runtime at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/d-runtime