Thread overview | |||||||
---|---|---|---|---|---|---|---|
|
September 05, 2011 [phobos] [D-Programming-Language/phobos] 152191: Revert "Improve error message" | ||||
---|---|---|---|---|
| ||||
Branch: refs/heads/master Home: https://github.com/D-Programming-Language/phobos Commit: 152191c4891bf6f6d623a308e81a5d5ac43481cb https://github.com/D-Programming-Language/phobos/commit/152191c4891bf6f6d623a308e81a5d5ac43481cb Author: jmdavis <jmdavisProg at gmx.com> Date: 2011-09-05 (Mon, 05 Sep 2011) Changed paths: M std/conv.d Log Message: ----------- Revert "Improve error message" This reverts commit 8e41c856e172e69b1a75aa1698ebabd9f1d422ac. |
September 05, 2011 [phobos] [D-Programming-Language/phobos] 152191: Revert "Improve error message" | ||||
---|---|---|---|---|
| ||||
Posted in reply to noreply at github.com | Does this have to do with http://d.puremagic.com/issues/show_bug.cgi?id=6606? On 9/5/2011 2:11 AM, noreply at github.com wrote: > Branch: refs/heads/master > Home: https://github.com/D-Programming-Language/phobos > > Commit: 152191c4891bf6f6d623a308e81a5d5ac43481cb > https://github.com/D-Programming-Language/phobos/commit/152191c4891bf6f6d623a308e81a5d5ac43481cb > Author: jmdavis<jmdavisProg at gmx.com> > Date: 2011-09-05 (Mon, 05 Sep 2011) > > Changed paths: > M std/conv.d > > Log Message: > ----------- > Revert "Improve error message" > > This reverts commit 8e41c856e172e69b1a75aa1698ebabd9f1d422ac. > > > _______________________________________________ > phobos mailing list > phobos at puremagic.com > http://lists.puremagic.com/mailman/listinfo/phobos > > |
September 05, 2011 [phobos] [D-Programming-Language/phobos] 152191: Revert "Improve error message" | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | On Monday, September 05, 2011 23:24:43 Walter Bright wrote:
> Does this have to do with http://d.puremagic.com/issues/show_bug.cgi?id=6606?
No. It was an adjustment to some error messages only. The resultant code ended up with if statements with statically-known values under some conditions, which resulted in unreachable code, which then didn't compile (the Windows unittest builds weren't being compiled with -w before, which is why Kenji didn't catch it). The changes have been completed reverted, and a new pull request which doesn't have the problem has been created (but not merged in).
- Jonathan M Davis
|
September 06, 2011 [phobos] [D-Programming-Language/phobos] 152191: Revert "Improve error message" | ||||
---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | Now I works to fix it. Please wait a moment.
Kenji Hara
2011/9/6 Walter Bright <walter at digitalmars.com>:
> Does this have to do with http://d.puremagic.com/issues/show_bug.cgi?id=6606?
>
>
> On 9/5/2011 2:11 AM, noreply at github.com wrote:
>>
>> ? Branch: refs/heads/master
>> ? Home: ? https://github.com/D-Programming-Language/phobos
>>
>> ? Commit: 152191c4891bf6f6d623a308e81a5d5ac43481cb
>>
>> https://github.com/D-Programming-Language/phobos/commit/152191c4891bf6f6d623a308e81a5d5ac43481cb
>> ? Author: jmdavis<jmdavisProg at gmx.com>
>> ? Date: ? 2011-09-05 (Mon, 05 Sep 2011)
>>
>> ? Changed paths:
>> ? ? M std/conv.d
>>
>> ? Log Message:
>> ? -----------
>> ? Revert "Improve error message"
>>
>> This reverts commit 8e41c856e172e69b1a75aa1698ebabd9f1d422ac.
>>
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
|
September 06, 2011 [phobos] [D-Programming-Language/phobos] 152191: Revert "Improve error message" | ||||
---|---|---|---|---|
| ||||
Posted in reply to kenji hara | Posted pull request. https://github.com/D-Programming-Language/phobos/pull/242 Kenji Hara 2011/9/6 kenji hara <k.hara.pg at gmail.com>: > Now I works to fix it. Please wait a moment. > > Kenji Hara > > 2011/9/6 Walter Bright <walter at digitalmars.com>: >> Does this have to do with http://d.puremagic.com/issues/show_bug.cgi?id=6606? >> >> >> On 9/5/2011 2:11 AM, noreply at github.com wrote: >>> >>> ? Branch: refs/heads/master >>> ? Home: ? https://github.com/D-Programming-Language/phobos >>> >>> ? Commit: 152191c4891bf6f6d623a308e81a5d5ac43481cb >>> >>> https://github.com/D-Programming-Language/phobos/commit/152191c4891bf6f6d623a308e81a5d5ac43481cb >>> ? Author: jmdavis<jmdavisProg at gmx.com> >>> ? Date: ? 2011-09-05 (Mon, 05 Sep 2011) >>> >>> ? Changed paths: >>> ? ? M std/conv.d >>> >>> ? Log Message: >>> ? ----------- >>> ? Revert "Improve error message" >>> >>> This reverts commit 8e41c856e172e69b1a75aa1698ebabd9f1d422ac. >>> >>> >>> _______________________________________________ >>> phobos mailing list >>> phobos at puremagic.com >>> http://lists.puremagic.com/mailman/listinfo/phobos >>> >>> >> _______________________________________________ >> phobos mailing list >> phobos at puremagic.com >> http://lists.puremagic.com/mailman/listinfo/phobos >> > |
Copyright © 1999-2021 by the D Language Foundation