Thread overview
[phobos] [D-Programming-Language/phobos] 25df7d: Fix build breakage due to std.zlib changes.
Nov 06, 2011
Jonathan M Davis
Nov 06, 2011
Brad Roberts
Nov 06, 2011
Jonathan M Davis
November 06, 2011
On Sunday, November 06, 2011 01:02:20 noreply at github.com wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/phobos
> 
>   Commit: 25df7d748b35eb623d06f9d3180d84cde302afc7
> 
> https://github.com/D-Programming-Language/phobos/commit/25df7d748b35eb623d0
> 6f9d3180d84cde302afc7 Author: jmdavis <jmdavisProg at gmx.com>
>   Date:   2011-11-06 (Sun, 06 Nov 2011)
> 
>   Changed paths:
>     M std/zlib.d
> 
>   Log Message:
>   -----------
>   Fix build breakage due to std.zlib changes.
> 
> 
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

Obviously, either e-mail in general doesn't embed its time in UTC, or my e- mail reader isn't smart about how it sorts time, because it's sorting the fix as being _before_ the commit which broke the build, due to the fact that my e- mail was sent right after a DST switch.

Ah, the wonders of DST. If only it could just be completely abolished. Dealing with time and computers would be _so_ much easier.

- Jonathan M Davis
November 06, 2011
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos

  Commit: 25df7d748b35eb623d06f9d3180d84cde302afc7
      https://github.com/D-Programming-Language/phobos/commit/25df7d748b35eb623d06f9d3180d84cde302afc7
  Author: jmdavis <jmdavisProg at gmx.com>
  Date:   2011-11-06 (Sun, 06 Nov 2011)

  Changed paths:
    M std/zlib.d

  Log Message:
  -----------
  Fix build breakage due to std.zlib changes.


November 06, 2011
On 11/6/2011 1:12 AM, Jonathan M Davis wrote:
> Obviously, either e-mail in general doesn't embed its time in UTC, or my e- mail reader isn't smart about how it sorts time, because it's sorting the fix as being _before_ the commit which broke the build, due to the fact that my e- mail was sent right after a DST switch.
> 
> Ah, the wonders of DST. If only it could just be completely abolished. Dealing with time and computers would be _so_ much easier.
> 
> - Jonathan M Davis

Similarly, the auto-tester builds are oddly ordered since they are sorted by time.  Also time is used to determine when the most recent run is out of date compared to the most recent commit.

I'll manually kick off a set of builds after 2am to make sure it's all unraveled.

Later,
Brad
November 06, 2011
On Sunday, November 06, 2011 02:01:15 Brad Roberts wrote:
> On 11/6/2011 1:12 AM, Jonathan M Davis wrote:
> > Obviously, either e-mail in general doesn't embed its time in UTC, or my e- mail reader isn't smart about how it sorts time, because it's sorting the fix as being _before_ the commit which broke the build, due to the fact that my e- mail was sent right after a DST switch.
> > 
> > Ah, the wonders of DST. If only it could just be completely abolished. Dealing with time and computers would be _so_ much easier.
> > 
> > - Jonathan M Davis
> 
> Similarly, the auto-tester builds are oddly ordered since they are sorted by time.  Also time is used to determine when the most recent run is out of date compared to the most recent commit.
> 
> I'll manually kick off a set of builds after 2am to make sure it's all unraveled.

Well, all in all, it's an example of why std.datetime.SysTime holds its time in UTC and does all comparisons with that value with no regards to time zone such that it's only when presenting its value does it convert it to the appopriate time zone (e.g. when converting to a string). DST tends to screw up all kinds of stuff for programs dealing with time.

- Jonathan M Davis