Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: 852708e953b851cc03acf3e2b659ba0e476050bf
      https://github.com/D-Programming-Language/dmd/commit/852708e953b851cc03acf3e2b659ba0e476050bf
  Author: Walter Bright <walter@walterbright.com>
  Date:   2012-06-01 (Fri, 01 Jun 2012)

  Changed paths:
    M src/backend/cc.h
    M src/backend/cdef.h
    M src/backend/cgcod.c
    M src/backend/cod1.c
    M src/backend/cod3.c
    M src/backend/code.h
    M src/backend/nteh.c
    M src/backend/out.c
    M src/backend/var.c

  Log Message:
  -----------
  more 2 register parameter support

Um... seems to have had a rather disastrous effect on every platform.

On 6/1/2012 7:20 PM, GitHub wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/dmd
>   Commit: 852708e953b851cc03acf3e2b659ba0e476050bf
>       https://github.com/D-Programming-Language/dmd/commit/852708e953b851cc03acf3e2b659ba0e476050bf
>   Author: Walter Bright <walter@walterbright.com>
>   Date:   2012-06-01 (Fri, 01 Jun 2012)
> 
>   Changed paths:
>     M src/backend/cc.h
>     M src/backend/cdef.h
>     M src/backend/cgcod.c
>     M src/backend/cod1.c
>     M src/backend/cod3.c
>     M src/backend/code.h
>     M src/backend/nteh.c
>     M src/backend/out.c
>     M src/backend/var.c
> 
>   Log Message:
>   -----------
>   more 2 register parameter support
> 

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Obvious fixes in:
  https://github.com/D-Programming-Language/dmd/pull/978

What sort of testing passed for this commit?

On 6/1/2012 7:57 PM, Brad Roberts wrote:
> Um... seems to have had a rather disastrous effect on every platform.
> 
> On 6/1/2012 7:20 PM, GitHub wrote:
>>   Branch: refs/heads/master
>>   Home:   https://github.com/D-Programming-Language/dmd
>>   Commit: 852708e953b851cc03acf3e2b659ba0e476050bf
>>       https://github.com/D-Programming-Language/dmd/commit/852708e953b851cc03acf3e2b659ba0e476050bf
>>   Author: Walter Bright <walter@walterbright.com>
>>   Date:   2012-06-01 (Fri, 01 Jun 2012)
>>
>>   Changed paths:
>>     M src/backend/cc.h
>>     M src/backend/cdef.h
>>     M src/backend/cgcod.c
>>     M src/backend/cod1.c
>>     M src/backend/cod3.c
>>     M src/backend/code.h
>>     M src/backend/nteh.c
>>     M src/backend/out.c
>>     M src/backend/var.c
>>
>>   Log Message:
>>   -----------
>>   more 2 register parameter support
>>
> 
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On Friday, June 01, 2012 21:45:13 Brad Roberts wrote:
> Obvious fixes in:
>   https://github.com/D-Programming-Language/dmd/pull/978
> 
> What sort of testing passed for this commit?

Given that _everything_ other than the dmd build itself failed, that would imply that either Walter didn't try and build anything other than dmd, let alone run any of the tests, or he didn't commit all of the changes that he made.

- Jonathan M Davis
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 6/1/2012 9:50 PM, Jonathan M Davis wrote:
> On Friday, June 01, 2012 21:45:13 Brad Roberts wrote:
>> Obvious fixes in:
>>    https://github.com/D-Programming-Language/dmd/pull/978
>>
>> What sort of testing passed for this commit?
> Given that _everything_ other than the dmd build itself failed, that would
> imply that either Walter didn't try and build anything other than dmd, let
> alone run any of the tests, or he didn't commit all of the changes that he
> made.
>

Reason #3.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

It still puzzles me how reason #3 is so common. How is it that changes get missed? Do you run "git status" when preparing commits and when preparing to push your changes? I'm wondering if there are simple things like customizing .gitignore or adding colors to the status output that could make #3 less common.

Sent from my iPhone

On Jun 2, 2012, at 1:55 AM, Walter Bright <walter@digitalmars.com> wrote:

> 
> 
> On 6/1/2012 9:50 PM, Jonathan M Davis wrote:
>> On Friday, June 01, 2012 21:45:13 Brad Roberts wrote:
>>> Obvious fixes in:
>>>   https://github.com/D-Programming-Language/dmd/pull/978
>>> 
>>> What sort of testing passed for this commit?
>> Given that _everything_ other than the dmd build itself failed, that would imply that either Walter didn't try and build anything other than dmd, let alone run any of the tests, or he didn't commit all of the changes that he made.
>> 
> 
> Reason #3.
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 2 jun 2012, at 14:26, Jason House wrote:

> It still puzzles me how reason #3 is so common. How is it that changes get missed? Do you run "git status" when preparing commits and when preparing to push your changes? I'm wondering if there are simple things like customizing .gitignore or adding colors to the status output that could make #3 less common.


I commit most of the times with

$ git commit -a

Which will add all changes to all files which git is already tracking. It won't add new files. I also have color enabled for diffs and status.

This is how my .gitconfig looks like:

http://pastebin.com/gcKmrwCi

-- 
/Jacob Carlborg

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Jacob Carlborg, el  2 de junio a las 15:14 me escribiste:
> 
> On 2 jun 2012, at 14:26, Jason House wrote:
> 
> > It still puzzles me how reason #3 is so common. How is it that changes get missed? Do you run "git status" when preparing commits and when preparing to push your changes? I'm wondering if there are simple things like customizing .gitignore or adding colors to the status output that could make #3 less common.
> 
> 
> I commit most of the times with
> 
> $ git commit -a
> 
> Which will add all changes to all files which git is already tracking. It won't add new files. I also have color enabled for diffs and status.
> 
> This is how my .gitconfig looks like:
> 
> http://pastebin.com/gcKmrwCi

A very handy trick if you use bash (probably works with other shells too) and have auto completion enabled is to use __git_ps1 in your $PS1 configuration. For example using GIT_PS1_SHOWUNTRACKEDFILES=1, a '%' symbol is shown in the prompt if there are untracked files.

For example, I'm using this (colorful) prompt:
# make git prompt more verbose
export GIT_PS1_SHOWDIRTYSTATE=1 GIT_PS1_SHOWSTASHSTATE=1 \
        GIT_PS1_SHOWUNTRACKEDFILES=1 GIT_PS1_SHOWUPSTREAM=auto,verbose
PS1='\[\033[00;34m\]\u\[\033[00m\]\[\033[00;33m\]@\[\033[00m\]\[\033[00;36m\]\h\[\033[00m\]\[\033[00;33m\]:\[\033[00;32m\]\w$(__git_ps1
"\[\033[00m\]\[\033[00;33m\]:\[\033[00m\]\[\033[00;36m\]%s")\[\033[00m\]\[\033[00;33m\]\$\[\033[00m\]

For me is a life-changing feature...

More info in the bash completion file itself: https://github.com/git/git/blob/master/contrib/completion/git-completion.bash

-- 
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Si pensas que el alma no se ve
El alma sí se ve y puede combinar muy bien
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals