Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.

Sent from my iPhone

On Sep 4, 2010, at 1:38 PM, Brad Roberts <braddr at puremagic.com> wrote:

> On 9/4/2010 1:19 PM, Rainer Schuetze wrote:
>> Walter Bright wrote:
>>> 
>>> 
>>> Rainer Schuetze wrote:
>>>> 
>>>> I've also tried to make the test suite run under windows (after several other tries, MSys seems to be the best shot). I patched some of the scripts before I realized that it is way easier to just fix the file name handling of dmd and optlink. With this simple patch:
>>>> 
>>> 
>>> I generally try to avoid things like this. They always seem to cause trouble one way or another, and then one is stuck with it because too much has grown to depend on the hack.
>> The trouble is happening now, with dmd (correctly) accepting file names with forward slashes, but only converting the object file names to containing backward slashes for optlink. With the first patch that problem should go away without side effects.
>> 
>> I agree the second patch (using forward slashes for source references) can have a bit more dependencies. But the current output might need some clarification anyway. E.g. filenames in dependency files and JSON files have duplicate back slashes on windows. According to the reference files in the test suite, JSON output on linux contains file names with "\/" in them.
> 
> I have the test suite generally working on windows under cygwin without patching dmd (though, I actually think that's a really clever idea and am a little surprised that I didn't think of it too).
> 
> The test script itself swaps over to \ for the dmd command line, but uses / everywhere else.  As you discovered, some tests output paths, specifically the cov and profile related tests.  I changed the post-script's for those to exclude the line that contains the path.
> 
> For those of you who regularly develop on windows, is running it under cygwin something that you object to enough to not do it?  I suspect Walter's answer is yes.  How about the rest?
> 
> The main reason I haven't checked it in yet is that when I synced up everything to do a last full test, I hit several test failures that have crept in recently. I filed regression bugs for them.  I also haven't taken my changes back to linux to make sure I didn't break anything there.
> 
> Regression bugs:
>  http://d.puremagic.com/issues/show_bug.cgi?id=4795
>  http://d.puremagic.com/issues/show_bug.cgi?id=4797
> 
> There was another, but it's already been addressed.
> 
> I'm going to work on the first one there today.  It shouldn't be too hard, but I haven't looked at the new demangling code yet.
> 
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 9/4/2010 3:24 PM, Sean Kelly wrote:
> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
> 

I just ran the druntime unit test and the demangle tests fail there too.

http://d.puremagic.com/issues/show_bug.cgi?id=4795

Rainer Schuetze wrote:
>
> I agree the second patch (using forward slashes for source references) can have a bit more dependencies. But the current output might need some clarification anyway. E.g. filenames in dependency files and JSON files have duplicate back slashes on windows. According to the reference files in the test suite, JSON output on linux contains file names with "\/" in them.
>

Those sound like bugs.

On Sep 4, 2010, at 3:36 PM, Brad Roberts wrote:

> On 9/4/2010 3:24 PM, Sean Kelly wrote:
>> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
>> 
> 
> I just ran the druntime unit test and the demangle tests fail there too.
> 
> http://d.puremagic.com/issues/show_bug.cgi?id=4795

That's what I get for not testing it with zero-length input.  I'll give it a look tonight.

On Sep 4, 2010, at 4:45 PM, Sean Kelly wrote:

> On Sep 4, 2010, at 3:36 PM, Brad Roberts wrote:
> 
>> On 9/4/2010 3:24 PM, Sean Kelly wrote:
>>> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
>>> 
>> 
>> I just ran the druntime unit test and the demangle tests fail there too.
>> 
>> http://d.puremagic.com/issues/show_bug.cgi?id=4795
> 
> That's what I get for not testing it with zero-length input.  I'll give it a look tonight.

Darnit, I can't reproduce any of these on OSX.

On Sep 4, 2010, at 9:13 PM, Sean Kelly wrote:

> On Sep 4, 2010, at 4:45 PM, Sean Kelly wrote:
> 
>> On Sep 4, 2010, at 3:36 PM, Brad Roberts wrote:
>> 
>>> On 9/4/2010 3:24 PM, Sean Kelly wrote:
>>>> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
>>>> 
>>> 
>>> I just ran the druntime unit test and the demangle tests fail there too.
>>> 
>>> http://d.puremagic.com/issues/show_bug.cgi?id=4795
>> 
>> That's what I get for not testing it with zero-length input.  I'll give it a look tonight.
> 
> Darnit, I can't reproduce any of these on OSX.

Okay, I think the issue is that static data isn't in ROM on OSX, so throwing classinfo.init for onOutOfMemoryError doesn't break the chaining code as-is.  I'll sort out chaining and with luck that will fix everything.

On 9/5/2010 7:15 AM, Sean Kelly wrote:
> On Sep 4, 2010, at 9:13 PM, Sean Kelly wrote:
> 
>> On Sep 4, 2010, at 4:45 PM, Sean Kelly wrote:
>> 
>>> On Sep 4, 2010, at 3:36 PM, Brad Roberts wrote:
>>> 
>>>> On 9/4/2010 3:24 PM, Sean Kelly wrote:
>>>>> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
>>>>> 
>>>> 
>>>> I just ran the druntime unit test and the demangle tests fail there too.
>>>> 
>>>> http://d.puremagic.com/issues/show_bug.cgi?id=4795
>>> 
>>> That's what I get for not testing it with zero-length input.  I'll give it a look tonight.
>> 
>> Darnit, I can't reproduce any of these on OSX.
> 
> Okay, I think the issue is that static data isn't in ROM on OSX, so throwing classinfo.init for onOutOfMemoryError doesn't break the chaining code as-is. I'll sort out chaining and with luck that will fix everything.

Looks like druntime r384 and 385 have fixed the test failures.  Clearly visible here:

    http://d.puremagic.com/test-results/index.ghtml

Do you consider the fix temporary or should bugs 4795 and 4797 be closed?

Thanks,
Brad

On Sep 5, 2010, at 12:46 PM, Brad Roberts wrote:

> On 9/5/2010 7:15 AM, Sean Kelly wrote:
>> On Sep 4, 2010, at 9:13 PM, Sean Kelly wrote:
>> 
>>> On Sep 4, 2010, at 4:45 PM, Sean Kelly wrote:
>>> 
>>>> On Sep 4, 2010, at 3:36 PM, Brad Roberts wrote:
>>>> 
>>>>> On 9/4/2010 3:24 PM, Sean Kelly wrote:
>>>>>> Other, I thought Walter had reverted all of the auto-chaining code. If not, that would explain the second bug. Easy fix.
>>>>>> 
>>>>> 
>>>>> I just ran the druntime unit test and the demangle tests fail there too.
>>>>> 
>>>>> http://d.puremagic.com/issues/show_bug.cgi?id=4795
>>>> 
>>>> That's what I get for not testing it with zero-length input.  I'll give it a look tonight.
>>> 
>>> Darnit, I can't reproduce any of these on OSX.
>> 
>> Okay, I think the issue is that static data isn't in ROM on OSX, so throwing classinfo.init for onOutOfMemoryError doesn't break the chaining code as-is. I'll sort out chaining and with luck that will fix everything.
> 
> Looks like druntime r384 and 385 have fixed the test failures.  Clearly visible here:
> 
>    http://d.puremagic.com/test-results/index.ghtml
> 
> Do you consider the fix temporary or should bugs 4795 and 4797 be closed?

If they fix the issue then the bugs can be closed.  I just hadn't gotten around to testing the fix yet.