Thread overview
[dmd-internals] [D-Programming-Language/dmd] f70793: Merge pull request #281 from 9rnsr/fix4773
Jul 30, 2011
Michel Fortin
Jul 30, 2011
Walter Bright
Jul 30, 2011
Michel Fortin
Jul 30, 2011
Walter Bright
July 30, 2011
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd

  Commit: f70793ba34e4c4365eda7a33e3c073a7b13002a6
      https://github.com/D-Programming-Language/dmd/commit/f70793ba34e4c4365eda7a33e3c073a7b13002a6
  Author: Walter Bright <walter at walterbright.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M src/expression.c
  M test/runnable/aliasthis.d

  Log Message:
  -----------
  Merge pull request #281 from 9rnsr/fix4773

Issue 4773 - Rebindable should be castable to bool


July 30, 2011
Le 2011-07-30 ? 5:39, noreply at github.com a ?crit :

> Issue 4773 - Rebindable should be castable to bool


Sure, it's a good thing that this get fixed. But speaking of improving rebindable object reference, it'd be nice if Walter could find some time to take a closer look at the const(Object)ref pull request, which has been waiting in the pipeline for almost six months now. :-)

<https://github.com/D-Programming-Language/dmd/pull/3>


-- 
Michel Fortin
michel.fortin at michelf.com
http://michelf.com/



July 30, 2011
I was going to do the easy ones first!

On 7/30/2011 5:57 AM, Michel Fortin wrote:
> Le 2011-07-30 ? 5:39, noreply at github.com a ?crit :
>
>> Issue 4773 - Rebindable should be castable to bool
>
> Sure, it's a good thing that this get fixed. But speaking of improving rebindable object reference, it'd be nice if Walter could find some time to take a closer look at the const(Object)ref pull request, which has been waiting in the pipeline for almost six months now. :-)
>
> <https://github.com/D-Programming-Language/dmd/pull/3>
>
>
July 30, 2011
Le 2011-07-30 ? 13:35, Walter Bright a ?crit :

> I was going to do the easy ones first!

Then it seems that this rate you'll never look at it since the number of easy requests is always increasing.

We're currently at 283 pull requests total (both open and closed), only for DMD, which is about 47 a month on average, and the number of open requests seems to be increasing from month to month. How'll you cope?

Anyway, I actually think the biggest issues should be fixed first. By fixing the easiest bugs first, you're allowing the bigger issues to stand out. I'm sure it'd make more people happy to have const(Object)ref working rather than having Rebindable implicitly casted to bool. Although I agree the later deserved to be fixed too, it simply has much less impact on people's code.

-- 
Michel Fortin
michel.fortin at michelf.com
http://michelf.com/



July 30, 2011

On 7/30/2011 11:43 AM, Michel Fortin wrote:
> Le 2011-07-30 ? 13:35, Walter Bright a ?crit :
>
>> I was going to do the easy ones first!
> Then it seems that this rate you'll never look at it since the number of easy requests is always increasing.
>
> We're currently at 283 pull requests total (both open and closed), only for DMD, which is about 47 a month on average, and the number of open requests seems to be increasing from month to month. How'll you cope?
>
> Anyway, I actually think the biggest issues should be fixed first. By fixing the easiest bugs first, you're allowing the bigger issues to stand out. I'm sure it'd make more people happy to have const(Object)ref working rather than having Rebindable implicitly casted to bool. Although I agree the later deserved to be fixed too, it simply has much less impact on people's code.
>

I tend to fix the easy ones first as it has a way of clearing my mind to work more effectively on the bigger ones.