Hi Andrew,

You just pushed a number of commits directly to D-Programming-Language/phobos@master. Please don't do that without going through review (pull requests) first, especially because it's easy to accidentally break the auto-tester build this way.

If you are unsure as to why this happened, feel free to ask for help (and maybe consider configuring your local Git clone so you can't directly push to the main repository at all).

David
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

2014-06-30 2:33 GMT+09:00 David Nadlinger via phobos <phobos@puremagic.com>:

> Hi Andrew,
>
> You just pushed a number of commits directly to D-Programming-Language/phobos@master. Please don't do that without going through review (pull requests) first, especially because it's easy to accidentally break the auto-tester build this way.
>
> If you are unsure as to why this happened, feel free to ask for help (and maybe consider configuring your local Git clone so you can't directly push to the main repository at all).
>
> David
>

And, his direct pushing had _actually_ broke my regression fix.
To fix it again, I opened a new pull request, and toggled on its auto-merge
flag.

https://github.com/D-Programming-Language/phobos/pull/2286

Kenji Hara

[I accidentally replied off-list earlier, see below.]

Sure, you're welcome.

And apologies for being a bit blunt before. It's just that we historically haven't been the best at avoiding Git accidents, even though we have Brad's awesome tools at our disposal.

Best,
David



On 1 Jul 2014, at 23:26, Andrew Edwards wrote:
> On 7/2/14, 6:14 AM, David Nadlinger wrote:
>> On 1 Jul 2014, at 23:05, Andrew Edwards wrote:
>>> I have created the 2.066 branch in my fork and am trying to make a pull request for it. This is not possible because there is absolutely no difference between the branched code and master. What is your proposal for accomplishing this?
>>
>> For creating the branch, you need to push it directly to the D-Programming-Language repository – at least I don't of any other way.
>>
>> However, creating a branch isn't a dangerous thing to do anyway. If I started to randomly create branches in the shared repository, I'd probably start to annoy the other devs rather quickly just because of the mess I'd create and the GitHub notifications triggered by that. Still, I wouldn't run any risk of directly hampering their work.
>>
>> It's just directly modifying master that is dangerous, because everybody depends on it for pull requests and the auto-tester.
>>
>> Best,
>> David
> Thanks. Just wanted to make sure I'm not causing any issues.
>
> Regards,
> Andrew
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos