Thread overview
[phobos] [D-Programming-Language/phobos] 6e053f: Changelog should say std.file.tempDir
May 04, 2012
GitHub
May 04, 2012
Jonathan M Davis
May 04, 2012
Jonathan M Davis
May 03, 2012
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 6e053f32916078cdf6d1b532960fb624422e060f
      https://github.com/D-Programming-Language/phobos/commit/6e053f32916078cdf6d1b532960fb624422e060f
  Author: Lars T. Kyllingstad <git@kyllingen.net>
  Date:   2012-05-03 (Thu, 03 May 2012)

  Changed paths:
    M changelog.dd

  Log Message:
  -----------
  Changelog should say std.file.tempDir





May 03, 2012
On Thursday, May 03, 2012 23:14:29 GitHub wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/phobos
>   Commit: 6e053f32916078cdf6d1b532960fb624422e060f
> 
> https://github.com/D-Programming-Language/phobos/commit/6e053f32916078cdf6d
> 1b532960fb624422e060f Author: Lars T. Kyllingstad <git@kyllingen.net>
>   Date:   2012-05-03 (Thu, 03 May 2012)
> 
>   Changed paths:
>     M changelog.dd
> 
>   Log Message:
>   -----------
>   Changelog should say std.file.tempDir

LOL. You're right. I guess that I just associated you with std.path too much... :)

- Jonathan M Davis
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

May 04, 2012
On 04/05/12 08:16, Jonathan M Davis wrote:
> On Thursday, May 03, 2012 23:14:29 GitHub wrote:
>>    Branch: refs/heads/master
>>    Home:   https://github.com/D-Programming-Language/phobos
>>    Commit: 6e053f32916078cdf6d1b532960fb624422e060f
>>
>> https://github.com/D-Programming-Language/phobos/commit/6e053f32916078cdf6d
>> 1b532960fb624422e060f Author: Lars T. Kyllingstad<git@kyllingen.net>
>>    Date:   2012-05-03 (Thu, 03 May 2012)
>>
>>    Changed paths:
>>      M changelog.dd
>>
>>    Log Message:
>>    -----------
>>    Changelog should say std.file.tempDir
>
> LOL. You're right. I guess that I just associated you with std.path too
> much... :)

:D

I was actually a bit surprised there was no discussion in the pull request of what would be the best location for this function.  I chose std.file because tempDir's main purpose is to perform a bunch of filesystem lookups and return the first one that succeeds, and not path string manipulation as such.

-Lars
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

May 03, 2012
On Friday, May 04, 2012 08:21:26 Lars Tandle Kyllingstad wrote:
> I was actually a bit surprised there was no discussion in the pull request of what would be the best location for this function.  I chose std.file because tempDir's main purpose is to perform a bunch of filesystem lookups and return the first one that succeeds, and not path string manipulation as such.

I think that it's pretty clear that it belongs in std.file, since it's operating on the file system rather than just paths, but it wouldn't have surprised me to have someone bring that up.

- Jonathan M Davis
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos