Don Clugston wrote:
> Excellent! That's #1 from my list of the worst bugs.
>
> There are just two patches I'd like to see in the next release:
> * Brad's patch for arguably the worst wrong-code bug:
> 2127 inliner turns struct "return *this" from by-value into by-ref
>
> *And this simple compiler fault found by a newbie, which is a very
> recent regression:
> 4242 ICE(module.c): importing a module with same name as package
>
> ---

I've got these done, but dsource is down and I can't check in.

(replying off list on purpose)

On 5/29/2010 1:31 PM, Don Clugston wrote:
> On 29 May 2010 02:57, Brad Roberts <braddr at puremagic.com> wrote:
>> Excellent.  And if I might suggest 2 more goals for the next release:
>>
>>  1) close out at least 10 bugs that have patches
> 
> Since the goal seems to be to encourage community involvement, I'd change that to:

I'm trying to train Walter as much as the community.  He needs to actively work to favor patches (regardless of who they're from) over doing it himself.  He knows he's set in his ways and that they aren't the best nor that they'll be sustainable.  So, hopefully these periodic gentle nudges will help him evolve his processes some.  That and the occasional in-person application of a sufficiently hard smack upside the head. :)

That said, I do agree with your change of goals.  All things being equal, I'd like to see them coming from as broad a collection of people as possible.

Lastly, I did spend some time looking at bug 3516 (the struct dtor bug) this weekend.  It's not going to be a trivial fix.

Take it easy,
Brad

On 5/31/2010 11:07 PM, Brad Roberts wrote:
> (replying off list on purpose)
> 
> On 5/29/2010 1:31 PM, Don Clugston wrote:
>> On 29 May 2010 02:57, Brad Roberts <braddr at puremagic.com> wrote:
>>> Excellent.  And if I might suggest 2 more goals for the next release:
>>>
>>>  1) close out at least 10 bugs that have patches
>>
>> Since the goal seems to be to encourage community involvement, I'd change that to:
> 
> I'm trying to train Walter as much as the community.  He needs to actively work to favor patches (regardless of who they're from) over doing it himself.  He knows he's set in his ways and that they aren't the best nor that they'll be sustainable.  So, hopefully these periodic gentle nudges will help him evolve his processes some.  That and the occasional in-person application of a sufficiently hard smack upside the head. :)
> 
> That said, I do agree with your change of goals.  All things being equal, I'd like to see them coming from as broad a collection of people as possible.
> 
> Lastly, I did spend some time looking at bug 3516 (the struct dtor bug) this weekend.  It's not going to be a trivial fix.
> 
> Take it easy,
> Brad

Well, my email skills are obviously in fine form tonight.

Sheepish grin,
Brad

Brad Roberts wrote:
>
> Well, my email skills are obviously in fine form tonight.
>
> Sheepish grin,
> Brad
>
> 

<g>

These are done now (3554 is actually 3547)

Don Clugston wrote:
> On 29 May 2010 02:57, Brad Roberts <braddr at puremagic.com> wrote:
> 
>> Excellent.  And if I might suggest 2 more goals for the next release:
>>
>>  1) close out at least 10 bugs that have patches
>> 
>
> Since the goal seems to be to encourage community involvement, I'd
> change that to:
> close bugs with patches by at least 5 different authors. Most the last
> dozen releases have had ten of my patches included, I don't think
> anyone will be terribly excited if that happens again. I think there's
> already 3 authors represented in the next release.
> I suggest these bugs which look pretty straightforward (and therefore
> unlikely to cause regressions):
> 3651 mangleof broken for enums   (by mpiepk)
> 4084 Ignored missing main() closing bracket  (ellery newcomer)
> 2881 x.stringof returns typeof(x).stringof when x is an enum (nfxjfg)
> 3854 Error on static initialization of arrays with trailing comma.
> (regression, ibuclaw/ellery newcomer)
> 3554 for option -od for relative path the path is added twice
> (regression, thecybershadow)
>
> 
>>  2) close out at least 5 bugs marked as regressions
>> 
>
> 1193 regression: "matches more than one template declaration" doesn't list the location of the conflicting templates  (bradr)
>
> is the only other regression with an up-to-date, trouble-free patch. So I think that's a tough ask.
>
> But really, the patch for the inliner bug 2127 is the most important.
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
>
>