phobos commit, revision 1714


user: andrei

msg:
Unlisted bug in Map.save and a few stylistic changes

http://www.dsource.org/projects/phobos/changeset/1714

Looking at this commit, I realize that I forgot to copy cacheIsBack, but should Map (and higher order ranges in general) really just return this for save()?  Suppose the base range is something w/ a non-trivial save() function.  Shouldn't this function be called when saving the higher order range?

On 7/4/2010 5:04 PM, dsource.org wrote:
> phobos commit, revision 1714
>
>
> user: andrei
>
> msg:
> Unlisted bug in Map.save and a few stylistic changes
>
> http://www.dsource.org/projects/phobos/changeset/1714
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
> 

You are right, my fix is incorrect. The result needs to store _input.save, not _input. I'll fix the fix soon.

Andrei

David Simcha wrote:
> Looking at this commit, I realize that I forgot to copy cacheIsBack, but should Map (and higher order ranges in general) really just return this for save()?  Suppose the base range is something w/ a non-trivial save() function.  Shouldn't this function be called when saving the higher order range?
> 
> On 7/4/2010 5:04 PM, dsource.org wrote:
>> phobos commit, revision 1714
>>
>>
>> user: andrei
>>
>> msg:
>> Unlisted bug in Map.save and a few stylistic changes
>>
>> http://www.dsource.org/projects/phobos/changeset/1714
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
>> 
> 
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos