phobos commit, revision 1683


user: rsinfu

msg:
[1.x] Fixed bugzilla 978: std.utf's toUTF* functions accept some invalid and reject some valid UTF.

* Fixed decode() to accept U+FFFE and U+FFFF.
* Changed some assert contracts (which check input for validity) to if-throw.

http://www.dsource.org/projects/phobos/changeset/1683

This breaks the unit tests:

Error: AssertError Failure std\utf.d(433)

dsource.org wrote:
> phobos commit, revision 1683
>
>
> user: rsinfu
>
> msg:
> [1.x] Fixed bugzilla 978: std.utf's toUTF* functions accept some invalid and reject some valid UTF.
>
> * Fixed decode() to accept U+FFFE and U+FFFF.
> * Changed some assert contracts (which check input for validity) to if-throw.
>
> http://www.dsource.org/projects/phobos/changeset/1683
>
> 

http://www.dsource.org/projects/phobos/changeset/1911

I'm sorry, it's my fault.  I think I fixed it (unittest passed). Though on my setup assertion failure was raised at line 290 in utf.d. Is this changeset actually fixes the broken test?


Walter Bright <walter at digitalmars.com> wrote:
> This breaks the unit tests:
> 
> Error: AssertError Failure std\utf.d(433)
> 
> dsource.org wrote:
> > phobos commit, revision 1683
> >
> >
> > user: rsinfu
> >
> > msg:
> > [1.x] Fixed bugzilla 978: std.utf's toUTF* functions accept some invalid and reject some valid UTF.
> >
> > * Fixed decode() to accept U+FFFE and U+FFFF.
> > * Changed some assert contracts (which check input for validity) to if-throw.
> >
> > http://www.dsource.org/projects/phobos/changeset/1683
> >
> > 

It works now, thanks!

Shin Fujishiro wrote:
> http://www.dsource.org/projects/phobos/changeset/1911
>
> I'm sorry, it's my fault.  I think I fixed it (unittest passed). Though on my setup assertion failure was raised at line 290 in utf.d. Is this changeset actually fixes the broken test?
>
>
> Walter Bright <walter at digitalmars.com> wrote:
> 
>> This breaks the unit tests:
>>
>> Error: AssertError Failure std\utf.d(433)
>>
>> dsource.org wrote:
>> 
>>> phobos commit, revision 1683
>>>
>>>
>>> user: rsinfu
>>>
>>> msg:
>>> [1.x] Fixed bugzilla 978: std.utf's toUTF* functions accept some invalid and reject some valid UTF.
>>>
>>> * Fixed decode() to accept U+FFFE and U+FFFF.
>>> * Changed some assert contracts (which check input for validity) to if-throw.
>>>
>>> http://www.dsource.org/projects/phobos/changeset/1683
>>>
>>> 
>>> 
>
>