Thread overview
[dmd-internals] failure test no longer failing
Sep 12, 2010
Brad Roberts
Sep 12, 2010
Walter Bright
Sep 12, 2010
Brad Roberts
September 11, 2010
http://d.puremagic.com/test-results/test_data.ghtml?dataid=1773 http://www.dsource.org/projects/dmd/browser/trunk/test/fail_compilation/fail83.d

$ more fail_compilation/fail83.d
// this code causes a compiler GPF

template fn( T ) {
     void fn() {
     }
}

template fn( T ) {
     void fn( T val ) {
     }
}

void main() {
     fn!(int)( 1 );
}

This code looks fine to me and no longer fails to compile with the checkins in the last hour or so.  I assume that the private test suite has just added a test similar to this one to a 'it should run successfully' test and that it should be removed from the 'it fails to compile' side of things -- well, really, should never have been in it, but I'll not start that rant today.

Thoughts?

Thanks,
Brad
September 11, 2010
The code looks right to me, I don't know why it's in the fail suite.

Brad Roberts wrote:
> http://d.puremagic.com/test-results/test_data.ghtml?dataid=1773 http://www.dsource.org/projects/dmd/browser/trunk/test/fail_compilation/fail83.d
>
> $ more fail_compilation/fail83.d
> // this code causes a compiler GPF
>
> template fn( T ) {
>      void fn() {
>      }
> }
>
> template fn( T ) {
>      void fn( T val ) {
>      }
> }
>
> void main() {
>      fn!(int)( 1 );
> }
>
> This code looks fine to me and no longer fails to compile with the checkins in the last hour or so.  I assume that the private test suite has just added a test similar to this one to a 'it should run successfully' test and that it should be removed from the 'it fails to compile' side of things -- well, really, should never have been in it, but I'll not start that rant today.
>
> Thoughts?
>
> Thanks,
> Brad
>
> 
September 11, 2010
Well, it's not any more. :P

On 9/11/2010 8:30 PM, Walter Bright wrote:
> The code looks right to me, I don't know why it's in the fail suite.
> 
> Brad Roberts wrote:
>> http://d.puremagic.com/test-results/test_data.ghtml?dataid=1773 http://www.dsource.org/projects/dmd/browser/trunk/test/fail_compilation/fail83.d
>>
>> $ more fail_compilation/fail83.d
>> // this code causes a compiler GPF
>>
>> template fn( T ) {
>>      void fn() {
>>      }
>> }
>>
>> template fn( T ) {
>>      void fn( T val ) {
>>      }
>> }
>>
>> void main() {
>>      fn!(int)( 1 );
>> }
>>
>> This code looks fine to me and no longer fails to compile with the checkins in the last hour or so.  I assume that the private test suite has just added a test similar to this one to a 'it should run successfully' test and that it should be removed from the 'it fails to compile' side of things -- well, really, should never have been in it, but I'll not start that rant today.
>>
>> Thoughts?
>>
>> Thanks,
>> Brad