Branch: refs/heads/master
Home:   https://github.com/D-Programming-Language/phobos

Commit: ac040713d33bdb959007248cd695a1554c574dd0
    https://github.com/D-Programming-Language/phobos/commit/ac040713d33bdb959007248cd695a1554c574dd0
Author: jmdavis <jmdavisProg at gmx.com>
Date:   2011-02-19 (Sat, 19 Feb 2011)

Changed paths:
  M std/datetime.d

Log Message:
-----------
std.datetime fixed so that it doesn't need the daylight variable on Posix.

It will still use daylight if it's there, but since FreeBSD doesn't have it for some reason (in spite of the fact that the daylight variable is part of Posix), we can't assume that it's there.

Also, now that tzname is in druntime, it has been removed from std.datetime.

This should fix bug# 5616.


Commit: a536c893368084128cbbc37cd69babe7e30bbea1
    https://github.com/D-Programming-Language/phobos/commit/a536c893368084128cbbc37cd69babe7e30bbea1
Author: Brad Roberts <braddr at puremagic.com>
Date:   2011-02-19 (Sat, 19 Feb 2011)

Changed paths:
  M std/datetime.d

Log Message:
-----------
the UTC zone file isn't in the same place on freebsd as linux and osx.

On Sunday 20 February 2011 02:05:28 noreply at github.com wrote:
> Branch: refs/heads/master
> Home:   https://github.com/D-Programming-Language/phobos
> 
> Commit: ac040713d33bdb959007248cd695a1554c574dd0
> 
> https://github.com/D-Programming-Language/phobos/commit/ac040713d33bdb9590
> 07248cd695a1554c574dd0 Author: jmdavis <jmdavisProg at gmx.com>
> Date:   2011-02-19 (Sat, 19 Feb 2011)
> 
> Changed paths:
>   M std/datetime.d
> 
> Log Message:
> -----------
> std.datetime fixed so that it doesn't need the daylight variable on Posix.
> 
> It will still use daylight if it's there, but since FreeBSD doesn't have it for some reason (in spite of the fact that the daylight variable is part of Posix), we can't assume that it's there.
> 
> Also, now that tzname is in druntime, it has been removed from std.datetime.
> 
> This should fix bug# 5616.
> 
> 
> Commit: a536c893368084128cbbc37cd69babe7e30bbea1
> 
> https://github.com/D-Programming-Language/phobos/commit/a536c893368084128c
> bbc37cd69babe7e30bbea1 Author: Brad Roberts <braddr at puremagic.com>
> Date:   2011-02-19 (Sat, 19 Feb 2011)
> 
> Changed paths:
>   M std/datetime.d
> 
> Log Message:
> -----------
> the UTC zone file isn't in the same place on freebsd as linux and osx.

There are _multiple_ UTC time zone files for whatever reason. On Linux, all of these files are identical:

/usr/share/zoneinfo/Etc/UTC
/usr/share/zoneinfo/UTC
/usr/share/zoneinfo/posix/Etc/UTC
/usr/share/zoneinfo/posix/UTC

I don't know why there are so many. The time zone files could arguably be cleaned up, because there are a number of them which are duplicates of one another (not just UTC). The FreeBSD folks probably decided that there was no point in having so many and didn't include some of them - kind of like how Mac OS X doesn have have any of the time zone files which would be in /usr/share/zoneinfo/right. I guess that this is just one more thing that goes to show that we'd benefit from having an autotester on all of the platforms that we release for.

By the way, we may want to make sure that we leave a message on pull requests when we merge them in, since it doesn't look like there's a way to determine who merged in a pull request if they didn't have to make any additional changes to it before they could push it into the main branch.

In this particular case, I assume that Brad did it, since he also made a change to fix a test for FreeBSD in std.datetime, but I don't know that for sure. And if for some reason I needed to contact whoever merged in a particular pull request, I don't see any way to know who they are if they didn't comment on the pull request or make any additional changes when doing the merge.

- Jonathan M Davis

On 2/20/2011 2:27 AM, Jonathan M Davis wrote:
> 
> There are _multiple_ UTC time zone files for whatever reason. On Linux, all of these files are identical:
> 
> /usr/share/zoneinfo/Etc/UTC
> /usr/share/zoneinfo/UTC
> /usr/share/zoneinfo/posix/Etc/UTC
> /usr/share/zoneinfo/posix/UTC
> 
> I don't know why there are so many. The time zone files could arguably be cleaned up, because there are a number of them which are duplicates of one another (not just UTC). The FreeBSD folks probably decided that there was no point in having so many and didn't include some of them - kind of like how Mac OS X doesn have have any of the time zone files which would be in /usr/share/zoneinfo/right. I guess that this is just one more thing that goes to show that we'd benefit from having an autotester on all of the platforms that we release for.
> 
> By the way, we may want to make sure that we leave a message on pull requests when we merge them in, since it doesn't look like there's a way to determine who merged in a pull request if they didn't have to make any additional changes to it before they could push it into the main branch.
> 
> In this particular case, I assume that Brad did it, since he also made a change to fix a test for FreeBSD in std.datetime, but I don't know that for sure. And if for some reason I needed to contact whoever merged in a particular pull request, I don't see any way to know who they are if they didn't comment on the pull request or make any additional changes when doing the merge.
> 
> - Jonathan M Davis

On freebsd 8.1, the only UTC file is Etc/UTC, so rather little choice in the matter.

I did indeed do the merge, as can be seen from the news feed:

  https://github.com/organizations/D-Programming-Language

That's the only place I see it though, which is unfortunate.  It's also barely visible from the push email from github to the phobos@ list.  I think it's worth filing an enhancement request with github to have who pushed it indicated in the pull request.  It auto-closed it, so there's already some hook between the two.  I'll file it.

Later,
Brad