As noted in https://github.com/D-Programming-Language/dmd/commit/cce360cdf1a79b5fce2fe003ce28f48708693885#commitcomment-417931 (but I suppose, nobody was notified by GitHub), my one-line change allowing bool as AA key type was reverted again. Did it cause any bugs I'm not aware of?

It's not like it would be of great real-world importance for me, but it does cause a test in my Thrift test-suite to fail?

David

On 6/16/2011 4:02 AM, David Nadlinger wrote:
> As noted in https://github.com/D-Programming-Language/dmd/commit/cce360cdf1a79b5fce2fe003ce28f48708693885#commitcomment-417931 (but I suppose, nobody was notified by GitHub), my one-line change allowing bool as AA key type was reverted again. Did it cause any bugs I'm not aware of?
>
> It's not like it would be of great real-world importance for me, but it does cause a test in my Thrift test-suite to fail?
>

It wasn't intentional, probably caused by folding in some other changes.

On 6/16/2011 4:02 AM, David Nadlinger wrote:
> As noted in https://github.com/D-Programming-Language/dmd/commit/cce360cdf1a79b5fce2fe003ce28f48708693885#commitcomment-417931 (but I suppose, nobody was notified by GitHub), my one-line change allowing bool as AA key type was reverted again. Did it cause any bugs I'm not aware of?
>
> It's not like it would be of great real-world importance for me, but it does cause a test in my Thrift test-suite to fail?
>
>

Hmm, your change is still in the current source code.

On 6/16/11 11:26 PM, Walter Bright wrote:
> Hmm, your change is still in the current source code.

Strange ? maybe that's in your local copy? The ?case Tbool:? line seems to be there again/still in Git master: https://github.com/D-Programming-Language/dmd/blob/master/src/mtype.c#L3996

It was removed by my commit b016286, but added in again by cce360c, probably by accident as it is unrelated to the DDoc fixes.

David