Thread overview
[dmd-internals] [D-Programming-Language/dmd] 31052b: refactor pull 336
Aug 27, 2011
Brad Roberts
Aug 27, 2011
Walter Bright
Aug 27, 2011
Brad Roberts
Aug 27, 2011
Walter Bright
August 26, 2011
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd

  Commit: 31052bdfdf6ab96e05200eb7087fdda84a7f49bc
      https://github.com/D-Programming-Language/dmd/commit/31052bdfdf6ab96e05200eb7087fdda84a7f49bc
  Author: Walter Bright <walter at walterbright.com>
  Date:   2011-08-26 (Fri, 26 Aug 2011)

  Changed paths:
    M src/attrib.c
  M src/parse.c
  M src/parse.h

  Log Message:
  -----------
  refactor pull 336


August 27, 2011
On Friday, August 26, 2011 11:06:13 PM, noreply at github.com wrote:
> Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/dmd
> 
>   Commit: 31052bdfdf6ab96e05200eb7087fdda84a7f49bc
>       https://github.com/D-Programming-Language/dmd/commit/31052bdfdf6ab96e05200eb7087fdda84a7f49bc
>   Author: Walter Bright <walter at walterbright.com>
>   Date:   2011-08-26 (Fri, 26 Aug 2011)
> 
>   Changed paths:
>     M src/attrib.c
>   M src/parse.c
>   M src/parse.h
> 
>   Log Message:
>   -----------
>   refactor pull 336

Many of the fail compilation tests compile successfully, but aren't expected to.  I'm assuming that since they were included with the first version of the code that it's the refactor that broke them.  There's a bunch:  fail4375a-m and o-y (n is missing).  Only p and q correctly fail to compile.


August 27, 2011

On 8/27/2011 12:03 AM, Brad Roberts wrote:
>
> Many of the fail compilation tests compile successfully, but aren't expected to.  I'm assuming that since they were included with the first version of the code that it's the refactor that broke them.  There's a bunch:  fail4375a-m and o-y (n is missing).  Only p and q correctly fail to compile.
>

Need to compile with -w. I made the check a warning.
August 27, 2011
On Saturday, August 27, 2011 2:27:19 AM, Walter Bright wrote:
> On 8/27/2011 12:03 AM, Brad Roberts wrote:
>>
>> Many of the fail compilation tests compile successfully, but aren't expected to.  I'm assuming that since they were included with the first version of the code that it's the refactor that broke them.  There's a bunch:  fail4375a-m and o-y (n is missing).  Only p and q correctly fail to compile.
>>
> 
> Need to compile with -w. I made the check a warning.

So, are you fixing it or are you expecting someone else to fix the tests you broke? :)
August 27, 2011

On 8/27/2011 11:16 AM, Brad Roberts wrote:
>
>> Need to compile with -w. I made the check a warning.
> So, are you fixing it or are you expecting someone else to fix the tests you broke? :)
>

So I gotta add REQUIRED_ARGS to all of them? :-(