For a while I got a lot of grief for the dmd test suite defaulting to looking for the dmd binary in ../src/.  It's been overridable for a long time with: make DMD=/path/to/dmd.  But just make DMD=dmd hasn't worked ever (unless the dmd binary was in the test directory, which I doubt anyone does).

I've been meaning to fix the DMD=dmd case for a long time.  While doing that, if there's a sufficiently large population that would rather make DMD=dmd be the default behavior rather than ../src, I'll go ahead and do that.  I'll change my habits and scripts to cope.

Thoughts?

Thanks,
Brad

On Nov 30, 2011, at 11:36 PM, Brad Roberts wrote:

> For a while I got a lot of grief for the dmd test suite defaulting to looking for the dmd binary in ../src/.  It's been overridable for a long time with: make DMD=/path/to/dmd.  But just make DMD=dmd hasn't worked ever (unless the dmd binary was in the test directory, which I doubt anyone does).
> 
> I've been meaning to fix the DMD=dmd case for a long time.  While doing that, if there's a sufficiently large population that would rather make DMD=dmd be the default behavior rather than ../src, I'll go ahead and do that.  I'll change my habits and scripts to cope.
> 
> Thoughts?

I think the current behavior is inconvenient, but is also the correct setup.  We wouldn't want the tester to use DMD from the user's path by default.  That should be an explicit override.  It's simple enough to make this an alias or whatever anyway if the typing is annoying.

On 12/2/2011 11:50 AM, Sean Kelly wrote:
> On Nov 30, 2011, at 11:36 PM, Brad Roberts wrote:
>
>> For a while I got a lot of grief for the dmd test suite defaulting to looking for the dmd binary in ../src/.  It's been overridable for a long time with: make DMD=/path/to/dmd.  But just make DMD=dmd hasn't worked ever (unless the dmd binary was in the test directory, which I doubt anyone does).
>>
>> I've been meaning to fix the DMD=dmd case for a long time.  While doing that, if there's a sufficiently large population that would rather make DMD=dmd be the default behavior rather than ../src, I'll go ahead and do that.  I'll change my habits and scripts to cope.
>>
>> Thoughts?
> I think the current behavior is inconvenient, but is also the correct setup.  We wouldn't want the tester to use DMD from the user's path by default.  That should be an explicit override.  It's simple enough to make this an alias or whatever anyway if the typing is annoying.
>

I often use makefiles that exist solely to override explicit paths in another makefile that it forwards the commands to. I find that more convenient than resetting global paths.

On Dec 2, 2011, at 12:29 PM, Walter Bright wrote:
> 
> On 12/2/2011 11:50 AM, Sean Kelly wrote:
>> On Nov 30, 2011, at 11:36 PM, Brad Roberts wrote:
>> 
>>> For a while I got a lot of grief for the dmd test suite defaulting to looking for the dmd binary in ../src/.  It's been overridable for a long time with: make DMD=/path/to/dmd.  But just make DMD=dmd hasn't worked ever (unless the dmd binary was in the test directory, which I doubt anyone does).
>>> 
>>> I've been meaning to fix the DMD=dmd case for a long time.  While doing that, if there's a sufficiently large population that would rather make DMD=dmd be the default behavior rather than ../src, I'll go ahead and do that.  I'll change my habits and scripts to cope.
>>> 
>>> Thoughts?
>> I think the current behavior is inconvenient, but is also the correct setup.  We wouldn't want the tester to use DMD from the user's path by default.  That should be an explicit override.  It's simple enough to make this an alias or whatever anyway if the typing is annoying.
>> 
> 
> I often use makefiles that exist solely to override explicit paths in another makefile that it forwards the commands to. I find that more convenient than resetting global paths.

I meant more:

export alias my-dtest='make DMD=/path/to/my/dmd'

On Fri, 2 Dec 2011, Walter Bright wrote:

> On 12/2/2011 11:50 AM, Sean Kelly wrote:
> > On Nov 30, 2011, at 11:36 PM, Brad Roberts wrote:
> > 
> > > For a while I got a lot of grief for the dmd test suite defaulting to
> > > looking for the dmd binary in ../src/.  It's been
> > > overridable for a long time with: make DMD=/path/to/dmd.  But just make
> > > DMD=dmd hasn't worked ever (unless the dmd
> > > binary was in the test directory, which I doubt anyone does).
> > > 
> > > I've been meaning to fix the DMD=dmd case for a long time.  While doing
> > > that, if there's a sufficiently large population
> > > that would rather make DMD=dmd be the default behavior rather than ../src,
> > > I'll go ahead and do that.  I'll change my
> > > habits and scripts to cope.
> > > 
> > > Thoughts?
> > I think the current behavior is inconvenient, but is also the correct setup. We wouldn't want the tester to use DMD from the user's path by default. That should be an explicit override.  It's simple enough to make this an alias or whatever anyway if the typing is annoying.
> > 
> 
> I often use makefiles that exist solely to override explicit paths in another makefile that it forwards the commands to. I find that more convenient than resetting global paths.

Sorry, I can't tell what your preference was.  Can you restate that in the form of an explicit opinion on what the tester's makefile should do?

On 12/2/2011 12:52 PM, Brad Roberts wrote:
>
> Sorry, I can't tell what your preference was.  Can you restate that in the form of an explicit opinion on what the tester's makefile should do?
>

I don't have an opinion on that. Do what you think is best with the auto-tester.

On Fri, 2 Dec 2011, Walter Bright wrote:

> On 12/2/2011 12:52 PM, Brad Roberts wrote:
> > 
> > Sorry, I can't tell what your preference was.  Can you restate that in the form of an explicit opinion on what the tester's makefile should do?
> > 
> 
> I don't have an opinion on that. Do what you think is best with the auto-tester.

Sorry, bad subject line.  We're talking about the test makefile that's part of the dmd code base, not the auto-tester.

On 12/2/2011 1:41 PM, Brad Roberts wrote:
> On Fri, 2 Dec 2011, Walter Bright wrote:
>
>> On 12/2/2011 12:52 PM, Brad Roberts wrote:
>>> Sorry, I can't tell what your preference was.  Can you restate that in the form of an explicit opinion on what the tester's makefile should do?
>>>
>> I don't have an opinion on that. Do what you think is best with the auto-tester.
> Sorry, bad subject line.  We're talking about the test makefile that's part of the dmd code base, not the auto-tester.
>

I suggest just leaving things as they are.