Thread overview
[phobos] [D-Programming-Language/phobos] a4220e: An attempt to fix std.format build.
Jul 09, 2012
GitHub
Jul 09, 2012
Jonathan M Davis
Jul 09, 2012
Jonathan M Davis
Jul 09, 2012
Daniel Murphy
July 08, 2012
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: a4220e3d79c252eadbeeb2ae65ca6fb25e98ec96
      https://github.com/D-Programming-Language/phobos/commit/a4220e3d79c252eadbeeb2ae65ca6fb25e98ec96
  Author: alexrp <alex@lycus.org>
  Date:   2012-07-08 (Sun, 08 Jul 2012)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  An attempt to fix std.format build.


  Commit: 8b3701bb294290f507a7026166599e869a93f978
      https://github.com/D-Programming-Language/phobos/commit/8b3701bb294290f507a7026166599e869a93f978
  Author: Andrei Alexandrescu <andrei@erdani.com>
  Date:   2012-07-08 (Sun, 08 Jul 2012)

  Changed paths:
    M std/format.d

  Log Message:
  -----------
  Merge pull request #672 from alexrp/master

An attempt to fix std.format build.


Compare: https://github.com/D-Programming-Language/phobos/compare/5cc381c00dc0...8b3701bb2942


July 08, 2012
On Sunday, July 08, 2012 20:51:42 GitHub wrote:
>   An attempt to fix std.format build.

Brad is going to have kittens when he sees how often the build was broken today. If we would just avoid pulling anything until the pull tester gives it the green light, we wouldn't have so many build breaks (though to be fair, there _was_ one OSX build break today that couldn't have been caught that way, since the pull tester doesn't currently test OSX).

- Jonathan M Davis
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

July 08, 2012
I think we've used the autotester today exactly the way it was supposed to be used.

Andrei

On 7/8/12 11:55 PM, Jonathan M Davis wrote:
> On Sunday, July 08, 2012 20:51:42 GitHub wrote:
>>    An attempt to fix std.format build.
>
> Brad is going to have kittens when he sees how often the build was broken
> today. If we would just avoid pulling anything until the pull tester gives it
> the green light, we wouldn't have so many build breaks (though to be fair,
> there _was_ one OSX build break today that couldn't have been caught that way,
> since the pull tester doesn't currently test OSX).
>
> - Jonathan M Davis
> _______________________________________________
> phobos mailing list
> phobos@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

July 08, 2012
On Sunday, July 08, 2012 23:58:31 Andrei Alexandrescu wrote:
> I think we've used the autotester today exactly the way it was supposed to be used.

Multiple merges were done which broke the build. Yes, we caught them and fixed them quickly, but if we _always_ made sure that the pull tester was green for a particular pull before merging it, we'd have almost no broken builds - just those on OS X (since the pull tester doesn't test OS X) and those caused by pull requests which depend on each other and must be merged at the same time. No other build breakage should occur.

I hate to complain, since it's great that you've spent as much time as you have dealing with pull requests today, and I thank you for it, but we're supposed to be avoiding breaking the build _at all_. That's why Brad added the pull tester.

- Jonathan M Davis
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

July 09, 2012
On Mon, Jul 9, 2012 at 1:58 PM, Andrei Alexandrescu <andrei@erdani.com> wrote:
> I think we've used the autotester today exactly the way it was supposed to be used.
>
> Andrei
>
>

Not _that_ autotester, the other one
(http://d.puremagic.com/test-results/pulls.ghtml).  The one that tells
you if a pull will work _before_ you break master.
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos