Thread overview | |||||
---|---|---|---|---|---|
|
July 28, 2012 [dmd-internals] [D-Programming-Language/dmd] 752f94: fix Issue 8434 - cannot implicitly convert express... | ||||
---|---|---|---|---|
| ||||
Attachments:
| Branch: refs/heads/master Home: https://github.com/D-Programming-Language/dmd Commit: 752f94c833bee38444340cff8186c9971388964f https://github.com/D-Programming-Language/dmd/commit/752f94c833bee38444340cff8186c9971388964f Author: k-hara <k.hara.pg@gmail.com> Date: 2012-07-28 (Sat, 28 Jul 2012) Changed paths: M src/opover.c M test/runnable/opover2.d Log Message: ----------- fix Issue 8434 - cannot implicitly convert expression (vs1.opCast()) of type const(Vector2D) to object.Object This is a regression of 2.058, by fixing issue 4088. The equality comparison of class objects should not run opCast. Commit: f3d5843fcb52600ddc0edcc2b04aa86ce48bfab1 https://github.com/D-Programming-Language/dmd/commit/f3d5843fcb52600ddc0edcc2b04aa86ce48bfab1 Author: Walter Bright <walter@walterbright.com> Date: 2012-07-28 (Sat, 28 Jul 2012) Changed paths: M src/opover.c M test/runnable/opover2.d Log Message: ----------- Merge pull request #1068 from 9rnsr/fix8434 Issue 8434 - cannot implicitly convert expression (vs1.opCast()) of type const(Vector2D) to object.Object Compare: https://github.com/D-Programming-Language/dmd/compare/c59699ae29dd...f3d5843fcb52 |
July 28, 2012 Re: [dmd-internals] [D-Programming-Language/dmd] 752f94: fix Issue 8434 - cannot implicitly convert express... | ||||
---|---|---|---|---|
| ||||
Posted in reply to GitHub | Ahem.. Walter, you merged another broken pull request. Please check the tester first.. let it do it's job. Hara, did it pass the tests on your box before you submitted the pull request? On 7/28/2012 2:37 PM, GitHub wrote: > Branch: refs/heads/master > Home: https://github.com/D-Programming-Language/dmd > Commit: 752f94c833bee38444340cff8186c9971388964f > https://github.com/D-Programming-Language/dmd/commit/752f94c833bee38444340cff8186c9971388964f > Author: k-hara <k.hara.pg@gmail.com> > Date: 2012-07-28 (Sat, 28 Jul 2012) > > Changed paths: > M src/opover.c > M test/runnable/opover2.d > > Log Message: > ----------- > fix Issue 8434 - cannot implicitly convert expression (vs1.opCast()) of type const(Vector2D) to object.Object > > This is a regression of 2.058, by fixing issue 4088. > The equality comparison of class objects should not run opCast. > > > Commit: f3d5843fcb52600ddc0edcc2b04aa86ce48bfab1 > https://github.com/D-Programming-Language/dmd/commit/f3d5843fcb52600ddc0edcc2b04aa86ce48bfab1 > Author: Walter Bright <walter@walterbright.com> > Date: 2012-07-28 (Sat, 28 Jul 2012) > > Changed paths: > M src/opover.c > M test/runnable/opover2.d > > Log Message: > ----------- > Merge pull request #1068 from 9rnsr/fix8434 > > Issue 8434 - cannot implicitly convert expression (vs1.opCast()) of type const(Vector2D) to object.Object > > > Compare: https://github.com/D-Programming-Language/dmd/compare/c59699ae29dd...f3d5843fcb52 _______________________________________________ dmd-internals mailing list dmd-internals@puremagic.com http://lists.puremagic.com/mailman/listinfo/dmd-internals |
July 29, 2012 Re: [dmd-internals] [D-Programming-Language/dmd] 752f94: fix Issue 8434 - cannot implicitly convert express... | ||||
---|---|---|---|---|
| ||||
Posted in reply to Brad Roberts | 2012/7/29 Brad Roberts <braddr@puremagic.com>: > Ahem.. Walter, you merged another broken pull request. Please check the tester first.. let it do it's job. > > Hara, did it pass the tests on your box before you submitted the pull request? Sorry, I had checked just only the case which has no option. dmd -run test\runnable\opover2.d I think it is another -inline bug... Kenji Hara _______________________________________________ dmd-internals mailing list dmd-internals@puremagic.com http://lists.puremagic.com/mailman/listinfo/dmd-internals |
Copyright © 1999-2021 by the D Language Foundation