Andrei Alexandrescu, el 21 de August a las 10:53 me escribiste:
> On 8/21/12 9:21 AM, Leandro Lucarella wrote:
> >I think ideally somebody should review your commits, but if you've been offered commit rights, then it's implied you don't *need* review (nobody reviews Walter commits, not at least before they are pushed to the repo). Again, it would be ideal if somebody else review the patch, but I don't think it should be a blocker.
> >
> >But that's just *my* POV and I have no idea what does it mean for Walter to give commit rights (I guess is push rights in git terminology).
>
> The way it works for us at Facebook is that every line of code must be reviewed by another engineer than the one who wrote it. It is working very well for us.
>
> There are many positive consequences to this. If the rule were not in effect, I suspect the notion of "this code is mine" and "that code is yours" would immediately emerge. With peer review enforced it becomes clear that once a pull request is merged, it is owned by the entire team.

I know, I agree and every serious project that I know of (open source or otherwise) does that. I'm just saying this is not how DMD works *now* (nobody can review Walter's code now). The only authoritative reviewer now is Walter because is the only one that can commit.

I really wonder why do you usually write the same people say as if they were saying the opposite...

--
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
La esperanza es una amiga que nos presta la ilusión.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 8/21/12 7:03 PM, Leandro Lucarella wrote:
> The only authoritative reviewer
> now is Walter because is the only one that can commit.

That's not the case.

> I really wonder why do you usually write the same people say as if they
> were saying the opposite...

Actually you were factually wrong.


Andrei
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
> >The only authoritative reviewer
> >now is Walter because is the only one that can commit.
>
> That's not the case.

Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?

> >I really wonder why do you usually write the same people say as if they were saying the opposite...
>
> Actually you were factually wrong.

If you're going to say that so categorically, can you at least prove it with facts? If not to support your statements, at least to provide me with the necessary information I'm missing so I can learn how and who are pushing changes to the public DMD repo.

Thanks.

--
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Soy como una mosca, parada en el agua.
Y vos sos un transatlántico, querés nadar a mi lado.
Y me estás ahogando.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 22 August 2012 13:10, Leandro Lucarella <luca@llucax.com.ar> wrote:
> Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
>> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
>> >The only authoritative reviewer
>> >now is Walter because is the only one that can commit.
>>
>> That's not the case.
>
> Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?

I am, together with Kenji and Brad.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Don Clugston, el 22 de August a las 13:13 me escribiste:
> On 22 August 2012 13:10, Leandro Lucarella <luca@llucax.com.ar> wrote:
> > Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
> >> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
> >> >The only authoritative reviewer
> >> >now is Walter because is the only one that can commit.
> >>
> >> That's not the case.
> >
> > Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?
>
> I am, together with Kenji and Brad.

Thank you. I didn't know you were, Kenji said the invitation was recent and he was the trigger of all this thread. I didn't count Brad because AFAIK he usually only pushed infrastructure and auto-tester stuff.

And I'm curious, are your commits are previously peer-reviewed by anyone? Do you push other people's commits?

--
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
FINALMENTE EL CABALLITO FABIAN VA A PASAR UNA BUENA NAVIDAD
	-- Crónica TV
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 23 August 2012 01:02, Leandro Lucarella <luca@llucax.com.ar> wrote:
> Don Clugston, el 22 de August a las 13:13 me escribiste:
>> On 22 August 2012 13:10, Leandro Lucarella <luca@llucax.com.ar> wrote:
>> > Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
>> >> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
>> >> >The only authoritative reviewer
>> >> >now is Walter because is the only one that can commit.
>> >>
>> >> That's not the case.
>> >
>> > Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?
>>
>> I am, together with Kenji and Brad.
>
> Thank you. I didn't know you were, Kenji said the invitation was recent and he was the trigger of all this thread. I didn't count Brad because AFAIK he usually only pushed infrastructure and auto-tester stuff.
>
> And I'm curious, are your commits are previously peer-reviewed by anyone? Do you push other people's commits?

We *only* push other people's commits, not our own.
It is recent, I've only merged about a dozen so far, mostly old ones
created by Daniel (yebblies), whose patches have historically been the
most neglected
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Don Clugston, el 23 de August a las 08:53 me escribiste:
> On 23 August 2012 01:02, Leandro Lucarella <luca@llucax.com.ar> wrote:
> > Don Clugston, el 22 de August a las 13:13 me escribiste:
> >> On 22 August 2012 13:10, Leandro Lucarella <luca@llucax.com.ar> wrote:
> >> > Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
> >> >> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
> >> >> >The only authoritative reviewer
> >> >> >now is Walter because is the only one that can commit.
> >> >>
> >> >> That's not the case.
> >> >
> >> > Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?
> >>
> >> I am, together with Kenji and Brad.
> >
> > Thank you. I didn't know you were, Kenji said the invitation was recent and he was the trigger of all this thread. I didn't count Brad because AFAIK he usually only pushed infrastructure and auto-tester stuff.
> >
> > And I'm curious, are your commits are previously peer-reviewed by anyone? Do you push other people's commits?
>
> We *only* push other people's commits, not our own.
> It is recent, I've only merged about a dozen so far, mostly old ones
> created by Daniel (yebblies), whose patches have historically been the
> most neglected

http://www.youtube.com/watch?v=HHfOejlvVsY

It would be nice if all these changes in the development process weren't discussed or changed in secrecy, at least to stop people wrong being factually wrong about the it. You know, after all, being open is half of being open source ;)

BTW, I guess this still don't apply to Walter, or is him too only pushing other people's patches and making pull requests as any other developer?

--
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Ambition makes you look pretty ugly
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 23 August 2012 11:59, Leandro Lucarella <luca@llucax.com.ar> wrote:
> Don Clugston, el 23 de August a las 08:53 me escribiste:
>> On 23 August 2012 01:02, Leandro Lucarella <luca@llucax.com.ar> wrote:
>> > Don Clugston, el 22 de August a las 13:13 me escribiste:
>> >> On 22 August 2012 13:10, Leandro Lucarella <luca@llucax.com.ar> wrote:
>> >> > Andrei Alexandrescu, el 21 de August a las 19:14 me escribiste:
>> >> >> On 8/21/12 7:03 PM, Leandro Lucarella wrote:
>> >> >> >The only authoritative reviewer
>> >> >> >now is Walter because is the only one that can commit.
>> >> >>
>> >> >> That's not the case.
>> >> >
>> >> > Then I'm outdated, would you be kind enough to inform me which people is pushing changes to the DMD public repo other than Walter?
>> >>
>> >> I am, together with Kenji and Brad.
>> >
>> > Thank you. I didn't know you were, Kenji said the invitation was recent and he was the trigger of all this thread. I didn't count Brad because AFAIK he usually only pushed infrastructure and auto-tester stuff.
>> >
>> > And I'm curious, are your commits are previously peer-reviewed by anyone? Do you push other people's commits?
>>
>> We *only* push other people's commits, not our own.
>> It is recent, I've only merged about a dozen so far, mostly old ones
>> created by Daniel (yebblies), whose patches have historically been the
>> most neglected
>
> http://www.youtube.com/watch?v=HHfOejlvVsY
>
> It would be nice if all these changes in the development process weren't discussed or changed in secrecy, at least to stop people wrong being factually wrong about the it. You know, after all, being open is half of being open source ;)

Not so, the discussion was 100% on this list. You must just have missed it.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Don Clugston, el 23 de August a las 12:28 me escribiste:
> > It would be nice if all these changes in the development process weren't discussed or changed in secrecy, at least to stop people wrong being factually wrong about the it. You know, after all, being open is half of being open source ;)
>
> Not so, the discussion was 100% on this list. You must just have missed it.

I need more proof! Link? :P

If that's so, I bet it was derived from another topic and nobody updated the subject, otherwise I wouldn't missed it ;)

--
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Si pudiera acercarme un poco más, hacia vos
Te diría que me tiemblan los dos pies, cuando me mirás
Si supieras todo lo que me costó, llegar
Hoy sabrías que me cuesta respirar, cuando me mirás
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals