Thread overview
[dmd-internals] [D-Programming-Language/dmd] 846451: 2nd try at fixing 6763
Dec 13, 2011
kenji hara
Dec 13, 2011
kenji hara
December 12, 2011
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd

  Commit: 8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
      https://github.com/D-Programming-Language/dmd/commit/8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
  Author: Walter Bright <walter at walterbright.com>
  Date:   2011-12-12 (Mon, 12 Dec 2011)

  Changed paths:
    M src/mtype.c
  M test/compilable/test6056a.d
  M test/compilable/test6056b.d
  M test/compilable/test6056c.d
  M test/runnable/xtest46.d

  Log Message:
  -----------
  2nd try at fixing 6763


December 13, 2011
Sorry for my late replying.

Manual TypeTuple copying basically good. But some another bugs are introduced.
- Type::merge() change is not need. It reverts fix for 6056 & 7093.
- It is not only extern(Windows) problem, it is non-D linkage problem.
  Then Windows-only test isn't need. We can replace extern(Windows) to
extern(C).

Now I'm testing a patch based on your change. Thanks!

Kenji Hara

2011/12/13  <noreply at github.com>:
> ?Branch: refs/heads/master
> ?Home: ? https://github.com/D-Programming-Language/dmd
>
> ?Commit: 8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
> ? ? ?https://github.com/D-Programming-Language/dmd/commit/8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
> ?Author: Walter Bright <walter at walterbright.com>
> ?Date: ? 2011-12-12 (Mon, 12 Dec 2011)
>
> ?Changed paths:
> ? ?M src/mtype.c
> ?M test/compilable/test6056a.d
> ?M test/compilable/test6056b.d
> ?M test/compilable/test6056c.d
> ?M test/runnable/xtest46.d
>
> ?Log Message:
> ?-----------
> ?2nd try at fixing 6763
>
>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
December 13, 2011
Posted. https://github.com/D-Programming-Language/dmd/pull/557

Kenji Hara

2011/12/13 kenji hara <k.hara.pg at gmail.com>:
> Sorry for my late replying.
>
> Manual TypeTuple copying basically good. But some another bugs are introduced.
> - Type::merge() change is not need. It reverts fix for 6056 & 7093.
> - It is not only extern(Windows) problem, it is non-D linkage problem.
> ?Then Windows-only test isn't need. We can replace extern(Windows) to
> extern(C).
>
> Now I'm testing a patch based on your change. Thanks!
>
> Kenji Hara
>
> 2011/12/13 ?<noreply at github.com>:
>> ?Branch: refs/heads/master
>> ?Home: ? https://github.com/D-Programming-Language/dmd
>>
>> ?Commit: 8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
>> ? ? ?https://github.com/D-Programming-Language/dmd/commit/8464510b9ccd66850a9a3ffdb24dbc96e9ac4db2
>> ?Author: Walter Bright <walter at walterbright.com>
>> ?Date: ? 2011-12-12 (Mon, 12 Dec 2011)
>>
>> ?Changed paths:
>> ? ?M src/mtype.c
>> ?M test/compilable/test6056a.d
>> ?M test/compilable/test6056b.d
>> ?M test/compilable/test6056c.d
>> ?M test/runnable/xtest46.d
>>
>> ?Log Message:
>> ?-----------
>> ?2nd try at fixing 6763
>>
>>
>> _______________________________________________
>> dmd-internals mailing list
>> dmd-internals at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/dmd-internals