December 08, 2014 Re: Sorted Array Wrapper Range | ||||
---|---|---|---|---|
| ||||
Posted in reply to Tobias Pankrath | On Monday, 8 December 2014 at 15:43:37 UTC, Tobias Pankrath wrote:
> Was my fault. The phobos checkout didn't match my dmd version. Here is my current state (has some more unittest, bugs fixed, no assignment via SortedRange views on Sorted.): https://github.com/Panke/phobos/blob/sorted/std/container/sorted.d
Great! You should do a PR when you're satisfied! :)
Is there anything you need help with?
|
December 08, 2014 Re: Sorted Array Wrapper Range | ||||
---|---|---|---|---|
| ||||
Posted in reply to Tobias Pankrath | On Monday, 8 December 2014 at 15:43:37 UTC, Tobias Pankrath wrote: > Was my fault. The phobos checkout didn't match my dmd version. Here is my current state (has some more unittest, bugs fixed, no assignment via SortedRange views on Sorted.): https://github.com/Panke/phobos/blob/sorted/std/container/sorted.d You have an outdated reference to BinaryHeap at line 440 https://github.com/Panke/phobos/blob/sorted/std/container/sorted.d#L440 Should be replaced with Sorted I presume. |
December 10, 2014 Re: Sorted Array Wrapper Range | ||||
---|---|---|---|---|
| ||||
Posted in reply to Tobias Pankrath | On Monday, 8 December 2014 at 15:43:37 UTC, Tobias Pankrath wrote: > Was my fault. The phobos checkout didn't match my dmd version. Here is my current state (has some more unittest, bugs fixed, no assignment via SortedRange views on Sorted.): https://github.com/Panke/phobos/blob/sorted/std/container/sorted.d Further it's nicer to use new enum syntax at https://github.com/Panke/phobos/blob/sorted/std/container/sorted.d#L12 as enum isRAContainer(T) = isRandomAccessRange!(typeof(T.init[])) ... |
December 10, 2014 Re: Sorted Array Wrapper Range | ||||
---|---|---|---|---|
| ||||
Posted in reply to Nordlöw | On Monday, 8 December 2014 at 20:18:51 UTC, Nordlöw wrote: > Great! You should do a PR when you're satisfied! :) https://github.com/D-Programming-Language/phobos/pull/2793 |
Copyright © 1999-2021 by the D Language Foundation