I've also noticed a number of checkins to git that have trailing whitespace.

So, I re-check them in with the trailing whitespace removed.

The detab tool will do this for you. Please make detab part of your checkin process.

Brad, please have the autotester reject source files with trailing whitespace.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On Thu, 17 Jan 2013, Walter Bright wrote:

> I've also noticed a number of checkins to git that have trailing whitespace.
> 
> So, I re-check them in with the trailing whitespace removed.
> 
> The detab tool will do this for you. Please make detab part of your checkin process.
> 
> Brad, please have the autotester reject source files with trailing whitespace.

To repeat what I said before.  If someone else get's their repository
setup with the appropriate scripting and validates that it works nice and
happily, I'll then integreate it into the auto tester.  I don't have the
bandwidth to do both right now.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Or as a part of the 'build' or 'test' stage of each of the packages make files.  Make the compilation fail and the auto-tester has no work to do.

On Thu, 17 Jan 2013, Brad Roberts wrote:

> Date: Thu, 17 Jan 2013 18:08:49 -0800 (PST)
> From: Brad Roberts <braddr@slice-2.puremagic.com>
> To: Discuss the internals of DMD <dmd-internals@puremagic.com>
> Subject: Re: [dmd-internals] trailing whitespace on git
> 
> On Thu, 17 Jan 2013, Walter Bright wrote:
> 
> > I've also noticed a number of checkins to git that have trailing whitespace.
> > 
> > So, I re-check them in with the trailing whitespace removed.
> > 
> > The detab tool will do this for you. Please make detab part of your checkin process.
> > 
> > Brad, please have the autotester reject source files with trailing whitespace.
> 
> To repeat what I said before.  If someone else get's their repository setup with the appropriate scripting and validates that it works nice and happily, I'll then integreate it into the auto tester.  I don't have the bandwidth to do both right now.
> 
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/17/2013 6:10 PM, Brad Roberts wrote:
> Or as a part of the 'build' or 'test' stage of each of the packages make
> files.  Make the compilation fail and the auto-tester has no work to do.
>

That's an intriguing idea, but it won't work too well for me. My workflow creates tabs, CRLFs, etc., and having the build on my machine constantly break would be annoying. The canonicalization only matters on checkin.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

What if it only forced it in a release build, and warned for debug builds?

> make clean debdmd
Warning: File blah.c contains tabs/crlf/trailing whitespace ...

> make clean dmd
Fatal: File blah.c contains tabs/crlf/trailing whitespace

> make detab tolf dmd
...

On Fri, Jan 18, 2013 at 1:33 PM, Walter Bright <walter@digitalmars.com>wrote:

>
> On 1/17/2013 6:10 PM, Brad Roberts wrote:
>
>> Or as a part of the 'build' or 'test' stage of each of the packages make files.  Make the compilation fail and the auto-tester has no work to do.
>>
>>
> That's an intriguing idea, but it won't work too well for me. My workflow creates tabs, CRLFs, etc., and having the build on my machine constantly break would be annoying. The canonicalization only matters on checkin.
>
> ______________________________**_________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/**mailman/listinfo/dmd-internals<http://lists.puremagic.com/mailman/listinfo/dmd-internals>
>

On 18 jan 2013, at 03:33, Walter Bright <walter@digitalmars.com> wrote:

> That's an intriguing idea, but it won't work too well for me. My workflow creates tabs, CRLFs, etc., and having the build on my machine constantly break would be annoying. The canonicalization only matters on checkin.

The first thing I do with an editor is to make sure it uses Unix line endings. If it can't, it's not worth using.

Second, make sure it uses spaces as tabs.

What's left is then trailing whitespace. This can usually an editor handle as well, when saving a file.

So I don't see where you would get these tabs and Windows line endings from.

--
/Jacob Carlborg
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/18/2013 12:00 AM, Jacob Carlborg wrote:
>
> On 18 jan 2013, at 03:33, Walter Bright <walter@digitalmars.com> wrote:
>
>> That's an intriguing idea, but it won't work too well for me. My workflow creates tabs, CRLFs, etc., and having the build on my machine constantly break would be annoying. The canonicalization only matters on checkin.
> The first thing I do with an editor is to make sure it uses Unix line endings. If it can't, it's not worth using.
>
> Second, make sure it uses spaces as tabs.
>
> What's left is then trailing whitespace. This can usually an editor handle as well, when saving a file.
>
> So I don't see where you would get these tabs and Windows line endings from.
>

They're coming from other peoples' checkins. I run my sources through detab and tolf before checkin.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals