Thread overview
[Issue 5089] New: feqrel does not compile for floats
Oct 20, 2010
Austin Hastings
Jul 09, 2011
Mike Wey
October 20, 2010
http://d.puremagic.com/issues/show_bug.cgi?id=5089

           Summary: feqrel does not compile for floats
           Product: D
           Version: D2
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody@puremagic.com
        ReportedBy: ah08010-d@yahoo.com


--- Comment #0 from Austin Hastings <ah08010-d@yahoo.com> 2010-10-20 16:07:10 PDT ---
With 2.049, this code:
==========
module scratch;

import std.math;

void foo() {
    float a = 1, b = 1.00000000001;

    auto same = feqrel( a, b ) > 15;
}
==========

Emits this diagnostic:
==========
$ dmd scratch.d
d:\Devel\D\dmd2\windows\bin\..\..\src\phobos\std\math.d(3286): Error: function
std.math.feqrel!(float).feqrel has no return statement, but is expected to
return a value of type int
d:\Devel\D\dmd2\windows\bin\..\..\src\phobos\std\math.d(8): Error: template
instance std.math.feqrel!(float) error instantiating
==========

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 09, 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5089


Mike Wey <mike-wey@planet.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mike-wey@planet.nl


--- Comment #1 from Mike Wey <mike-wey@planet.nl> 2011-07-09 08:07:12 PDT ---
As far as i know Don wrote both the feqrel function in tango and phobos. But he has only fixed the one in tango to work with floats.

See: http://www.dsource.org/projects/tango/changeset/4108

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 28, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=5089


Lars T. Kyllingstad <bugzilla@kyllingen.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |bugzilla@kyllingen.net
         Resolution|                            |FIXED


--- Comment #2 from Lars T. Kyllingstad <bugzilla@kyllingen.net> 2012-05-28 14:04:18 PDT ---
https://github.com/donc/phobos/commit/a8aa8cdcd60d8e8a49a1febb48c079a515365cfc

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------