Thread overview
[Issue 5319] New: rt.critical/monitor: Add support for Solaris
Dec 04, 2010
Iain Buclaw
Feb 07, 2011
Brad Roberts
Feb 07, 2011
Brad Roberts
Feb 07, 2011
Iain Buclaw
December 04, 2010
http://d.puremagic.com/issues/show_bug.cgi?id=5319

           Summary: rt.critical/monitor: Add support for Solaris
           Product: D
           Version: D2
          Platform: All
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P2
         Component: druntime
        AssignedTo: sean@invisibleduck.org
        ReportedBy: ibuclaw@ubuntu.com


--- Comment #0 from Iain Buclaw <ibuclaw@ubuntu.com> 2010-12-04 14:02:41 PST ---
Patch:

--- druntime-trunk~/src/rt/critical.c    2010-08-05 09:59:36.000000000 +0100
+++ druntime-trunk/src/rt/critical.c    2010-12-04 21:45:34.417486613 +0000 @@ -82,7 +82,7 @@

 /* ================================= linux ============================ */

-#if linux || __APPLE__ || __FreeBSD__
+#if linux || __APPLE__ || __FreeBSD__ || __sun&&__SVR4

 #include <stdio.h>
 #include <stdlib.h>
--- druntime-trunk~/src/rt/monitor.c    2010-08-05 09:59:36.000000000 +0100
+++ druntime-trunk/src/rt/monitor.c    2010-12-04 21:42:17.513486612 +0000
@@ -15,7 +15,7 @@
 #include <assert.h>

 #if _WIN32
-#elif linux || __APPLE__ || __FreeBSD__
+#elif linux || __APPLE__ || __FreeBSD__ || __sun&&__SVR4
 #define USE_PTHREADS    1
 #else
 #endif

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
February 07, 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5319


Brad Roberts <braddr@puremagic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |braddr@puremagic.com
         Resolution|                            |FIXED


--- Comment #1 from Brad Roberts <braddr@puremagic.com> 2011-02-06 23:31:38 PST ---
https://github.com/D-Programming-Language/druntime/commit/1a7482679b8cf5df10d3b002beb51a285764a2a7

I used the version identifier that dmd uses, "Solaris".  I hope that's what GDC and LDC use.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
February 07, 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5319



--- Comment #2 from Brad Roberts <braddr@puremagic.com> 2011-02-06 23:32:56 PST ---
And the same change to critical_.d:

https://github.com/D-Programming-Language/druntime/commit/f33862c7b6084af61e79f6ab73ff86d97833221b

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
February 07, 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5319



--- Comment #3 from Iain Buclaw <ibuclaw@ubuntu.com> 2011-02-07 09:29:23 PST ---
Solaris isn't supported in core.sys.posix.pthreads though, is it? (Admittedly I have a largely unfinished patch to add Solaris support in druntime lingering in a VM somewhere, so maybe not too much of a worry).

Regards

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------